March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27364 ) Change subject: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1c96305839e6627a36655c2e64da64f0a6704896 Gerrit-Change-Number: 27364 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:45:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs)

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27362 ) Change subject: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1652e6d53f568f606b692b16d4198d5209df2d9c Gerrit-Change-Number: 27362 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:45:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27364 ) Change subject: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1c96305839e6627a36655c2e64da64f0a6704896 Gerrit-Change-Number: 27364 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs)

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27362 ) Change subject: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1652e6d53f568f606b692b16d4198d5209df2d9c Gerrit-Change-Number: 27362 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:42:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: ipa oml: Fix encoding of T3105

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 to look at the new patch set (#3). Change subject: ipa oml: Fix encoding of T3105 ...................................................................... ipa oml: Fix encoding of T3105 As the comment above the fix suggest, the encoding is in 10ms units. osmo-bts is also doing the proper: """ uint8_t t3105 = *TLVP_VAL(&tp, NM_ATT_BTS_AIR_TIMER); bts->t3105_ms = t3105 * 10; """ Related: SYS#5838 Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M tests/nanobts_omlattr/nanobts_omlattr_test.c M tests/nanobts_omlattr/nanobts_omlattr_test.ok 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/27363/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 Gerrit-Change-Number: 27363 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27364 ) Change subject: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper ...................................................................... tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper Change-Id: I1c96305839e6627a36655c2e64da64f0a6704896 --- M tests/nanobts_omlattr/nanobts_omlattr_test.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/27364/1 diff --git a/tests/nanobts_omlattr/nanobts_omlattr_test.c b/tests/nanobts_omlattr/nanobts_omlattr_test.c index 1b3cc8e..e15d20e 100644 --- a/tests/nanobts_omlattr/nanobts_omlattr_test.c +++ b/tests/nanobts_omlattr/nanobts_omlattr_test.c @@ -43,7 +43,7 @@ msgb = nanobts_attr_bts_get(bts); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); @@ -59,7 +59,7 @@ msgb = nanobts_attr_nse_get(bts->site_mgr); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); @@ -75,7 +75,7 @@ msgb = nanobts_attr_cell_get(bts); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); @@ -91,7 +91,7 @@ msgb = nanobts_attr_nsvc_get(bts); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); @@ -109,7 +109,7 @@ msgb = nanobts_attr_radio_get(bts, trx); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1c96305839e6627a36655c2e64da64f0a6704896 Gerrit-Change-Number: 27364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: ipa oml: Fix encoding of T3105

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 to look at the new patch set (#2). Change subject: ipa oml: Fix encoding of T3105 ...................................................................... ipa oml: Fix encoding of T3105 As the comment above the fix suggest, the encoding is in 10ms units. osmo-bts is also doing the proper: """ uint8_t t3105 = *TLVP_VAL(&tp, NM_ATT_BTS_AIR_TIMER); bts->t3105_ms = t3105 * 10; """ Related: SYS#5838 Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M tests/nanobts_omlattr/nanobts_omlattr_test.c M tests/nanobts_omlattr/nanobts_omlattr_test.ok 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/27363/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 Gerrit-Change-Number: 27363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: ipa oml: Fix encoding of T3105

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27363 ) Change subject: ipa oml: Fix encoding of T3105 ...................................................................... ipa oml: Fix encoding of T3105 As the comment above the fix suggest, the encoding is in 10ms units. osmo-bts is also doing the proper: """ uint8_t t3105 = *TLVP_VAL(&tp, NM_ATT_BTS_AIR_TIMER); bts->t3105_ms = t3105 * 10; """ Related: SYS#5838 Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/27363/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index aac0ddf..d5b4215 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -85,7 +85,7 @@ msgb_tv_fixed_put(msgb, NM_ATT_LDAVG_SLOTS, 2, buf); /* 10 milliseconds */ - msgb_tv_put(msgb, NM_ATT_BTS_AIR_TIMER, osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1)); + msgb_tv_put(msgb, NM_ATT_BTS_AIR_TIMER, osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1)/10); /* 10 retransmissions of physical config */ msgb_tv_put(msgb, NM_ATT_NY1, 10); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 Gerrit-Change-Number: 27363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs)

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27362 ) Change subject: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs) ...................................................................... doc: bsc.adoc: Update timer info from code (gsm_network_T_defs) Change-Id: I1652e6d53f568f606b692b16d4198d5209df2d9c --- M doc/manuals/chapters/bsc.adoc 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/27362/1 diff --git a/doc/manuals/chapters/bsc.adoc b/doc/manuals/chapters/bsc.adoc index 38f267c..bdc3d2b 100644 --- a/doc/manuals/chapters/bsc.adoc +++ b/doc/manuals/chapters/bsc.adoc @@ -63,18 +63,18 @@ .Configurable Timers |=== |node|timer|default|description -|network|t3101|10|Timeout for 'Immediate Assignment' (sec) -|network|t3103|?|Timeout for Handover (sec) -|network|t3105|40|Repetition of 'Physical Information' (sec) -|network|t3107|?|? -|network|t3109|?|RSL SACCH deactivation timeout (sec) -|network|t3111|?|RSL timeout to wait before releasing the RF channel (sec) -|network|t3113|60|Time to try paging for a subscriber (sec) -|network|t3115|?|? -|network|t3117|?|? -|network|t3119|?|? +|network|t3101|3|Timeout for 'Immediate Assignment' (sec) +|network|t3103|5|Timeout for Handover (sec) +|network|t3105|100|Repetition of 'Physical Information' (millisec) +|network|t3107|5|? +|network|t3109|5|RSL SACCH deactivation timeout (sec) +|network|t3111|2|RSL timeout to wait before releasing the RF channel (sec) +|network|t3113|7|Time to try paging for a subscriber (sec) +|network|t3115|10|? +|network|t3117|10|? +|network|t3119|10|? |network|t3122|10|Waiting time after 'Immediate Assignment Reject' -|network|t3141|?|? +|network|t3141|10|? |=== //TODO: split between BSC and MSC timers -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1652e6d53f568f606b692b16d4198d5209df2d9c Gerrit-Change-Number: 27362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... osmo-ggsn: update libgtp-queue_depth_32.patch Adjust to change in osmo-ggsn I6034b0fab2b2e5962314c2fca2f893246ce5cf4f ("libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)"). Set it to 128, as Pau suggested. Fix for: Applying patch libgtp-queue_depth_32.patch patching file gtp/queue.h Hunk #1 FAILED at 19. Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 --- A recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch D recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb 3 files changed, 36 insertions(+), 15 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Verified diff --git a/recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch b/recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch new file mode 100644 index 0000000..53ac7ef --- /dev/null +++ b/recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch @@ -0,0 +1,34 @@ +From 2e0112520892b8f6a794c16bf3d025a7d10a89a5 Mon Sep 17 00:00:00 2001 +From: Oliver Smith <osmith(a)sysmocom.de> +Date: Wed, 2 Mar 2022 11:24:31 +0100 +Subject: [PATCH] libgtp: set PDP_MAX to 128 + +Reduce PDP_MAX and therefore QUEUE_SIZE (which is PDP_MAX * 2, see +gtp/queue.h). Harald explained why: + + libgtp statically allocates immensely large queues for packet + re-transmissions by default, way too much to run OsmoSGSN or + OpenGGSN/OsmoGGSN on the small ARM926EJS of sysmoBTS 1002. + +Related: https://gerrit.osmocom.org/c/meta-telephony/+/4092/2#message-8ec2174fac6c0b… +Change-Id: I97d5db8f2def4d628a6c4e67c27f07c7200b94d4 +--- + gtp/pdp.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/gtp/pdp.h b/gtp/pdp.h +index 4dcdde46..9587f31e 100644 +--- a/gtp/pdp.h ++++ b/gtp/pdp.h +@@ -24,7 +24,7 @@ struct gsn_t; + #define LOGPDPX(ss, level, pdp, fmt, args...) \ + LOGP(ss, level, "PDP(%s:%u): " fmt, imsi_gtp2str(&(pdp)->imsi), (pdp)->nsapi, ## args) + +-#define PDP_MAX 1024 /* Max number of PDP contexts */ ++#define PDP_MAX 128 /* Max number of PDP contexts */ + #define PDP_MAXNSAPI 16 /* Max number of NSAPI */ + + #define PDP_EUA_ORG_IETF 0xF1 +-- +2.30.2 + diff --git a/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch b/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch deleted file mode 100644 index 52bc37b..0000000 --- a/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch +++ /dev/null @@ -1,13 +0,0 @@ -diff --git a/gtp/queue.h b/gtp/queue.h -index 556b6ef..d59a1a3 100644 ---- a/gtp/queue.h -+++ b/gtp/queue.h -@@ -19,7 +19,7 @@ - - #define QUEUE_DEBUG 0 /* Print debug information */ - --#define QUEUE_SIZE 1024 /* Size of retransmission queue */ -+#define QUEUE_SIZE 32 /* Size of retransmission queue */ - #define QUEUE_HASH_SIZE 65536 /* Size of hash table (2^16) */ - - struct qmsg_t { /* Holder for queued packets */ diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb index 28424e8..e45f7d1 100644 --- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb +++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb @@ -3,7 +3,7 @@ S = "${WORKDIR}/git" SRCREV = "${AUTOREV}" SRC_URI = "git://git.osmocom.org/osmo-ggsn \ - file://libgtp-queue_depth_32.patch \ + file://0001-libgtp-set-PDP_MAX-to-128.patch \ " PV = "1.8.0+gitr${SRCPV}" -PR = "${INC_PR}.0" +PR = "${INC_PR}.1" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022