March 2022 - gerrit-log - lists.osmocom.org

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: pespin, keith. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 2: (1 comment) File recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb: https://gerrit.osmocom.org/c/meta-telephony/+/27358/comment/60cea4c8_aa925b… PS2, Line 9: PR = "${INC_PR}.0" > I think you need to increase PR here to . […] it will increase automatically by INC_PR -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 13:06:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by pespin

Attention is currently required from: osmith, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 2: (1 comment) File recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb: https://gerrit.osmocom.org/c/meta-telephony/+/27358/comment/ea941fdd_08da42… PS2, Line 9: PR = "${INC_PR}.0" I think you need to increase PR here to .1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 12:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bts[master]: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27360 ) Change subject: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late ...................................................................... bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late If len is < 0, it means osmo_amr_rtp_dec() failed and some of the out variables there are not set. We should check the return code before continuing and using potentially uninitialized values. Change-Id: I76020c6b5dc8d3e52e8c5be8cdecdf8a0bb52ed9 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/60/27360/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 08a58bb..b100fab 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -441,6 +441,10 @@ len = osmo_amr_rtp_dec(msg_tch->l2h, msgb_l2len(msg_tch), &cmr_codec, &cmi, &ft_codec, &bfi, &sti); + if (len < 0) { + LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send invalid AMR payload\n"); + goto free_bad_msg; + } cmr = -1; ft = -1; for (i = 0; i < chan_state->codecs; i++) { @@ -478,10 +482,6 @@ LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "TCH mode invalid, please fix!\n"); goto free_bad_msg; } - if (len < 0) { - LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send invalid AMR payload\n"); - goto free_bad_msg; - } if (msgb_l2len(msg_tch) != len) { LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send payload with " "invalid length! (expecting %d, received %d)\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76020c6b5dc8d3e52e8c5be8cdecdf8a0bb52ed9 Gerrit-Change-Number: 27360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Thanks, I forgot to prepare and submit this patch. However, I'd go for PDP_MAX=128. […] Changed to PDP_MAX=128. I prefer to not spend more time on this, so I'd rather just set one value for all devices now and have the build fixed. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 12:53:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: osmith. Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 to look at the new patch set (#2). Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... osmo-ggsn: update libgtp-queue_depth_32.patch Adjust to change in osmo-ggsn I6034b0fab2b2e5962314c2fca2f893246ce5cf4f ("libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)"). Set it to 128, as Pau suggested. Fix for: Applying patch libgtp-queue_depth_32.patch patching file gtp/queue.h Hunk #1 FAILED at 19. Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 --- A recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch D recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb 3 files changed, 35 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/58/27358/2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch_osmo.sh: exclude .patch files

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27359 ) Change subject: lint: checkpatch_osmo.sh: exclude .patch files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I734452bc78d7e026292883f81bc07c3baf58e309 Gerrit-Change-Number: 27359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:37:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: rebase libgtp-queue_depth_32.patch

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: rebase libgtp-queue_depth_32.patch ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:37:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: rebase libgtp-queue_depth_32.patch

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: rebase libgtp-queue_depth_32.patch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks, I forgot to prepare and submit this patch. However, I'd go for PDP_MAX=128. See my first comment in https://gerrit.osmocom.org/c/osmo-ggsn/+/27352 it explains the calculations/assumptions there. I'm happy to discuss it further if needed. We could even have a separate patch (applied per machine, can be done in OE) which applies PDP_MAX 7*7 for sysmobts (which has 1 TRX, but iirc there was a sysmobts with 2 TRX?) -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:37:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:29:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch_osmo.sh: exclude .patch files

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27359 ) Change subject: lint: checkpatch_osmo.sh: exclude .patch files ...................................................................... lint: checkpatch_osmo.sh: exclude .patch files Change-Id: I734452bc78d7e026292883f81bc07c3baf58e309 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/59/27359/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index faf0fca..084a7ea 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -8,6 +8,8 @@ echo '--exclude \.(ok|err)$' # Generated from commit log, which may contain spelling errors (OS#5232) echo '--exclude ^debian/changelog$' + # Patch files + echo '--exclude \.patch$' } exclude_paths_common_asn1c() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I734452bc78d7e026292883f81bc07c3baf58e309 Gerrit-Change-Number: 27359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022