March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss'

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/27411 to look at the new patch set (#2). Change subject: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss' ...................................................................... osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss' This new rate counter allows to monitor the efficiency of the radio carrier cache used for routing Downlink bursts when baseband frequency hopping is in use. Change-Id: Ie6da829e47298476267c8df2dcedafad564cbbb4 Related: SYS#5855 --- M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/main.c M src/osmo-bts-trx/scheduler_trx.c 3 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/27411/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie6da829e47298476267c8df2dcedafad564cbbb4 Gerrit-Change-Number: 27411 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: VTY: fix ambiguity in BTS specific command definitions

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27412 ) Change subject: VTY: fix ambiguity in BTS specific command definitions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 Gerrit-Change-Number: 27412 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 10:00:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: VTY: fix ambiguity in BTS specific command definitions

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27412 ) Change subject: VTY: fix ambiguity in BTS specific command definitions ...................................................................... VTY: fix ambiguity in BTS specific command definitions Most of the BTS specific VTY commands restrict BTS number to '<0-0>', while bts_c0_power_red_cmd has '<0-255>'. This confuses libosmovty: OsmoBTS# bts ? <0-0> BTS number <0-255> BTS Number OsmoBTS# bts 0 ? % Ambiguous command. OsmoBTS# bts 0 c0-power-red 0 % Ambiguous command. Let's stick to '<0-0>', we don't support multiple BTS anyway. Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 --- M src/common/vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/27412/1 diff --git a/src/common/vty.c b/src/common/vty.c index 97bd658..8925999 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -1329,7 +1329,7 @@ DEFUN(bts_c0_power_red, bts_c0_power_red_cmd, - "bts <0-255> c0-power-red <0-6>", + "bts <0-0> c0-power-red <0-6>", "BTS Specific Commands\n" BTS_NR_STR "BCCH carrier power reduction operation\n" "Power reduction value (in dB, even numbers only)\n") -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 Gerrit-Change-Number: 27412 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27411 ) Change subject: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss' ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/27411/comment/92e63cab_27e9914a PS1, Line 11: baseband frequency hoppong is in use. hopping -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie6da829e47298476267c8df2dcedafad564cbbb4 Gerrit-Change-Number: 27411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:52:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: VTY: avoid printing duplicate rate_ctr/stat_item groups

by pespin

Attention is currently required from: laforge, fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27409 ) Change subject: VTY: avoid printing duplicate rate_ctr/stat_item groups ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not sure this assumption is correct. The way to go, imho, would be to use a hashtable or rbtree (based on a stack allocated pool of structs to store data), with key=group_name, so that we keep track over the groups already printed. If done this way it's pretty efficient in memory use as well as allocation (no heap allocation occurs). I did this recently in open5gs to track repeated IEs in TLV, see https://github.com/open5gs/open5gs/pull/1351/commits/1a518bff735b6c34639df4… -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1e66bc5720dfe255b480780aa9a0b76f4c0cc1fe Gerrit-Change-Number: 27409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:48:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: fix inp_sig_cb(): dispatch TS_EV_OML_DOWN to all transceivers

by pespin

Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16352 ) Change subject: fix inp_sig_cb(): dispatch TS_EV_OML_DOWN to all transceivers ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/16352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3dc657ac5a2c5334747bd4f4db1a658acb323942 Gerrit-Change-Number: 16352 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:42:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: Fix description of BTS_CTR_BTS_RSL_FAIL: s/OML/RSL/

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27408 ) Change subject: Fix description of BTS_CTR_BTS_RSL_FAIL: s/OML/RSL/ ...................................................................... Fix description of BTS_CTR_BTS_RSL_FAIL: s/OML/RSL/ Change-Id: Icc3e603b08ab81869955ffa5b16ddfb458e83c78 Related: OS#4848 --- M src/osmo-bsc/bts.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index c3e87b3..d09aa48 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -984,7 +984,7 @@ "Received a TEI down on a OML link" }, [BTS_CTR_BTS_RSL_FAIL] = \ { "rsl_fail", - "Received a TEI down on a OML link" }, + "Received a TEI down on a RSL link" }, [BTS_CTR_CODEC_AMR_F] = \ { "codec:amr_f", "Count the usage of AMR/F codec by channel mode requested" }, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc3e603b08ab81869955ffa5b16ddfb458e83c78 Gerrit-Change-Number: 27408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: cosmetic: use rate_ctr_inc2() instead of rate_ctr_inc()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27410 ) Change subject: osmo-bts-trx: cosmetic: use rate_ctr_inc2() instead of rate_ctr_inc() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id4c5999876ff284b80a021e075bf46eb9d4670a2 Gerrit-Change-Number: 27410 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Mar 2022 22:42:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: Fix description of BTS_CTR_BTS_RSL_FAIL: s/OML/RSL/

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27408 ) Change subject: Fix description of BTS_CTR_BTS_RSL_FAIL: s/OML/RSL/ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc3e603b08ab81869955ffa5b16ddfb458e83c78 Gerrit-Change-Number: 27408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Mar 2022 22:35:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: make use of OSMO_UNLIKELY() when handling TRXD PDUs

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27407 ) Change subject: osmo-bts-trx: make use of OSMO_UNLIKELY() when handling TRXD PDUs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9266aaf2bbc0acfe21e9bfb12c9f38621d120553 Gerrit-Change-Number: 27407 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Mar 2022 22:33:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022