March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ggsn[master]: gtp: Fix typo in comment

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27419 to look at the new patch set (#2). Change subject: gtp: Fix typo in comment ...................................................................... gtp: Fix typo in comment Change-Id: I0e38e0966081d8b37c3f816f5330b4f52f81b7fa --- M gtp/gtp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/19/27419/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0e38e0966081d8b37c3f816f5330b4f52f81b7fa Gerrit-Change-Number: 27419 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-gsm-manuals[master]: TESTING_CI: more tests

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27355 ) Change subject: TESTING_CI: more tests ...................................................................... Abandoned only for testing -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I0ab8ca5e846ba4437e72f7bf4c938df01c3b2369 Gerrit-Change-Number: 27355 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn_tests: Wait for retrans queues to drain after each test

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27420 ) Change subject: ggsn_tests: Wait for retrans queues to drain after each test ...................................................................... ggsn_tests: Wait for retrans queues to drain after each test Otherwise a new test may reuse the same GTP seqnum, and if it's still in the gtp retransmit resp queue of the GGSN, it may be identified as a duplicate retransmittion of a previous message (previous test) and send back the previous response instead of processing the request. Related: OS#5485 Change-Id: I1b04691987b883f63c95c0322a477db4a43df2b1 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 50 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/27420/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 05d335a..eb09555 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -259,6 +259,17 @@ } } + function f_shutdown_helper() runs on GT_CT { + /* Sleep N3_REQUESTS * T3_REQUEST seconds, nowadays 5*3=15s. + * This ensures all retransmit queues are cleared before jumping + * into next tests, hence avoding situation where a test resuses + * a seqnum still in the GGSN's resp queue (dup req detector). + * See OS#5485 avout decreasing time. We could also add a new + * VTY command that calls gtp_clear_queues() */ + f_sleep(15.0); + setverdict(pass); + } + /* Altstep implementing responses to any incoming echo requests */ private altstep pingpong() runs on GT_CT { var Gtp1cUnitdata ud; @@ -1023,6 +1034,7 @@ var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInet6, valueof(t_EuaIPv6Dyn))); f_pdp_ctx_act(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test IPv6 context activation for dynamic IPv6 EUA wirh request of IPv6 DNS in PCO */ @@ -1046,6 +1058,7 @@ } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv6 EUA with IPv6 DNS in PCO and router solicitation/advertisement */ @@ -1065,6 +1078,7 @@ f_send_gtpu(ctx, f_gen_icmpv6_neigh_solicit_for_pdp(ctx)); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv6 EUA with IPv6 DNS in PCO and router solicitation/advertisement. @@ -1096,6 +1110,7 @@ f_wait_icmp6_echo_reply(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Check that attempting RA with another ll src addr won't work, packet dropped: */ @@ -1115,6 +1130,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Assert that packets with wrong global src addr are dropped by GGSN */ @@ -1135,6 +1151,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Send an IPv4 ICMP ECHO REQUEST to APN6, should fail (packet dropped */ @@ -1154,6 +1171,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Validate if different clients (pdp ctx) can reach one another through GGSN. */ @@ -1186,6 +1204,7 @@ f_pdp_ctx_del(ctxA, '1'B); f_pdp_ctx_del(ctxB, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA without DNS request */ @@ -1194,6 +1213,7 @@ var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn))); f_pdp_ctx_act(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in IPCP */ @@ -1219,6 +1239,7 @@ } } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in IPCP + PAP authentication (broken) */ @@ -1252,6 +1273,7 @@ setverdict(fail, "PAP isn't an AuthenticateAck: ", pap); } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in PCO */ @@ -1274,6 +1296,7 @@ } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA. @@ -1293,6 +1316,7 @@ f_wait_icmp4_echo_reply(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Assert that packets with wrong global src addr are dropped by GGSN */ @@ -1310,6 +1334,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Send an IPv6 RA to APN4, should fail (packet dropped) */ @@ -1325,6 +1350,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Helper function for tests below. */ @@ -1347,12 +1373,14 @@ testcase TC_pdp4_clients_interact_with_txseq() runs on GT_CT { use_gtpu_txseq := true; f_pdp4_clients_interact(); + f_shutdown_helper(); } /* Validate if different clients (pdp ctx) can reach one another through GGSN (without Tx sequence number). */ testcase TC_pdp4_clients_interact_without_txseq() runs on GT_CT { use_gtpu_txseq := false; f_pdp4_clients_interact(); + f_shutdown_helper(); } testcase TC_echo_req_resp() runs on GT_CT { @@ -1365,6 +1393,7 @@ [] T_default.timeout { setverdict(fail); } } T_default.stop; + f_shutdown_helper(); } testcase TC_echo_req_resp_gtpu() runs on GT_CT { @@ -1377,6 +1406,7 @@ [] T_default.timeout { setverdict(fail); } } T_default.stop; + f_shutdown_helper(); } /* Test if the parser can cope with PCO that only contain either a @@ -1422,6 +1452,7 @@ setverdict(fail, "Secondary DNS IPv4 PCO option not found"); } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test if the parser can cope with PCO that contains primary and secondary DNS in a separate IPCP container. @@ -1458,6 +1489,7 @@ setverdict(fail, "Secondary DNS IPv4 PCO option not found"); } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Validate that SUT updates remote TEIC when requested through UpdatePDPContextRequest */ @@ -1473,6 +1505,7 @@ f_pdp_ctx_update(ctx, new_teic := new_teic); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Validate that SUT updates remote TEID when requested through UpdatePDPContextRequest */ @@ -1500,6 +1533,7 @@ f_wait_icmp4_echo_reply(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA without DNS request */ @@ -1508,6 +1542,7 @@ var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInet46, valueof(t_EuaIPv4Dynv6Dyn))); f_pdp_ctx_act(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4v6 EUA with IPv4 DNS in IPCP */ @@ -1534,6 +1569,7 @@ } } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4v6 EUA with IPv6 DNS in PCO and router solicitation/advertisement */ @@ -1548,6 +1584,7 @@ f_send_gtpu(ctx, f_gen_icmpv6_neigh_solicit_for_pdp46(ctx)); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA with request of IPv4 DNS in PCO */ @@ -1571,6 +1608,7 @@ } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA with request of IPv6 DNS in PCO */ @@ -1594,6 +1632,7 @@ } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4v6 EUA. @@ -1612,6 +1651,7 @@ f_wait_icmp4_echo_reply(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Assert that packets with wrong ipv4 src addr are dropped by GGSN on APN IPv4v6 */ @@ -1628,6 +1668,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Check that attempting RA with another ll src addr won't work, packet dropped: */ @@ -1643,6 +1684,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Assert that packets with wrong ipv6 global src addr are dropped by GGSN on APN IPv4v6 */ @@ -1663,6 +1705,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Validate if different clients (pdp ctx) can reach one another through GGSN. */ @@ -1695,6 +1738,7 @@ f_pdp_ctx_del(ctxA, '1'B); f_pdp_ctx_del(ctxB, '1'B); + f_shutdown_helper(); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA on a v4-only APN */ @@ -1733,6 +1777,7 @@ f_pdp_ctx_del(ctx4, '1'B); } + f_shutdown_helper(); } /* Validate if 2nd CtxCreateReq with increased Recovery IE causes ggsn to drop 1st one (while keeping 2nd one). */ @@ -1795,6 +1840,7 @@ T_default.stop; f_pdp_ctx_del(ctxB, '1'B); + f_shutdown_helper(); } @@ -1817,6 +1863,7 @@ /* Now send a new pdp ctx del (increased seqnum). It should fail with cause "non-existent": */ var OCT1 cause_nonexistent := 'C0'O; f_pdp_ctx_del(ctx, '1'B, cause_nonexistent, expect_diameter := false); + f_shutdown_helper(); } /* Activate PDP context + trigger Recovery procedure through EchoResp */ @@ -1859,7 +1906,7 @@ } T_echo.stop; f_pdp_ctx_exp_del_req(ctx, omit, true); - setverdict(pass); + f_shutdown_helper(); } /* Test creation, user plane and deletion of big amount (1000) of concurrent PDP context */ @@ -1972,7 +2019,7 @@ T_next.stop; T_default.stop; - setverdict(pass); + f_shutdown_helper(); } /* Test callocation of PDP contexts until reaching addr pool exhaustion */ @@ -2073,7 +2120,7 @@ T_next.stop; T_default.stop; - setverdict(pass); + f_shutdown_helper(); } control { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b04691987b883f63c95c0322a477db4a43df2b1 Gerrit-Change-Number: 27420 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: support "empty" SCCP N-Connect from MSC

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27373 ) Change subject: support "empty" SCCP N-Connect from MSC ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: combine -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I535c791fa01e99a2226392eb05f676ba6c3cc16e Gerrit-Change-Number: 27373 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 13:40:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27419 ) Change subject: gtp: Fix typo in comment ...................................................................... gtp: Fix typo in comment Change-Id: I0e38e0966081d8b37c3f816f5330b4f52f81b7fa --- M gtp/gtp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/19/27419/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 672c5f0..2544555 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -405,7 +405,7 @@ * element has expired */ while ((!queue_getfirst(gsn->queue_req, &qmsg)) && (qmsg->timeout <= now)) { - if (qmsg->retrans > N3_REQUESTS) { /* To many retrans */ + if (qmsg->retrans > N3_REQUESTS) { /* Too many retrans */ LOGP(DLGTP, LOGL_NOTICE, "Retransmit req queue timeout of seq %" PRIu16 "\n", qmsg->seq); if (gsn->cb_conf) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0e38e0966081d8b37c3f816f5330b4f52f81b7fa Gerrit-Change-Number: 27419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Log retrans queue register&free entries

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27417 ) Change subject: gtp: Log retrans queue register&free entries ...................................................................... gtp: Log retrans queue register&free entries Change-Id: I4e12376652fc7a6a96fbdcb579dbe916c1473012 --- M gtp/gtp.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/17/27417/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 608e5f9..9cbeaa8 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -633,6 +633,8 @@ LOGP(DLGTP, LOGL_ERROR, "Retransmit req queue is full (seq=%" PRIu16 ")\n", gsn->seq_next); } else { + LOGP(DLGTP, LOGL_DEBUG, "Registering seq=% " PRIu16 + " in restransmit req queue\n", gsn->seq_next); memcpy(&qmsg->p, packet, sizeof(union gtp_packet)); qmsg->l = len; qmsg->timeout = time(NULL) + T3_REQUEST; /* When to timeout */ @@ -761,6 +763,8 @@ LOGP(DLGTP, LOGL_ERROR, "Retransmit resp queue is full (seq=%" PRIu16 ")\n", seq); } else { + LOGP(DLGTP, LOGL_DEBUG, "Registering seq=% " PRIu16 + " in restransmit resp queue\n", seq); memcpy(&qmsg->p, packet, sizeof(union gtp_packet)); qmsg->l = len; qmsg->timeout = time(NULL) + 60; /* When to timeout */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4e12376652fc7a6a96fbdcb579dbe916c1473012 Gerrit-Change-Number: 27417 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: Trace retransmit queues lifceycle through DEBUG log level

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27418 ) Change subject: Trace retransmit queues lifceycle through DEBUG log level ...................................................................... Trace retransmit queues lifceycle through DEBUG log level Change-Id: I3e7658e882baf6425f8959ccb3c36e29b5be2dcd --- M gtp/gtp.c 1 file changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/18/27418/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 9cbeaa8..672c5f0 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -400,15 +400,13 @@ time_t now; struct qmsg_t *qmsg; now = time(NULL); - /*printf("Retrans: New beginning %d\n", (int) now); */ /* get first element in queue, as long as the timeout of that * element has expired */ while ((!queue_getfirst(gsn->queue_req, &qmsg)) && (qmsg->timeout <= now)) { - /*printf("Retrans timeout found: %d\n", (int) time(NULL)); */ if (qmsg->retrans > N3_REQUESTS) { /* To many retrans */ - LOGP(DLGTP, LOGL_NOTICE, "Timeout of seq %" PRIu16 "\n", + LOGP(DLGTP, LOGL_NOTICE, "Retransmit req queue timeout of seq %" PRIu16 "\n", qmsg->seq); if (gsn->cb_conf) gsn->cb_conf(qmsg->type, EOF, NULL, qmsg->cbp); @@ -434,7 +432,8 @@ /* Also clean up reply timeouts */ while ((!queue_getfirst(gsn->queue_resp, &qmsg)) && (qmsg->timeout < now)) { - /*printf("Retrans (reply) timeout found: %d\n", (int) time(NULL)); */ + LOGP(DLGTP, LOGL_DEBUG, "Retransmit resp queue seq %" + PRIu16 " expired, removing from queue\n", qmsg->seq); queue_freemsg(gsn->queue_resp, qmsg); } @@ -633,7 +632,7 @@ LOGP(DLGTP, LOGL_ERROR, "Retransmit req queue is full (seq=%" PRIu16 ")\n", gsn->seq_next); } else { - LOGP(DLGTP, LOGL_DEBUG, "Registering seq=% " PRIu16 + LOGP(DLGTP, LOGL_DEBUG, "Registering seq=%" PRIu16 " in restransmit req queue\n", gsn->seq_next); memcpy(&qmsg->p, packet, sizeof(union gtp_packet)); qmsg->l = len; @@ -662,6 +661,7 @@ { struct qmsg_t *qmsg; + LOGP(DLGTP, LOGL_INFO, "Clearing req & resp retransmit queues\n"); while (!queue_getfirst(gsn->queue_req, &qmsg)) { queue_freemsg(gsn->queue_req, qmsg); } @@ -691,10 +691,14 @@ return EOF; } + GTP_LOGPKG(LOGL_DEBUG, peer, packet, len, + "Freeing seq=%" PRIu16 " from retransmit req queue\n", + seq); if (queue_freemsg_seq(gsn->queue_req, peer, seq, type, cbp)) { gsn->err_seq++; GTP_LOGPKG(LOGL_ERROR, peer, packet, len, - "Confirmation packet not found in queue\n"); + "Confirmation packet not found in retransmit req queue (seq=%" + PRIu16 ")\n", seq); return EOF; } @@ -763,7 +767,7 @@ LOGP(DLGTP, LOGL_ERROR, "Retransmit resp queue is full (seq=%" PRIu16 ")\n", seq); } else { - LOGP(DLGTP, LOGL_DEBUG, "Registering seq=% " PRIu16 + LOGP(DLGTP, LOGL_DEBUG, "Registering seq=%" PRIu16 " in restransmit resp queue\n", seq); memcpy(&qmsg->p, packet, sizeof(union gtp_packet)); qmsg->l = len; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3e7658e882baf6425f8959ccb3c36e29b5be2dcd Gerrit-Change-Number: 27418 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Specify retrans queue name & seqnum in log lines

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27416 to look at the new patch set (#4). Change subject: gtp: Specify retrans queue name & seqnum in log lines ...................................................................... gtp: Specify retrans queue name & seqnum in log lines Change-Id: I4f193d7a482ace33afd8526b5f50d2d03467d5fa --- M gtp/gtp.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/16/27416/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4f193d7a482ace33afd8526b5f50d2d03467d5fa Gerrit-Change-Number: 27416 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in docker-playground[master]: centos8-repo-install-test: set UPSTREAM_DISTRO=almalinux:8 in Makefile

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27401 ) Change subject: centos8-repo-install-test: set UPSTREAM_DISTRO=almalinux:8 in Makefile ...................................................................... centos8-repo-install-test: set UPSTREAM_DISTRO=almalinux:8 in Makefile Otherwise 'debian:bullseye' is used by default when running make. Change-Id: I1744f5199b1686ee615173572afee524104eb91f --- M centos8-repo-install-test/Makefile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/centos8-repo-install-test/Makefile b/centos8-repo-install-test/Makefile index 8d0e10b..977ec9c 100644 --- a/centos8-repo-install-test/Makefile +++ b/centos8-repo-install-test/Makefile @@ -1 +1,2 @@ +UPSTREAM_DISTRO=almalinux:8 include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1744f5199b1686ee615173572afee524104eb91f Gerrit-Change-Number: 27401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in docker-playground[master]: centos8-repo-install-test: set UPSTREAM_DISTRO=almalinux:8 in Makefile

by osmith

Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27401 ) Change subject: centos8-repo-install-test: set UPSTREAM_DISTRO=almalinux:8 in Makefile ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1744f5199b1686ee615173572afee524104eb91f Gerrit-Change-Number: 27401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 12:47:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022