March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ggsn[master]: gtp: Specify retrans queue name & seqnum in log lines

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27416 to look at the new patch set (#3). Change subject: gtp: Specify retrans queue name & seqnum in log lines ...................................................................... gtp: Specify retrans queue name & seqnum in log lines Change-Id: I4f193d7a482ace33afd8526b5f50d2d03467d5fa --- M gtp/gtp.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/16/27416/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4f193d7a482ace33afd8526b5f50d2d03467d5fa Gerrit-Change-Number: 27416 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Specify retrans queue name in log lines

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27416 to look at the new patch set (#2). Change subject: gtp: Specify retrans queue name in log lines ...................................................................... gtp: Specify retrans queue name in log lines Change-Id: I4f193d7a482ace33afd8526b5f50d2d03467d5fa --- M gtp/gtp.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/16/27416/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4f193d7a482ace33afd8526b5f50d2d03467d5fa Gerrit-Change-Number: 27416 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Specify retrans queue name in log lines

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27416 ) Change subject: gtp: Specify retrans queue name in log lines ...................................................................... gtp: Specify retrans queue name in log lines Change-Id: I4f193d7a482ace33afd8526b5f50d2d03467d5fa --- M gtp/gtp.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/16/27416/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index aeb9603..b428413 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -631,7 +631,7 @@ if (queue_newmsg(gsn->queue_req, &qmsg, &addr, gsn->seq_next)) { gsn->err_queuefull++; LOGP(DLGTP, LOGL_ERROR, - "Retransmit queue is full\n"); + "Retransmit resp queue is full\n"); } else { memcpy(&qmsg->p, packet, sizeof(union gtp_packet)); qmsg->l = len; @@ -758,7 +758,7 @@ /* Use new queue structure */ if (queue_newmsg(gsn->queue_resp, &qmsg, peer, seq)) { gsn->err_queuefull++; - LOGP(DLGTP, LOGL_ERROR, "Retransmit queue is full\n"); + LOGP(DLGTP, LOGL_ERROR, "Retransmit resp queue is full\n"); } else { memcpy(&qmsg->p, packet, sizeof(union gtp_packet)); qmsg->l = len; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4f193d7a482ace33afd8526b5f50d2d03467d5fa Gerrit-Change-Number: 27416 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Small log improvements in gtp_create_pdp_ind()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27415 ) Change subject: gtp: Small log improvements in gtp_create_pdp_ind() ...................................................................... gtp: Small log improvements in gtp_create_pdp_ind() Drop unneeded log line, rewrite line to better fit code path. Change-Id: Id254e04d539cc055fee8c16fb66cd897b041557e --- M gtp/gtp.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/15/27415/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index f847e43..aeb9603 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1754,8 +1754,6 @@ in_addr2gsna(&pdp->gsnlc, &gsn->gsnc); in_addr2gsna(&pdp->gsnlu, &gsn->gsnu); - DEBUGP(DLGTP, "gtp_create_pdp_ind: Before gtp_pdp_tidget\n"); - if (!gtp_pdp_getimsi(gsn, &pdp_old, pdp->imsi, pdp->nsapi)) { /* Found old pdp with same tid. Now the voodoo begins! */ /* 09.60 / 29.060 allows create on existing context to "steal" */ @@ -1777,7 +1775,7 @@ * QoS: MS will get originally negotiated QoS. * End user address (EUA). MS will get old EUA anyway. * Protocol configuration option (PCO): Only application can verify */ - DEBUGP(DLGTP, "gtp_create_pdp_ind: Old context found\n"); + DEBUGP(DLGTP, "gtp_create_pdp_ind: Reusing old context\n"); /* Copy remote flow label */ pdp_old->flru = pdp->flru; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id254e04d539cc055fee8c16fb66cd897b041557e Gerrit-Change-Number: 27415 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Log detection of rx duplicate

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27414 ) Change subject: gtp: Log detection of rx duplicate ...................................................................... gtp: Log detection of rx duplicate Change-Id: I8bc9143db6743ad4fae2fe6d6fe0417648e9eec9 --- M gtp/gtp.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/14/27414/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 3051255..f847e43 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -827,11 +827,18 @@ struct sockaddr_in *peer, uint16_t seq) { struct qmsg_t *qmsg; + char buf[INET_ADDRSTRLEN]; if (queue_seqget(gsn->queue_resp, &qmsg, peer, seq)) { return EOF; /* Notfound */ } + + buf[0] = '\0'; + inet_ntop(AF_INET, &peer->sin_addr, buf, sizeof(buf)); + LOGP(DLGTP, LOGL_INFO, + "Rx duplicate seq=%" PRIu16 " from %s, retrans resp\n", seq, buf); + if (fcntl(qmsg->fd, F_SETFL, 0)) { LOGP(DLGTP, LOGL_ERROR, "fnctl()\n"); return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8bc9143db6743ad4fae2fe6d6fe0417648e9eec9 Gerrit-Change-Number: 27414 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Use switch statement in gtp_create_pdp_ind()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27413 ) Change subject: gtp: Use switch statement in gtp_create_pdp_ind() ...................................................................... gtp: Use switch statement in gtp_create_pdp_ind() Double if had to be changed to if-else anyway, so let's simply use a switch statement. Change-Id: I91e8722947e58776742521d89abef8ae7584cb25 --- M gtp/gtp.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/13/27413/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 829d2d2..3051255 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1554,7 +1554,8 @@ GTPCAUSE_INVALID_MESSAGE); } - if (version == 1) { + switch (version) { + case 1: /* Linked NSAPI (conditional) */ /* If included this is the Secondary PDP Context Activation Procedure */ /* In secondary activation IMSI is not included, so the context must be */ @@ -1646,9 +1647,9 @@ if (gtpie_gettlv(ie, GTPIE_TFT, 0, &pdp->tft.l, &pdp->tft.v, sizeof(pdp->tft.v))) { } - } - /* if (version == 1) */ - if (version == 0) { + break; /* version 1 */ + + case 0: if (gtpie_gettv0(ie, GTPIE_QOS_PROFILE0, 0, pdp->qos_req0, sizeof(pdp->qos_req0))) { gsn->missing++; @@ -1671,6 +1672,7 @@ return gtp_create_pdp_resp(gsn, version, pdp, GTPCAUSE_MAN_IE_MISSING); } + break; } /* SGSN address for signalling (mandatory) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I91e8722947e58776742521d89abef8ae7584cb25 Gerrit-Change-Number: 27413 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: VTY: fix ambiguity in BTS specific command definitions

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27412 ) Change subject: VTY: fix ambiguity in BTS specific command definitions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 Gerrit-Change-Number: 27412 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 10:11:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: VTY: fix ambiguity in BTS specific command definitions

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/27412 to look at the new patch set (#2). Change subject: VTY: fix ambiguity in BTS specific command definitions ...................................................................... VTY: fix ambiguity in BTS specific command definitions Most of the BTS specific VTY commands restrict BTS number to '<0-0>', while bts_c0_power_red_cmd has '<0-255>'. This confuses libosmovty: OsmoBTS# bts ? <0-0> BTS number <0-255> BTS Number OsmoBTS# bts 0 ? % Ambiguous command. OsmoBTS# bts 0 c0-power-red 0 % Ambiguous command. Let's stick to '<0-0>', we don't support multiple BTS anyway. Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 --- M src/common/vty.c M tests/osmo-bts.vty 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/27412/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 Gerrit-Change-Number: 27412 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27411 ) Change subject: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss' ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie6da829e47298476267c8df2dcedafad564cbbb4 Gerrit-Change-Number: 27411 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 10:02:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss'

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27411 ) Change subject: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss' ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/27411/comment/b903504b_b667f031 PS1, Line 11: baseband frequency hoppong is in use. > hopping Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie6da829e47298476267c8df2dcedafad564cbbb4 Gerrit-Change-Number: 27411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 10:01:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022