March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: library/L3_Templates: add templates for RR Physical Information

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27498 ) Change subject: library/L3_Templates: add templates for RR Physical Information ...................................................................... library/L3_Templates: add templates for RR Physical Information Change-Id: Icc0f9d0987e77a714e9eaffaedd851a982063582 Related: SYS#5838 --- M library/L3_Templates.ttcn 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/27498/1 diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index e6efb68..7a051e0 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -3466,6 +3466,37 @@ } } +template (value) PDU_ML3_NW_MS +ts_RRM_PhysicalInfo(template (value) OCT1 ta := '00'O) := { + discriminator := '0000'B, /* overwritten */ + tiOrSkip := { + skipIndicator := '0000'B + }, + msgs := { + rrm := { + physicalInformation := { + messageType := '00101101'B, + timingAdvance := ta + } + } + } +} +template PDU_ML3_NW_MS +tr_RRM_PhysicalInfo(template (present) OCT1 ta := ?) := { + discriminator := '0110'B, /* RRM */ + tiOrSkip := { + skipIndicator := '0000'B + }, + msgs := { + rrm := { + physicalInformation := { + messageType := '00101101'B, + timingAdvance := ta + } + } + } +} + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc0f9d0987e77a714e9eaffaedd851a982063582 Gerrit-Change-Number: 27498 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altsteps

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27499 ) Change subject: BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altsteps ...................................................................... BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altsteps In TTCN-3 it's possible to call one altstep from another. This allows us to build complex hierarchies of simple altsteps, where one is built on top of the others. I call this altstep-oriented programming. This change adds the following hierarchy: * as_l1ctl_dl_msg() - triggers on receipt of a L1CTL DATA.ind matching the given RSL chan_nr/link_id and data templates; * as_dl_lapdm_dummy() - triggers on receipt of dummy LAPDm func=UI frames with empty payload (repeats by default); * as_dl_dcch_lapdm_ab() - triggers on receipt of a Downlink DCCH containing a L2 payload that matches the given LAPDm frame; * as_dl_dcch_pdu() - triggers on receipt of a LAPDm AB frame with a L3 payload matching the given template. All of these altsteps (except as_dl_lapdm_dummy()) expect an 'out' parameter, which will hold the matched (and possibly decoded) data. Example: var PDU_ML3_NW_MS pdu; alt { [] as_dl_lapdm_dummy(); /* Ignore empty LAPDm func=UI frames */ [] as_dl_dcch_pdu(pdu, tr_CM_SERV_ACC) { setverdict(pass); } [] as_dl_dcch_pdu(pdu, tr_CM_SERV_REJ) { setverdict(fail); } [] as_dl_dcch_pdu(pdu, ?) { setverdict(inconc, "Unexpected PDU"); } } Change-Id: Ia4d502488cbb6bccc4d2656206ae6649bfa71007 Related: SYS#5838 --- M bts/BTS_Tests.ttcn 1 file changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/27499/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 9447c40..0e86e95 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -873,6 +873,62 @@ } } +/* This altstep triggers on receipt of a L1CTL DATA.ind matching the given + * RSL chan_nr/link_id and data templates. Used as a base for other altsteps. */ +private altstep as_l1ctl_dl_msg(out L1ctlDlMessage msg, + template (present) octetstring tr_data := ?, + template (present) RslChannelNr chan_nr := ?, + template (present) RslLinkId link_id := ?) +runs on ConnHdlr { + [] L1CTL.receive(tr_L1CTL_DATA_IND(chan_nr, link_id, tr_data)) -> value msg; +} + +/* This altstep is built on top of as_l1ctl_dl_msg(), and triggers on receipt + * of dummy LAPDm func=UI frames with empty payload. Repeats by default. */ +private altstep as_dl_lapdm_dummy(template (present) RslChannelNr chan_nr := ?, + template (present) RslLinkId link_id := ?, + template (present) LapdmSapi sapi := ?, + boolean do_repeat := true) +runs on ConnHdlr { + template (present) LapdmFrame tr_frame := tr_LAPDm_UI(sapi, true, ''O); + var L1ctlDlMessage dl_msg; + + [] as_l1ctl_dl_msg(dl_msg, decmatch tr_frame, chan_nr, link_id) { + if (do_repeat) { + repeat; + } + } +} + +/* This altstep triggers on receipt of a Downlink DCCH containing a L2 payload + * that matches the given LAPDm frame. The L2 is treated as LapdmFrameAB. */ +private altstep as_dl_dcch_lapdm_ab(out LapdmFrameAB frame, + template (present) LapdmFrameAB tr_frame := ?, + template (present) RslLinkId link_id := ?) +runs on ConnHdlr { + var L1ctlDlMessage dl_msg; + + [] as_l1ctl_dl_msg(dl_msg, decmatch tr_frame, g_chan_nr, link_id) { + frame := dec_LapdmFrameAB(dl_msg.payload.data_ind.payload); + } +} + +/* This altstep is built on top of as_dl_dcch_lapdm_ab(), and triggers on receipt + * of a LAPDm AB frame with a L3 payload matching the given template. The L3 + * payload is treated as PDU_ML3_NW_MS. */ +private altstep as_dl_dcch_pdu(out PDU_ML3_NW_MS pdu, + template (present) PDU_ML3_NW_MS tr_pdu := ?, + template (present) GsmSapi sapi := 0) +runs on ConnHdlr { + template (present) LapdmFrame tr_frame := tr_LAPDm_UI(sapi, true, decmatch tr_pdu); + template (present) RslLinkId link_id := tr_RslLinkID_DCCH(sapi); + var LapdmFrameAB lapdm_frame; + + [] as_dl_dcch_lapdm_ab(lapdm_frame, tr_frame.ab, link_id) { + pdu := dec_PDU_ML3_NW_MS(lapdm_frame.payload); + } +} + /*********************************************************************** * Channel Activation / Deactivation ***********************************************************************/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4d502488cbb6bccc4d2656206ae6649bfa71007 Gerrit-Change-Number: 27499 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/LAPDm_Types: add 'padding' field to the LapdmFrameAB record

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27497 ) Change subject: library/LAPDm_Types: add 'padding' field to the LapdmFrameAB record ...................................................................... library/LAPDm_Types: add 'padding' field to the LapdmFrameAB record TTCN-3 offers a very convinient way of matching an octetstring against a record template (decoding target) on the fly, so that there is no need to attempt decoding it manually beforehand. This can be done by using the 'decmatch' keyword (see B.1.2.9). Unfortunately, decmatch fails if an octetstring is longer than the encoded variant of the decoding target (e.g. has padding). Let's work this around by adding a 'padding' field, so during decoding all remaining octets will be stored in it. Change-Id: I0151adf7790127617f7cb57c9a9ec6c28721e95a Related: SYS#5838 --- M bts/BTS_Tests.ttcn M library/LAPDm_Types.ttcn 2 files changed, 36 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/27497/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 27b004a..9447c40 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -1914,7 +1914,8 @@ len := 0, /* overwritten */ m := false, el := 1, - payload := enc_GsmRrL3Message(valueof(l3)) + payload := enc_GsmRrL3Message(valueof(l3)), + padding := ''O } /* handle incoming downlink SACCH and respond with uplink SACCH (meas res) */ diff --git a/library/LAPDm_Types.ttcn b/library/LAPDm_Types.ttcn index 5ef953d..baa2b7e 100644 --- a/library/LAPDm_Types.ttcn +++ b/library/LAPDm_Types.ttcn @@ -180,7 +180,8 @@ uint6_t len, boolean m, uint1_t el, - octetstring payload /* zero-length in Frame A */ + octetstring payload, /* zero-length in Frame A */ + octetstring padding } with { variant (len) "LENGTHTO(payload)" variant "FIELDORDER(msb)" }; @@ -230,7 +231,8 @@ len := 0, /* overwritten in encoder */ m := false, el := 1, - payload := l3 + payload := l3, + padding := ''O } } template LapdmFrame tr_LAPDm_SABM(template LapdmSapi sapi, template boolean c_r, @@ -241,7 +243,8 @@ len := ?, m := false, el := 1, - payload := l3 + payload := l3, + padding := ? } } @@ -253,7 +256,8 @@ len := 0, /* overwritten in encoder */ m := false, el := 1, - payload := l3 + payload := l3, + padding := ''O } } template LapdmFrame tr_LAPDm_UA(template LapdmSapi sapi, template boolean c_r, @@ -264,7 +268,8 @@ len := ?, m := false, el := 1, - payload := l3 + payload := l3, + padding := ? } } @@ -275,7 +280,8 @@ len := 0, /* overwritten in encoder */ m := false, el := 1, - payload := ''O + payload := ''O, + padding := ''O } } template LapdmFrame tr_LAPDm_DM(template LapdmSapi sapi, template boolean c_r, @@ -286,7 +292,8 @@ len := ?, m := false, el := 1, - payload := ''O + payload := ''O, + padding := ? } } @@ -297,7 +304,8 @@ len := 0, m := false, el := 1, - payload := ''O + payload := ''O, + padding := ''O } } template LapdmFrame tr_LAPDm_DISC(template LapdmSapi sapi, template boolean c_r, @@ -308,7 +316,8 @@ len := ?, m := false, el := 1, - payload := ''O + payload := ''O, + padding := ? } } @@ -319,7 +328,8 @@ len := 0, m := false, el := 1, - payload := l3 + payload := l3, + padding := ''O } } template LapdmFrame tr_LAPDm_UI(template LapdmSapi sapi, template boolean c_r, @@ -330,7 +340,8 @@ len := ?, m := false, el := 1, - payload := l3 + payload := l3, + padding := ? } } @@ -360,7 +371,8 @@ len := ?, m := m, el := 1, - payload := l3 + payload := l3, + padding := ? } } template (value) LapdmFrame ts_LAPDm_I(LapdmSapi sapi, boolean c_r, boolean p, uint3_t nr, @@ -371,7 +383,8 @@ len := 0, m := m, el := 1, - payload := l3 + payload := l3, + padding := ''O } } @@ -383,7 +396,8 @@ len := 0, m := false, el := 1, - payload := ''O + payload := ''O, + padding := ? } } template (value) LapdmFrame ts_LAPDm_RR(LapdmSapi sapi, boolean c_r, @@ -394,7 +408,8 @@ len := 0, m := false, el := 1, - payload := ''O + payload := ''O, + padding := ''O } } @@ -406,7 +421,8 @@ len := 0, m := false, el := 1, - payload := ''O + payload := ''O, + padding := ? } } template (value) LapdmFrame ts_LAPDm_REJ(LapdmSapi sapi, boolean c_r, @@ -417,7 +433,8 @@ len := 0, m := false, el := 1, - payload := ''O + payload := ''O, + padding := ''O } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0151adf7790127617f7cb57c9a9ec6c28721e95a Gerrit-Change-Number: 27497 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: drop LOG_SCCP macro

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27468 ) Change subject: bsc_nat_fsm: drop LOG_SCCP macro ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I49187d4e3d804c4786ee52eaebdd911e6c6cfa6c Gerrit-Change-Number: 27468 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Mar 2022 15:13:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc-nat[master]: treewide: tweak includes

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 ) Change subject: treewide: tweak includes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1a7b95ccb0c87fd53645c72f0c02449e8403043b Gerrit-Change-Number: 27465 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Mar 2022 15:12:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc-nat[master]: treewide: tweak includes

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 ) Change subject: treewide: tweak includes ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Fine with me now, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1a7b95ccb0c87fd53645c72f0c02449e8403043b Gerrit-Change-Number: 27465 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Mar 2022 15:12:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: remove completed TODO points

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27496 ) Change subject: BTS_Tests: remove completed TODO points ...................................................................... BTS_Tests: remove completed TODO points * TC_ho_rach - handover RACH detection, * TC_rsl_rf_resource_ind - RF RESource INDication. Change-Id: I12b6331b445650437cc66130765369bbcd01ba5f --- M bts/BTS_Tests.ttcn 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/27496/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 3c5dbf0..0b76cea 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8295,10 +8295,8 @@ ** multirate * check DEACTIVATE SACCH ** unsupported algorithm -* handover detection * BS Power Control * Physical Context -* RF resource ind * error handling ** IE duplicated? * PCU interface -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12b6331b445650437cc66130765369bbcd01ba5f Gerrit-Change-Number: 27496 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to pass

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27495 ) Change subject: bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to pass ...................................................................... bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to pass Change-Id: I9ceb0a71549d293ff0f270c414f667a0bae4df62 --- M bts/expected-results.xml 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/27495/1 diff --git a/bts/expected-results.xml b/bts/expected-results.xml index b81358d..2dffe06 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -10,12 +10,7 @@ <testcase classname='BTS_Tests' name='TC_sacch_multi' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_sacch_multi_chg' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_sacch_chan_act' time='MASKED'/> - <testcase classname='BTS_Tests' name='TC_sacch_chan_act_ho_async' time='MASKED'> - <failure type='fail-verdict'>"BTS_Tests.ttcn:MASKED : Unexpected RSL message received" - BTS_Tests.ttcn:MASKED BTS_Tests control part - BTS_Tests.ttcn:MASKED TC_sacch_chan_act_ho_async testcase - </failure> - </testcase> + <testcase classname='BTS_Tests' name='TC_sacch_chan_act_ho_async' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_sacch_chan_act_ho_sync' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_content' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_count' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ceb0a71549d293ff0f270c414f667a0bae4df62 Gerrit-Change-Number: 27495 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix some compilation warnings (template restrictions)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27494 ) Change subject: BTS_Tests: fix some compilation warnings (template restrictions) ...................................................................... BTS_Tests: fix some compilation warnings (template restrictions) Change-Id: I53286a7b4b78a3e816d94d880ae290771cdd7ee8 --- M bts/BTS_Tests.ttcn 1 file changed, 7 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/27494/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 27b004a..8ea908b 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6103,7 +6103,6 @@ /* Verify periodic interference reports on PDCH */ testcase TC_pcu_interf_ind() runs on test_CT { var template PCUIF_Message tr_interf_ind; - var template PCUIF_interf ts_interf; var integer interf_ind_num := 0; var boolean first := true; var PCUIF_send_data sd; @@ -6122,12 +6121,11 @@ f_l1_tune(L1CTL); /* Expect -120 .. -90 dBm on TS7 of BTS0/TRX0 */ - ts_interf := { 0, 0, 0, 0, 0, 0, 0, (90..120) }; tr_interf_ind := tr_PCUIF_INTERF_IND( bts_nr := 0, trx_nr := 0, fn := ?, - interf := ts_interf + interf := { 0, 0, 0, 0, 0, 0, 0, (90..120) } ); T.start(0.480 * 1.5); @@ -7220,7 +7218,7 @@ } /* Verify RF RESource INDication messages (periodically sent over the RSL) */ -private function f_TC_rsl_rf_resource_ind(template RSL_ResourceInfo info) +private function f_TC_rsl_rf_resource_ind(template (present) RSL_ResourceInfo info) runs on test_CT { const IpaStreamId sid := IPAC_PROTO_RSL_TRX0; var ASP_RSL_Unitdata ud; @@ -8093,7 +8091,7 @@ f_init(); /* Verify lower and upper RxQual thresholds */ - var template TopTestCase top := { + var template (value) TopTestCase top := { bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ top_cap := ts_RSL_IE_OSMO_TopAcchCap(4), /* 4dB */ steps := { @@ -8140,7 +8138,7 @@ f_init(); /* Verify handling of FULL and SUB values */ - var template TopTestCase top := { + var template (value) TopTestCase top := { bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ top_cap := ts_RSL_IE_OSMO_TopAcchCap(4), /* 4dB */ steps := { @@ -8181,7 +8179,7 @@ f_init(); /* Overpower is always on, SACCH disabled */ - var template TopTestCase top := { + var template (value) TopTestCase top := { bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ rxqual := 0, /* always on */ @@ -8213,7 +8211,7 @@ f_init(); /* Overpower is always on, FACCH disabled */ - var template TopTestCase top := { + var template (value) TopTestCase top := { bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ rxqual := 0, /* always on */ @@ -8245,7 +8243,7 @@ f_init(); /* Overpower higher than current power reduction level (2dB) */ - var template TopTestCase top := { + var template (value) TopTestCase top := { bs_power := ts_RSL_IE_BS_Power(1), /* 1 x 2dB = 2dB */ top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ rxqual := 0 /* always on */), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53286a7b4b78a3e816d94d880ae290771cdd7ee8 Gerrit-Change-Number: 27494 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/L1CTL_Types: fix t_RslChanNr_RACH used in send templates

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27493 ) Change subject: library/L1CTL_Types: fix t_RslChanNr_RACH used in send templates ...................................................................... library/L1CTL_Types: fix t_RslChanNr_RACH used in send templates Change-Id: Id7570df09bea04c60475d91519c6aac63bf6f749 --- M library/L1CTL_Types.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/27493/1 diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index 220a2cd..4bde793 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -588,7 +588,7 @@ header := ts_L1ctlHeader(L1CTL_EXT_RACH_REQ), ul_info := { /* FIXME: both RSL chan_nr and link_id should be configurable */ - chan_nr := t_RslChanNr_RACH(0), + chan_nr := ts_RslChanNr_RACH(0), link_id := ts_RslLinkID_DCCH(0), padding := '0000'O }, @@ -609,7 +609,7 @@ template (value) uint8_t tx_power) := { header := ts_L1ctlHeader(L1CTL_PARAM_REQ), ul_info := { - chan_nr := t_RslChanNr_RACH(0), + chan_nr := ts_RslChanNr_RACH(0), link_id := ts_RslLinkID_DCCH(0), padding := '0000'O }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7570df09bea04c60475d91519c6aac63bf6f749 Gerrit-Change-Number: 27493 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022