fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27502 )
Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ()
......................................................................
rsl: fix wrong IE being checked in rsl_rx_chan_activ()
According to 3GPP TS 48.058, section 4.1.4, BTS shall start transmission
on SACCH if both MS Power and *Timing Advance* IEs are present. There
can be no Access Delay IE in the RSL CHANnel ACTIVation message.
Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec
Fixes: I170b63c9856230d5f1a10654a9d950ada8e730d7
Related: SYS#5838
---
M src/common/rsl.c
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/02/27502/1
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 9b73869..71b2997 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1902,21 +1902,21 @@
/* Indicate which SAPIs should be enabled before the first RACH is received, for handover. See 3GPP TS 48.058
* 4.1.3 and 4.1.4.
*
- * | | Access || transmit | activate | This implementation
- * | MS Power | Delay || on main channel | dl SACCH | activates DL SACCH
+ * | | Timing || transmit | activate | This implementation
+ * | MS Power | Advance || on main channel | dl SACCH | activates DL SACCH
* -----------------------------------------------------------------------------------------
- * async ho no * --> yes no no
- * async ho yes * --> yes may be started no
- * async ho yes yes --> yes may be started yes
- * sync ho no no --> yes no no
- * sync ho yes no --> yes may be started no
- * sync ho yes yes --> yes shall be started yes
+ * async ho no * --> yes no no
+ * async ho yes * --> yes may be started no
+ * async ho yes yes --> yes may be started yes
+ * sync ho no no --> yes no no
+ * sync ho yes no --> yes may be started no
+ * sync ho yes yes --> yes shall be started yes
*/
switch (type) {
case RSL_ACT_INTER_ASYNC:
case RSL_ACT_INTER_SYNC:
lchan->want_dl_sacch_active = (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)
- && TLVP_PRES_LEN(&tp, RSL_IE_ACCESS_DELAY, 1));
+ && TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1));
break;
default:
lchan->want_dl_sacch_active = true;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27502
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: 2021q4
Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec
Gerrit-Change-Number: 27502
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27501 )
Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ()
......................................................................
rsl: fix wrong IE being checked in rsl_rx_chan_activ()
According to 3GPP TS 48.058, section 4.1.4, BTS shall start transmission
on SACCH if both MS Power and *Timing Advance* IEs are present. There
can be no Access Delay IE in the RSL CHANnel ACTIVation message.
Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec
Fixes: I170b63c9856230d5f1a10654a9d950ada8e730d7
Related: SYS#5838
---
M src/common/rsl.c
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/01/27501/1
diff --git a/src/common/rsl.c b/src/common/rsl.c
index cd3fda5..a62a01c 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1645,21 +1645,21 @@
/* Indicate which SAPIs should be enabled before the first RACH is received, for handover. See 3GPP TS 48.058
* 4.1.3 and 4.1.4.
*
- * | | Access || transmit | activate | This implementation
- * | MS Power | Delay || on main channel | dl SACCH | activates DL SACCH
+ * | | Timing || transmit | activate | This implementation
+ * | MS Power | Advance || on main channel | dl SACCH | activates DL SACCH
* -----------------------------------------------------------------------------------------
- * async ho no * --> yes no no
- * async ho yes * --> yes may be started no
- * async ho yes yes --> yes may be started yes
- * sync ho no no --> yes no no
- * sync ho yes no --> yes may be started no
- * sync ho yes yes --> yes shall be started yes
+ * async ho no * --> yes no no
+ * async ho yes * --> yes may be started no
+ * async ho yes yes --> yes may be started yes
+ * sync ho no no --> yes no no
+ * sync ho yes no --> yes may be started no
+ * sync ho yes yes --> yes shall be started yes
*/
switch (type) {
case RSL_ACT_INTER_ASYNC:
case RSL_ACT_INTER_SYNC:
lchan->want_dl_sacch_active = (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)
- && TLVP_PRES_LEN(&tp, RSL_IE_ACCESS_DELAY, 1));
+ && TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1));
break;
default:
lchan->want_dl_sacch_active = true;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27501
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: 2021q1
Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec
Gerrit-Change-Number: 27501
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27487 )
Change subject: BTS_Tests: remove misleading comments in f_sacch_{present,missing}()
......................................................................
BTS_Tests: remove misleading comments in f_sacch_{present,missing}()
Change-Id: Ib6264da51d17d8d5d932109afad79d6a9916911b
Related: SYS#5838, OS#4008, OS#4009
---
M bts/BTS_Tests.ttcn
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 27b004a..b311da1 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1076,7 +1076,6 @@
/* verify that given SACCH payload is present */
private function f_sacch_present(template octetstring l3_exp) runs on ConnHdlr {
var L1ctlDlMessage dl;
- /* check that the specified SI5 value is actually sent */
timer T_sacch := 3.0;
L1CTL.clear;
T_sacch.start;
@@ -1099,7 +1098,6 @@
/* verify that given SACCH payload is not present */
private function f_sacch_missing(template octetstring l3_exp) runs on ConnHdlr {
var L1ctlDlMessage dl;
- /* check that the specified SI5 value is actually sent */
timer T_sacch := 3.0;
L1CTL.clear;
T_sacch.start;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib6264da51d17d8d5d932109afad79d6a9916911b
Gerrit-Change-Number: 27487
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged