March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: use setverdict() in f_sacch_{present,missing}()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27488 ) Change subject: BTS_Tests: cosmetic: use setverdict() in f_sacch_{present,missing}() ...................................................................... BTS_Tests: cosmetic: use setverdict() in f_sacch_{present,missing}() This eliminates the need for using log2str() and improves readability. Change-Id: Iaf9b03fb81ec4fa2ca4f0a0b2f0b50491c6a9d80 Related: SYS#5838, OS#4008, OS#4009 --- M bts/BTS_Tests.ttcn 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index b311da1..5741458 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -1090,7 +1090,8 @@ } [] L1CTL.receive { repeat; } [] T_sacch.timeout { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Timeout waiting for SACCH ", l3_exp)); + setverdict(fail, "Timeout waiting for SACCH ", l3_exp); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } } } @@ -1105,7 +1106,8 @@ [] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, tr_RslLinkID_SACCH(0))) -> value dl { var octetstring l3 := substr(dl.payload.data_ind.payload, 4, 19); if (match(l3, l3_exp)) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Received unexpected SACCH ", dl)); + setverdict(fail, "Received unexpected SACCH ", dl); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } else { repeat; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf9b03fb81ec4fa2ca4f0a0b2f0b50491c6a9d80 Gerrit-Change-Number: 27488 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async}

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27489 ) Change subject: BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e97944e56b7860f2d912cd8d3c978a0f1e08645 Gerrit-Change-Number: 27489 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Mar 2022 13:18:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: use setverdict() in f_sacch_{present,missing}()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27488 ) Change subject: BTS_Tests: cosmetic: use setverdict() in f_sacch_{present,missing}() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf9b03fb81ec4fa2ca4f0a0b2f0b50491c6a9d80 Gerrit-Change-Number: 27488 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Mar 2022 13:18:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: remove misleading comments in f_sacch_{present,missing}()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27487 ) Change subject: BTS_Tests: remove misleading comments in f_sacch_{present,missing}() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib6264da51d17d8d5d932109afad79d6a9916911b Gerrit-Change-Number: 27487 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Mar 2022 13:17:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to pass

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27495 ) Change subject: bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to pass ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ceb0a71549d293ff0f270c414f667a0bae4df62 Gerrit-Change-Number: 27495 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Mar 2022 13:17:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add new test case TC_ho_physical_info

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500 ) Change subject: BTS_Tests: add new test case TC_ho_physical_info ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9469027ce88fb2750f1eceef2d8a56d4b8ee4d03 Gerrit-Change-Number: 27500 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Mar 2022 13:17:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altsteps

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27499 ) Change subject: BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altsteps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4d502488cbb6bccc4d2656206ae6649bfa71007 Gerrit-Change-Number: 27499 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Mar 2022 13:16:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/L3_Templates: add templates for RR Physical Information

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27498 ) Change subject: library/L3_Templates: add templates for RR Physical Information ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc0f9d0987e77a714e9eaffaedd851a982063582 Gerrit-Change-Number: 27498 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Mar 2022 13:15:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/LAPDm_Types: add 'padding' field to the LapdmFrameAB record

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27497 ) Change subject: library/LAPDm_Types: add 'padding' field to the LapdmFrameAB record ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0151adf7790127617f7cb57c9a9ec6c28721e95a Gerrit-Change-Number: 27497 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Mar 2022 13:15:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add new test case TC_ho_physical_info

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500 ) Change subject: BTS_Tests: add new test case TC_ho_physical_info ...................................................................... BTS_Tests: add new test case TC_ho_physical_info The test case scenario can be summarized as follows: 1. Activate a logical channel for async handover. 1.a. Tune the MS side to that channel. 1.b. Make sure that no Downlink DCCH is received. 2. Send a handover Access Burst to the BTS. 2.a. Expect RR Physical Information to be received Ny1 times. 2.b. Expect no other data to be received on Downlink DCCH. Currently the new test case fails for several reasons: * osmo-bts-trx starts transmitting on DCCH before the handover Access Burst is received, this is wong; * trxcon immediately starts sending dummy frames on Uplink DCCH, causing osmo-bts to stop sendig RR Physical Info. Change-Id: I9469027ce88fb2750f1eceef2d8a56d4b8ee4d03 Related: SYS#5838 --- M bts/BTS_Tests.ttcn M bts/expected-results.xml 2 files changed, 98 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/27500/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 0e86e95..fe7b53f 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -135,6 +135,10 @@ * X5: -109 >= -115 dBm (no) * So all channels should be in band 4. */ uint3_t mp_interf_band := 4; + /* T3105 timer (see 3GPP TS 44.018, section 11.1.2) */ + integer mp_ho_t3105_ms := 100; + /* Ny1 counter (see 3GPP TS 44.018, section 11.1.3) */ + integer mp_ho_ny1 := 10; } type record of RslChannelNr ChannelNrs; @@ -1946,6 +1950,93 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } +/* Test sending of the RR Physical Information message on DCCH */ +private function f_TC_ho_physical_info(charstring id) runs on ConnHdlr { + var PDU_ML3_NW_MS dcch_pdu; + var integer count := 0; + var L1ctlDlMessage dl; + timer T; + + f_l1_tune(L1CTL); + RSL.clear; + + /* Generate a random Handover Reference */ + var integer ho_ref := oct2int(f_rnd_octstring(1)); + + /* Handover Reference IE (see 3GPP TS 48.058, 9.3.9) */ + var RSL_IE ho_ref_ie := valueof(t_RSL_IE(RSL_IE_HANDO_REF, + RSL_IE_Body:{ handover_ref := ho_ref })); + + /* Activate a channel on the BTS side (no encryption) */ + f_rsl_chan_act(g_pars.chan_mode, more_ies := { ho_ref_ie }, + act_type := t_RSL_IE_ActType_HO_SYNC); + + /* Switch the MS side (e.g. trxcon) to a dedicated channel without + * waiting for Immediate Assignment and sending of an Access Burst. */ + f_l1ctl_est_dchan(L1CTL, g_pars); /* FIXME: disable Uplink Tx */ + + /* Expect nothing to be transmitted on Downlink DCCH. Nothing in this + * context means any L2 frames, not only the RR Physical Information. */ + T.start(2.0); + L1CTL.clear; + alt { + [] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, tr_RslLinkID_DCCH(?))) -> value dl { + setverdict(fail, "Rx unexpected Downlink DCCH (before handover RACH): ", dl); + T.stop; + } + [] L1CTL.receive { repeat; } + [] T.timeout { setverdict(pass); } + } + + /* Send handover Access Burst */ + log("Sending handover Access Burst"); + f_L1CTL_RACH(L1CTL, ho_ref, chan_nr := g_pars.chan_nr); + + /* Expect RR Physical Information being sent on Downlink DCCH Ny1 times */ + T.start(int2float(mp_ho_t3105_ms * mp_ho_ny1) / 1000.0 + 1.0); + L1CTL.clear; + alt { + [] as_dl_lapdm_dummy(); /* Ignore empty LAPDm func=UI frames */ + [] as_dl_dcch_pdu(dcch_pdu, tr_RRM_PhysicalInfo) { + log("Rx RR Physical Information: ", dcch_pdu); + /* Wait until the count reaches Ny1 */ + count := count + 1; + if (count < mp_ho_ny1) + { repeat; } + setverdict(pass); + } + [] as_dl_dcch_pdu(dcch_pdu, ?) { + setverdict(fail, "Rx unexpected DCCH PDU: ", dcch_pdu); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + [] L1CTL.receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for RR Physical Information"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } + + /* Release the channel */ + f_rsl_chan_deact(); + f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr); +} +testcase TC_ho_physical_info() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + for (var integer i := 0; i < sizeof(g_AllChanTypes); i := i + 1) { + pars := valueof(t_Pars(g_AllChanTypes[i], ts_RSL_ChanMode_SIGN)); + log(testcasename(), ": Starting for ", g_AllChanTypes[i]); + vc_conn := f_start_handler(refers(f_TC_ho_physical_info), pars); + vc_conn.done; + } + + /* TODO: do the above in parallel, rather than sequentially? */ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + /*********************************************************************** * Measurement Processing / Reporting ***********************************************************************/ @@ -8376,6 +8467,7 @@ execute( TC_rach_count() ); execute( TC_rach_max_ta() ); execute( TC_ho_rach() ); + execute( TC_ho_physical_info() ); execute( TC_rach_load_idle_thresh0() ); execute( TC_rach_load_idle_below_thresh() ); execute( TC_rach_load_count() ); diff --git a/bts/expected-results.xml b/bts/expected-results.xml index b81358d..84ffedc 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -21,6 +21,12 @@ <testcase classname='BTS_Tests' name='TC_rach_count' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_max_ta' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_ho_rach' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_ho_physical_info' time='MASKED'> + <failure type='fail-verdict'>"BTS_Tests.ttcn:MASKED : Rx unexpected Downlink DCCH (before handover RACH): MASKED" + BTS_Tests.ttcn:MASKED BTS_Tests control part + BTS_Tests.ttcn:MASKED TC_ho_physical_info testcase + </failure> + </testcase> <testcase classname='BTS_Tests' name='TC_rach_load_idle_thresh0' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_load_idle_below_thresh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_load_count' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9469027ce88fb2750f1eceef2d8a56d4b8ee4d03 Gerrit-Change-Number: 27500 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022