February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in FailureList

by dexter

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 ) Change subject: ranap_rab_ass: add function to check if RAB is in FailureList ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4319f7caa45ea758ccd792cc8570521df075cf45 Gerrit-Change-Number: 27139 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 14:46:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in FailureList

by dexter

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 ) Change subject: ranap_rab_ass: add function to check if RAB is in FailureList ...................................................................... Patch Set 3: (1 comment) File tests/ranap_rab_ass/ranap_rab_ass_test.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139/comment/7e93a6da_a5afdc2d PS2, Line 285: rab_failed_at_hnb = > Maybe add another case where you pass another ID to test the "not found" path. Makes sense. I have added it real quick. Will merge this now. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4319f7caa45ea758ccd792cc8570521df075cf45 Gerrit-Change-Number: 27139 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 14:46:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in FailureList

by dexter

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 to look at the new patch set (#3). Change subject: ranap_rab_ass: add function to check if RAB is in FailureList ...................................................................... ranap_rab_ass: add function to check if RAB is in FailureList A RANAP RAB-AssignmentResponse may contain a FailedList. In order to detect that a RAB Assignment failed at the HNB we need to be able to check if the RAB we are dealing with is contained an such a FailedList. Change-Id: I4319f7caa45ea758ccd792cc8570521df075cf45 Related: OS#5152 --- M include/osmocom/hnbgw/ranap_rab_ass.h M src/osmo-hnbgw/ranap_rab_ass.c M tests/ranap_rab_ass/ranap_rab_ass_test.c M tests/ranap_rab_ass/ranap_rab_ass_test.ok 4 files changed, 102 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/39/27139/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4319f7caa45ea758ccd792cc8570521df075cf45 Gerrit-Change-Number: 27139 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in FailureList

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 ) Change subject: ranap_rab_ass: add function to check if RAB is in FailureList ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4319f7caa45ea758ccd792cc8570521df075cf45 Gerrit-Change-Number: 27139 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 14:13:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-gbproxy[master]: docs: usermanual: add new chapter gb-ns2-maintenance

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27306 ) Change subject: docs: usermanual: add new chapter gb-ns2-maintenance ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Depends-On: I5571001a127c933397a4bc26e85410288d50fc2f (osmo-gsm-manuals.git) Otherwise +1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I951cc10d86de4f16d2226b34eda55202373c2524 Gerrit-Change-Number: 27306 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 22 Feb 2022 18:02:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: correct ip.access static configuration

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27303 ) Change subject: common: gb-ns2: correct ip.access static configuration ...................................................................... common: gb-ns2: correct ip.access static configuration Change-Id: I652f7cda1e79e452af7740c1cae192a9f2b1acab --- M common/chapters/gb-ns2-configuration.adoc 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/common/chapters/gb-ns2-configuration.adoc b/common/chapters/gb-ns2-configuration.adoc index a756b0d..4397cf4 100644 --- a/common/chapters/gb-ns2-configuration.adoc +++ b/common/chapters/gb-ns2-configuration.adoc @@ -99,16 +99,7 @@ ===== Gb over IP "ip.access style" static configuration -.Example: Gb over IP/UDP "ip.access style" dynamic configuration (SGSN) ----- -ns - bind udp ran1 <1> - listen 10.100.0.1 23000 <2> ----- -<1> create a IP/UDP bind with name ran1 -<2> bind to 10.100.0.1:23000 - -.Example: Gb over IP/UDP "ip.access style" dynamic configuration (GbProxy as BSS) +.Example: Gb over IP/UDP "ip.access style" static configuration (BSS & SGSN) ---- ns bind udp ran1 <1> -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I652f7cda1e79e452af7740c1cae192a9f2b1acab Gerrit-Change-Number: 27303 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: update ip-sns configuration example

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27302 ) Change subject: common: gb-ns2: update ip-sns configuration example ...................................................................... common: gb-ns2: update ip-sns configuration example Change-Id: I0b20634d683ad8f93c1c8af35eacbb953c1db46b --- M common/chapters/gb-ns2-configuration.adoc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/common/chapters/gb-ns2-configuration.adoc b/common/chapters/gb-ns2-configuration.adoc index b8f2b03..a756b0d 100644 --- a/common/chapters/gb-ns2-configuration.adoc +++ b/common/chapters/gb-ns2-configuration.adoc @@ -161,8 +161,8 @@ nse 1001 <3> ip-sns-bind ran1 <4> ip-sns-bind ran2 - ip-sns-endpoint 10.100.1.1 <5> - ip-sns-endpoint 10.100.1.2 + ip-sns-remote 10.100.1.1 23000 <5> + ip-sns-remote 10.100.1.2 23000 ---- <1> create a IP/UDP bind with name ran1 <2> bind to 10.100.0.1:23000 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I0b20634d683ad8f93c1c8af35eacbb953c1db46b Gerrit-Change-Number: 27302 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: remove empty VTY chapter

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27301 ) Change subject: common: gb-ns2: remove empty VTY chapter ...................................................................... common: gb-ns2: remove empty VTY chapter Change-Id: Iee28046fbb0a5a034c2a33c495a3ca6f8ef953c4 --- M common/chapters/gb-ns2.adoc 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/common/chapters/gb-ns2.adoc b/common/chapters/gb-ns2.adoc index 38f7c4f..f7ff2ac 100644 --- a/common/chapters/gb-ns2.adoc +++ b/common/chapters/gb-ns2.adoc @@ -179,8 +179,3 @@ A NS-VC is always bound to a NSE and the bind (NS-VL). The NSVC can be either persistent or dynamic. - -=== VTY - -This section describes the VTY commands to inspect or interact with the NS. - -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iee28046fbb0a5a034c2a33c495a3ca6f8ef953c4 Gerrit-Change-Number: 27301 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by lynxis lazus

Attention is currently required from: pespin, daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 2: (1 comment) File common/chapters/gb-ns2-maintenance.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687/comment/569237a7_0dac… PS2, Line 80: For FR, IPA: The NSE is ALIVE if there is at least one NSVC in state UNBLOCKED. > Is it me or this is duplicated from line 13 but this time >1 instead of > 0? I'm confused now. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Feb 2022 18:02:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-gbproxy[master]: docs: usermanual: reorder gb/ns2 chapter to keep all ns2 part together

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27305 ) Change subject: docs: usermanual: reorder gb/ns2 chapter to keep all ns2 part together ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I3bc1c4de090a073cf1b1a6fe852f17857754beaf Gerrit-Change-Number: 27305 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 22 Feb 2022 18:01:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022