February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: inter-BSC HO in: add Speech Codec (Chosen) IE to HO Req Ack

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27309 ) Change subject: inter-BSC HO in: add Speech Codec (Chosen) IE to HO Req Ack ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1d0b395c97145b5aa1af4ef67aec9338d2f8f43b Gerrit-Change-Number: 27309 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 16:23:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: inter-BSC HO in: add speech IEs only on speech mode lchans

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27308 ) Change subject: inter-BSC HO in: add speech IEs only on speech mode lchans ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I830654f419e6f0a196dc6d3e58422e00b324af9e Gerrit-Change-Number: 27308 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 16:23:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: New stats for lchan life duration.

by iedemam

Attention is currently required from: neels, laforge. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: New stats for lchan life duration. ...................................................................... Patch Set 11: (2 comments) Patchset: PS11: Hi all, Here is my first stab at converting to use osmo_time_cc. It has only been tested minimally as I wanted some feedback on the approach first. The previous timestamp+diff method is still used to see per lchan activation ages in the VTY and the new time_cc timekeeper to track and report cumulative milliseconds during channel use. Maybe a new API for osmo_time_cc to pull the elapsed time value could help? Then I would no longer need to use two sources of truth. There is also a SEGV in here pretty regularly with the following backtrace. Probably a misuse on my part of osmo_time_cc. Just reporting for completeness. ``` Program received signal SIGSEGV, Segmentation fault. rb_insert_color (node=node@entry=0x76bf60, root=0x7ffff7fe2828) at rbtree.c:77 77 rbtree.c: No such file or directory. (gdb) (gdb) bt #0 rb_insert_color (node=node@entry=0x76bf60, root=0x7ffff7fe2828) at rbtree.c:77 #1 0x00007ffff72db95f in __add_timer (timer=0x76bf60) at timer.c:62 #2 osmo_timer_add (timer=timer@entry=0x76bf60) at timer.c:85 #3 0x00007ffff72db9b8 in osmo_timer_schedule (timer=0x76bf60, seconds=0, microseconds=0) at timer.c:107 #4 0x00007ffff72dbcf6 in osmo_timers_update () at timer.c:269 #5 0x00007ffff72dc7b5 in _osmo_select_main (polling=0) at select.c:394 #6 0x00007ffff72dc846 in osmo_select_main_ctx (polling=<optimized out>) at select.c:455 #7 0x000000000040dd55 in ?? () #8 0x00007ffff62cd391 in __libc_start_main () from /lib64/libc.so.6 #9 0x000000000040e7ca in ?? () ``` File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/0c6222f9_b8425161 PS8, Line 1514: "Cummulative number of active milliseconds on TCH chans", > sounds great Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 11 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Feb 2022 16:06:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: iedemam <michael(a)kapsulate.com> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO in: expect codecs in HO Request ACK

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 ) Change subject: bsc: inter-BSC HO in: expect codecs in HO Request ACK ...................................................................... bsc: inter-BSC HO in: expect codecs in HO Request ACK Expect IEs Speech Codec (Chosen) and Codec List (BSS Supported), they are missing in current osmo-bsc. Related: SYS#5839 Depends: I3c0576505a3ceb3cd5cc31dc69c5bc4a86a4ea08 (osmo-bsc) Change-Id: Ib2b4e27be241e2a92c0c3bffdf906bf22c09352b --- M bsc/BSC_Tests.ttcn 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/27311/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 45c3239..b500c64 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6027,6 +6027,34 @@ f_verify_encr_info(chan_act); f_chan_act_verify_tsc(chan_act, expect_target_tsc); + if (ispresent(rx_bssap.pdu.bssmap.handoverRequestAck.codecList)) { + if (not g_pars.aoip) { + setverdict(fail, "handoverRequestAck: Expected no Speech Codec List (BSS Supported), because this is not AoIP"); + mtc.stop; + } else { + /* TODO: check actual codecs? */ + } + } else { + if (g_pars.aoip) { + setverdict(fail, "handoverRequestAck: Expected Speech Codec List (BSS Supported), but none found"); + mtc.stop; + } + } + + if (ispresent(rx_bssap.pdu.bssmap.handoverRequestAck.speechCodec)) { + if (not g_pars.aoip) { + setverdict(fail, "handoverRequestAck: Expected no Speech Codec (Chosen), because this is not AoIP"); + mtc.stop; + } else { + /* TODO: check actual codec? */ + } + } else { + if (g_pars.aoip) { + setverdict(fail, "handoverRequestAck: Expected Speech Codec (Chosen), but none found"); + mtc.stop; + } + } + ho_command_str := rx_bssap.pdu.bssmap.handoverRequestAck.layer3Information.layer3info; log("Received L3 Info in HO Request Ack: ", ho_command_str); var PDU_ML3_NW_MS ho_command := dec_PDU_ML3_NW_MS(ho_command_str); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2b4e27be241e2a92c0c3bffdf906bf22c09352b Gerrit-Change-Number: 27311 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: New stats for lchan life duration.

by iedemam

Attention is currently required from: iedemam, neels. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 to look at the new patch set (#11). Change subject: New stats for lchan life duration. ...................................................................... New stats for lchan life duration. This patch adds two stats which track cummulative lchan lifetime by type TCH and SDCCH. These new counters will accomplish two things: 1) Provide a glanceable way to see if lchan durations look healthy. When examining a site, short-lived (<5s) and long-lived (>30s) TCH lchans are difficult to tell apart. If we only see short-lived TCH lchans, there is most likely an RF or signaling problem to investigate. This new counter will expose channel ages in the VTY output 2) Provide a more accurate count for Erlangs per site. Currently, we are basing Erlangs on active TCH channel counts per stats period. This method skews high very quickly. Each active TCH in that period translates into the full 10s of activity. This counter should improve accuracy by two orders of magnitude. Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx_vty.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/lchan_fsm.c 7 files changed, 93 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/27081/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 11 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: inter-BSC HO in: add Codec List (BSS Supported) IE to HO Req Ack

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27310 ) Change subject: inter-BSC HO in: add Codec List (BSS Supported) IE to HO Req Ack ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c0576505a3ceb3cd5cc31dc69c5bc4a86a4ea08 Gerrit-Change-Number: 27310 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 15:35:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: BSSAP: HO Request Ack: add missing Codec List (BSS Supported)

by laforge

Attention is currently required from: neels, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27307 ) Change subject: BSSAP: HO Request Ack: add missing Codec List (BSS Supported) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9 Gerrit-Change-Number: 27307 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 15:35:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: inter-BSC HO in: add Speech Codec (Chosen) IE to HO Req Ack

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27309 ) Change subject: inter-BSC HO in: add Speech Codec (Chosen) IE to HO Req Ack ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1d0b395c97145b5aa1af4ef67aec9338d2f8f43b Gerrit-Change-Number: 27309 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 15:33:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: inter-BSC HO in: add speech IEs only on speech mode lchans

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27308 ) Change subject: inter-BSC HO in: add speech IEs only on speech mode lchans ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I830654f419e6f0a196dc6d3e58422e00b324af9e Gerrit-Change-Number: 27308 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 15:33:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: inter-BSC HO in: add Codec List (BSS Supported) IE to HO Req Ack

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27310 ) Change subject: inter-BSC HO in: add Codec List (BSS Supported) IE to HO Req Ack ...................................................................... inter-BSC HO in: add Codec List (BSS Supported) IE to HO Req Ack Related: SYS#5839 Depends: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9 (libosmocore) Change-Id: I3c0576505a3ceb3cd5cc31dc69c5bc4a86a4ea08 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/27310/1 diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index c02544a..878f1ff 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -1448,6 +1448,10 @@ LOG_HO(conn, LOGL_ERROR, "Unable to compose Speech Codec (Chosen)\n"); return HO_RESULT_ERROR; } + + /* Codec list (BSS Supported) */ + params.more_items = true; + gen_bss_supported_codec_list(&params.codec_list_bss_supported, conn->sccp.msc, new_lchan->ts->trx->bts); } rate_ctr_inc(rate_ctr_group_get_ctr(conn->sccp.msc->msc_ctrs, MSC_CTR_BSSMAP_TX_DT1_HANDOVER_RQST_ACKNOWLEDGE)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c0576505a3ceb3cd5cc31dc69c5bc4a86a4ea08 Gerrit-Change-Number: 27310 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022