February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: msc: Avoid race condition when setting osmux options via VTY

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27286 ) Change subject: msc: Avoid race condition when setting osmux options via VTY ...................................................................... msc: Avoid race condition when setting osmux options via VTY If the RAN_Emulation is started before the VTY reconfiguration we could get a BSSMAP Reset/ResetAck with Osmux support advertised even though the test expects it to be disabled (or vice versa). Do the VTY configuration before starting the RAN_Emulation. Fixes sporadic/load-related TTCN3 failures with message "BSSMAP: Timeout waiting for RESET-ACK after sending RESET" (e.g. TC_iu_and_mt_call_osmux, TC_iu_and_mo_sms in run +1567) Change-Id: Ife23f70c6523034f3c3c53b6c1c81428566fd43e --- M msc/MSC_Tests.ttcn 1 file changed, 24 insertions(+), 22 deletions(-) Approvals: lynxis lazus: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index db96d60..dd31daf 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -304,29 +304,7 @@ testcase.stop("excess number of BSC instances requested"); } - for (var integer i := 0; i < num_bsc; i := i + 1) { - if (isbound(mp_bssap_cfg[i])) { - var RanOps ranops := BSC_RanOps; - ranops.use_osmux := osmux; - f_ran_adapter_init(g_bssap[i], mp_bssap_cfg[i], "MSC_Test_" & int2str(i), ranops); - f_ran_adapter_start(g_bssap[i]); - } else { - testcase.stop("missing BSSAP configuration"); - } - } - f_ipa_ctrl_start_client(mp_msc_ip, mp_msc_ctrl_port); - f_init_mncc("MSC_Test"); - f_init_mgcp("MSC_Test"); - - if (gsup == true) { - f_init_gsup("MSC_Test"); - } - f_init_smpp("MSC_Test"); - - if (sgsap == true) { - f_init_sgsap("MSC_Test"); - } map(self:MSCVTY, system:MSCVTY); f_vty_set_prompts(MSCVTY); @@ -344,6 +322,30 @@ } else { f_vty_config(MSCVTY, "msc", "osmux off"); } + + for (var integer i := 0; i < num_bsc; i := i + 1) { + if (isbound(mp_bssap_cfg[i])) { + var RanOps ranops := BSC_RanOps; + ranops.use_osmux := osmux; + f_ran_adapter_init(g_bssap[i], mp_bssap_cfg[i], "MSC_Test_" & int2str(i), ranops); + f_ran_adapter_start(g_bssap[i]); + } else { + testcase.stop("missing BSSAP configuration"); + } + } + + f_init_mncc("MSC_Test"); + f_init_mgcp("MSC_Test"); + + if (gsup == true) { + f_init_gsup("MSC_Test"); + } + f_init_smpp("MSC_Test"); + + if (sgsap == true) { + f_init_sgsap("MSC_Test"); + } + } /* Initialize for a direct connection to BSSAP. This function is an alternative -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife23f70c6523034f3c3c53b6c1c81428566fd43e Gerrit-Change-Number: 27286 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: correct ip.access static configuration

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27303 ) Change subject: common: gb-ns2: correct ip.access static configuration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I652f7cda1e79e452af7740c1cae192a9f2b1acab Gerrit-Change-Number: 27303 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 22 Feb 2022 17:58:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc: Avoid race condition when setting osmux options via VTY

by lynxis lazus

Attention is currently required from: fixeria, daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27286 ) Change subject: msc: Avoid race condition when setting osmux options via VTY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife23f70c6523034f3c3c53b6c1c81428566fd43e Gerrit-Change-Number: 27286 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Feb 2022 17:58:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: update ip-sns configuration example

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27302 ) Change subject: common: gb-ns2: update ip-sns configuration example ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I0b20634d683ad8f93c1c8af35eacbb953c1db46b Gerrit-Change-Number: 27302 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 22 Feb 2022 17:57:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: remove empty VTY chapter

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27301 ) Change subject: common: gb-ns2: remove empty VTY chapter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/27301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iee28046fbb0a5a034c2a33c495a3ca6f8ef953c4 Gerrit-Change-Number: 27301 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 22 Feb 2022 17:56:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ranap: Allow RAB ReleaseList inside RabAssReq template

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27300 ) Change subject: ranap: Allow RAB ReleaseList inside RabAssReq template ...................................................................... ranap: Allow RAB ReleaseList inside RabAssReq template Related: OS#5152 Change-Id: If5dabf24ab410ef95f92be1cb865ac06330b495e --- M hnbgw/HNBGW_Tests.ttcn M library/ranap/RANAP_Templates.ttcn 2 files changed, 125 insertions(+), 103 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 7b9a49c..745e333 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -947,7 +947,7 @@ f_create_rab(pars.mgcp_pars); /* Send RAB Release */ - tx := valueof(ts_RANAP_RabAssignmentReqRabRel(ts_RAB_RL(t_RAB_id(23), ts_RanapCause_om_intervention))); + tx := valueof(ts_RANAP_RabAssReq(rab_rl := ts_RAB_RL(t_RAB_id(23), ts_RanapCause_om_intervention))); BSSAP.send(tx); T.start; diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index caccdc7..11947d9 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -1361,49 +1361,147 @@ } } } -template (value) RANAP_PDU -ts_RANAP_RabAssReq(template (value) RAB_SetupOrModifyList rab_sml, - template (omit) RAB_AssignmentRequest.protocolExtensions exts := omit) := { - initiatingMessage := { +template (value) RAB_ReleaseList ts_RAB_RL(template (value) RAB_ID rab_id, + template (value) Cause cause) := { { + { + id := id_RAB_ReleaseItem, + criticality := ignore, + value_ := { + rAB_ReleaseItem := { + rAB_ID := rab_id, + cause := cause, + iE_Extensions := omit + } + } + } +} } + +template RAB_ReleaseList tr_RAB_RL(template (present) RAB_ID rab_id, + template Cause cause := ?) := { { + { + id := id_RAB_ReleaseItem, + criticality := ignore, + value_ := { + rAB_ReleaseItem := { + rAB_ID := rab_id, + cause := cause, + iE_Extensions := * + } + } + } +} } + + +function +ts_RANAP_RabAssReq(template (omit) RAB_SetupOrModifyList rab_sml := omit, + template (omit) RAB_ReleaseList rab_rl := omit, + template (omit) RAB_AssignmentRequest.protocolExtensions exts := omit) return template RANAP_PDU { + var template RANAP_PDU ret; + var template RAB_AssignmentRequest.protocolIEs protocolIEs := {}; + var integer ie_pos := 0; + + var template RAB_AssignmentRequest.protocolIEs protocolIEs_rab_sml; + var template RAB_AssignmentRequest.protocolIEs protocolIEs_rab_rl; + + /* RAB-SetupOrModifyList */ + if (istemplatekind(rab_sml, "value")) { + protocolIEs_rab_sml := { + { + id := id_RAB_SetupOrModifyList, + criticality := ignore, + value_ := { + rAB_SetupOrModifyList := rab_sml + } + } + }; + protocolIEs[ie_pos] := protocolIEs_rab_sml[0]; + ie_pos := ie_pos + 1; + } + + /* RAB-ReleaseList */ + if (istemplatekind(rab_rl, "value")) { + protocolIEs_rab_rl := { + { + id := id_RAB_ReleaseList, + criticality := ignore, + value_ := { + rAB_ReleaseList := rab_rl + } + } + }; + protocolIEs[ie_pos] := protocolIEs_rab_rl[0]; + ie_pos := ie_pos + 1; + } + + + ret.initiatingMessage := { procedureCode := id_RAB_Assignment, criticality := reject, value_ := { rAB_AssignmentRequest := { - protocolIEs := { - { - id := id_RAB_SetupOrModifyList, - criticality := ignore, - value_ := { - rAB_SetupOrModifyList := rab_sml - } - } - }, + protocolIEs := protocolIEs, protocolExtensions := exts } } } + + return ret; } -template RANAP_PDU -tr_RANAP_RabAssReq(template RAB_SetupOrModifyList rab_sml, - template RAB_AssignmentRequest.protocolExtensions exts := *) := { - initiatingMessage := { + +function +tr_RANAP_RabAssReq(template RAB_SetupOrModifyList rab_sml := omit, + template RAB_ReleaseList rab_rl := omit, + template RAB_AssignmentRequest.protocolExtensions exts := *) return template RANAP_PDU { + var template RANAP_PDU ret; + var template RAB_AssignmentRequest.protocolIEs protocolIEs := {}; + var integer ie_pos := 0; + + var template RAB_AssignmentRequest.protocolIEs protocolIEs_rab_sml; + var template RAB_AssignmentRequest.protocolIEs protocolIEs_rab_rl; + + /* RAB-SetupOrModifyList */ + if (not istemplatekind(rab_sml, "omit")) { + protocolIEs_rab_sml := { + { + id := id_RAB_SetupOrModifyList, + criticality := ignore, + value_ := { + rAB_SetupOrModifyList := rab_sml + } + } + }; + protocolIEs[ie_pos] := protocolIEs_rab_sml[0]; + ie_pos := ie_pos + 1; + } + + /* RAB-ReleaseList */ + if (not istemplatekind(rab_rl, "omit")) { + protocolIEs_rab_rl := { + { + id := id_RAB_ReleaseList, + criticality := ignore, + value_ := { + rAB_ReleaseList := rab_rl + } + } + }; + protocolIEs[ie_pos] := protocolIEs_rab_rl[0]; + ie_pos := ie_pos + 1; + } + + + ret.initiatingMessage := { procedureCode := id_RAB_Assignment, criticality := reject, value_ := { rAB_AssignmentRequest := { - protocolIEs := { - { - id := id_RAB_SetupOrModifyList, - criticality := ignore, - value_ := { - rAB_SetupOrModifyList := rab_sml - } - } - }, + protocolIEs := protocolIEs, protocolExtensions := exts } } } + + return ret; } function @@ -1532,82 +1630,6 @@ return ret; } -template (value) RAB_ReleaseList ts_RAB_RL(template (value) RAB_ID rab_id, - template (value) Cause cause) := { { - { - id := id_RAB_ReleaseItem, - criticality := ignore, - value_ := { - rAB_ReleaseItem := { - rAB_ID := rab_id, - cause := cause, - iE_Extensions := omit - } - } - } -} } - -template RAB_ReleaseList tr_RAB_RL(template (present) RAB_ID rab_id, - template Cause cause := ?) := { { - { - id := id_RAB_ReleaseItem, - criticality := ignore, - value_ := { - rAB_ReleaseItem := { - rAB_ID := rab_id, - cause := cause, - iE_Extensions := * - } - } - } -} } - -template (value) RANAP_PDU -ts_RANAP_RabAssignmentReqRabRel(template (value) RAB_ReleaseList rab_rl, - template (omit) RAB_AssignmentRequest.protocolExtensions exts := omit) := { - initiatingMessage := { - procedureCode := id_RAB_Assignment, - criticality := reject, - value_ := { - rAB_AssignmentRequest := { - protocolIEs := { - { - id := id_RAB_ReleaseList, - criticality := ignore, - value_ := { - rAB_ReleaseList := rab_rl - } - } - }, - protocolExtensions := exts - } - } - } -} - -template RANAP_PDU -tr_RANAP_RabAssignmentReqRabRel(template RAB_ReleaseList rab_rl, - template RAB_AssignmentRequest.protocolExtensions exts := *) := { - initiatingMessage := { - procedureCode := id_RAB_Assignment, - criticality := reject, - value_ := { - rAB_AssignmentRequest := { - protocolIEs := { - { - id := id_RAB_ReleaseList, - criticality := ignore, - value_ := { - rAB_ReleaseList := rab_rl - } - } - }, - protocolExtensions := exts - } - } - } -} - /***************************************************************************************************** * *****************************************************************************************************/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If5dabf24ab410ef95f92be1cb865ac06330b495e Gerrit-Change-Number: 27300 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ranap: Fix criticality in IuReleaseRequest

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27298 ) Change subject: ranap: Fix criticality in IuReleaseRequest ...................................................................... ranap: Fix criticality in IuReleaseRequest Change-Id: Ib636f5d5ca02962b1592f64d0af30b4b3c9f0053 Related: OS#5152 --- M library/ranap/RANAP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index 6b4699e..caccdc7 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -451,7 +451,7 @@ protocolIEs := { { id := id_Cause, - criticality := reject, + criticality := ignore, value_ := { cause := cause } @@ -473,7 +473,7 @@ protocolIEs := { { id := id_Cause, - criticality := reject, + criticality := ignore, value_ := { cause := cause } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib636f5d5ca02962b1592f64d0af30b4b3c9f0053 Gerrit-Change-Number: 27298 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnbgw: Test behaviour when CRCX times out

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27299 ) Change subject: hnbgw: Test behaviour when CRCX times out ...................................................................... hnbgw: Test behaviour when CRCX times out Change-Id: Iba219641498aeacbba742de926cd7f15e3fe9d06 Related: OS#5152 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 49 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 314b0df..7b9a49c 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -979,6 +979,54 @@ vc_conn.done; } +friend function f_tc_rab_assign_mgcp_to(charstring id, TestHdlrParams pars) runs on ConnHdlr { + var MgcpCommand mgcp_cmd; + var RANAP_PDU tx; + var template RAB_SetupOrModifyList rab_sml; + timer T := 15.0; + + T.start; + f_init_handler(pars); + f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); + + tx := f_build_initial_ue(g_pars); + f_iuh2iu_connect(tx); + + + /* Send RAB Assignment Request */ + rab_sml := ts_RAB_SML(t_RAB_id(23), f_ts_RAB_TLA(pars.mgcp_pars.cn_rtp_ip), t_RAB_binding_port(pars.mgcp_pars.cn_rtp_port)); + tx := valueof(ts_RANAP_RabAssReq(rab_sml)); + BSSAP.send(tx); + + /* Ignore MGCP CRCX */ + alt { + [] MGCP.receive(tr_CRCX) -> value mgcp_cmd { + log("Ignoreing CRCX1", mgcp_cmd); + repeat; + } + [] BSSAP.receive(tr_RANAP_IuReleaseRequest(?)) { } + [] T.timeout { + setverdict(fail, "Timeout waiting for IuRelease"); + } + } + + /* Send Iu Release */ + tx := valueof(ts_RANAP_IuReleaseCommand(ts_RanapCause_om_intervention)); + f_iu2iuh(tx); + + tx := valueof(ts_RANAP_IuReleaseComplete()); + f_iuh2iu(tx); +} + +testcase TC_rab_assign_mgcp_to() runs on test_CT { + var ConnHdlr vc_conn; + f_init(); + f_start_hnbs(); + + vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_mgcp_to), t_pars(6)); + vc_conn.done; +} + /* Create an Iuh connection; send InitialUE; transceive data both directions */ friend function f_tc_ranap_bidir(charstring id, TestHdlrParams pars) runs on ConnHdlr { f_init_handler(pars); @@ -1059,6 +1107,7 @@ execute(TC_rab_assignment()); execute(TC_rab_release()); execute(TC_rab_assign_fail()); + execute(TC_rab_assign_mgcp_to()); execute(TC_ranap_cs_mo_disconnect()); execute(TC_ranap_ps_mo_disconnect()); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba219641498aeacbba742de926cd7f15e3fe9d06 Gerrit-Change-Number: 27299 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Add test for RABAssingResponse with FailedList

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27297 ) Change subject: Add test for RABAssingResponse with FailedList ...................................................................... Add test for RABAssingResponse with FailedList Change-Id: I043014929de5145f06d0a650f36d59c15e0d4044 Related: OS#5152 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 50 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 959fe87..314b0df 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -758,11 +758,15 @@ return mgcp_resp; } -friend function f_create_rab(MgcpParameters pars) runs on ConnHdlr { +friend function f_create_rab(inout MgcpParameters pars) runs on ConnHdlr { + f_rab_ass_req(pars); + f_rab_ass_resp(pars); +} + +friend function f_rab_ass_req(inout MgcpParameters pars) runs on ConnHdlr { var MgcpCommand mgcp_cmd; var RANAP_PDU tx; var template RAB_SetupOrModifyList rab_sml; - var template RAB_SetupOrModifiedList rab_smdl; timer T := 5.0; /* Send RAB Assignment Request */ @@ -795,6 +799,13 @@ setverdict(fail, "Timeout waiting for Iuh ", tx); } } +} + +friend function f_rab_ass_resp(inout MgcpParameters pars) runs on ConnHdlr { + var MgcpCommand mgcp_cmd; + var RANAP_PDU tx; + var template RAB_SetupOrModifiedList rab_smdl; + timer T := 5.0; /* Send back RAB Assignment Response via Iuh */ rab_smdl := ts_RAB_SMdL(t_RAB_id(23), f_ts_RAB_TLA(pars.hnb_rtp_ip), t_RAB_binding_port(pars.hnb_rtp_port)); @@ -842,7 +853,7 @@ log("DLCX", mgcp_cmd); MGCP.send(ts_DLCX_ACK2(mgcp_cmd.line.trans_id)); pars.mgcp_pars.got_dlcx_count := pars.mgcp_pars.got_dlcx_count + 1; - if (pars.mgcp_pars.got_dlcx_count == 1) { + if (pars.mgcp_pars.got_dlcx_count != pars.mgcp_pars.got_crcx_count) { repeat; } setverdict(pass); @@ -887,6 +898,41 @@ vc_conn.done; } +friend function f_tc_rab_assign_fail(charstring id, TestHdlrParams pars) runs on ConnHdlr { + var MgcpCommand mgcp_cmd; + var RANAP_PDU tx; + timer T := 5.0; + + f_init_handler(pars); + f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); + + tx := f_build_initial_ue(g_pars); + f_iuh2iu_connect(tx); + + f_rab_ass_req(pars.mgcp_pars); + + /* Send RAB failed list in response */ + tx := valueof(ts_RANAP_RabAssResp(rab_fl := ts_RAB_FL(t_RAB_id(23), ts_RanapCause_om_intervention))); + f_iuh2iu(tx); + + T.start; + alt { + [] as_mgcp_dlcx(pars) {} + [] T.timeout { + setverdict(fail, "Timeout waiting for DLCX"); + } + } +} + +testcase TC_rab_assign_fail() runs on test_CT { + var ConnHdlr vc_conn; + f_init(); + f_start_hnbs(); + + vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_fail), t_pars(4)); + vc_conn.done; +} + friend function f_tc_rab_release(charstring id, TestHdlrParams pars) runs on ConnHdlr { var MgcpCommand mgcp_cmd; var RANAP_PDU tx; @@ -1012,6 +1058,7 @@ execute(TC_ranap_ps_bidir()); execute(TC_rab_assignment()); execute(TC_rab_release()); + execute(TC_rab_assign_fail()); execute(TC_ranap_cs_mo_disconnect()); execute(TC_ranap_ps_mo_disconnect()); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I043014929de5145f06d0a650f36d59c15e0d4044 Gerrit-Change-Number: 27297 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ranap: Allow RAB ReleaseList inside RabAssReq template

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27300 ) Change subject: ranap: Allow RAB ReleaseList inside RabAssReq template ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If5dabf24ab410ef95f92be1cb865ac06330b495e Gerrit-Change-Number: 27300 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Feb 2022 17:55:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022