February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: New stats for lchan life duration.

by neels

Attention is currently required from: iedemam, laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: New stats for lchan life duration. ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: > for a struct osmo_time_cc *foo, you can use foo->total_sum. […] (...you could use a separate uint64_t last_total_sum, next to the osmo_time_cc, to work out the elapsed total_sum since last time you looked, if the total_sum is not sufficient) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 11 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Feb 2022 17:12:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: iedemam <michael(a)kapsulate.com> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: New stats for lchan life duration.

by neels

Attention is currently required from: iedemam, laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: New stats for lchan life duration. ...................................................................... Patch Set 11: (5 comments) Patchset: PS11: > Hi all, […] for a struct osmo_time_cc *foo, you can use foo->total_sum. It holds the total sum in microseconds (1e-6). osmo_time_cc doesn't use rbtree, will have to look closer to identify the problem PS11: (just some comments, haven't fully reviewed yet) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/e851e96c_94ff084e PS8, Line 1514: "Cummulative number of active milliseconds on TCH chans", > Done you're right, it's not the average indeed File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/ba625ea8_c9c082b3 PS8, Line 1810: > This is a great bit of information. I do think it is important to capture the error timeouts. […] another idea would be to have a separate accumulator for the release process (from established_onleave to unused_onenter). it should yield a fairly constant value in normal operation for all lchans. it would be easier to see chan release problems on a separate metric. https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/de81d689_797e7b5c PS8, Line 1811: /* Add active milliseconds to cummulative counts per channel type */ > Adopted. […] ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 11 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Feb 2022 17:08:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: iedemam <michael(a)kapsulate.com> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmocom-bb[master]: mobile/subscriber.c: fix auth resp with test sim

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27312 ) Change subject: mobile/subscriber.c: fix auth resp with test sim ...................................................................... Patch Set 2: (1 comment) File src/host/layer23/src/mobile/subscriber.c: https://gerrit.osmocom.org/c/osmocom-bb/+/27312/comment/68588be6_11113851 PS2, Line 908: || !subscr->sim_valid || no_sim) { just wondering: is sim_type containing meaningul stuff if sucr->sim_valid is false? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0ee910c171d383fb2cdcaf5eb54eafe18da3430b Gerrit-Change-Number: 27312 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 17:01:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmocom-bb[master]: mobile/subscriber.c: fix auth resp with test sim

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27312 ) Change subject: mobile/subscriber.c: fix auth resp with test sim ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0ee910c171d383fb2cdcaf5eb54eafe18da3430b Gerrit-Change-Number: 27312 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 23 Feb 2022 16:59:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: BSSAP: HO Request Ack: add missing Codec List (BSS Supported)

by pespin

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27307 ) Change subject: BSSAP: HO Request Ack: add missing Codec List (BSS Supported) ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > am I? that's what the more_items flag is for. […] Ah sorry, the way gerrit showed me the diff I thought the mote_items field didn't exist before! my fault. It's fine. However still good to add a TODO-RELEASE entry since new fields are available (I have to take that into account when increasing the libversion stuff). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9 Gerrit-Change-Number: 27307 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 16:58:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: BSSAP: HO Request Ack: add missing Codec List (BSS Supported)

by neels

Attention is currently required from: pespin, dexter. Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27307 to look at the new patch set (#2). Change subject: BSSAP: HO Request Ack: add missing Codec List (BSS Supported) ...................................................................... BSSAP: HO Request Ack: add missing Codec List (BSS Supported) Related: SYS#5839 Related: I3c0576505a3ceb3cd5cc31dc69c5bc4a86a4ea08 (osmo-bsc) Change-Id: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9 --- M TODO-RELEASE M include/osmocom/gsm/gsm0808.h M src/gsm/gsm0808.c 3 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/27307/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9 Gerrit-Change-Number: 27307 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmocom-bb[master]: mobile/subscriber.c: fix auth resp with test sim

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27312 ) Change subject: mobile/subscriber.c: fix auth resp with test sim ...................................................................... mobile/subscriber.c: fix auth resp with test sim Do not send a dummy authentication response with the test sim. Fixes: 39dc9c46 ("mobile/subscriber.c: consider GSM_SIM_TYPE_SAP too") Change-Id: I0ee910c171d383fb2cdcaf5eb54eafe18da3430b --- M src/host/layer23/src/mobile/subscriber.c 1 file changed, 19 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/12/27312/1 diff --git a/src/host/layer23/src/mobile/subscriber.c b/src/host/layer23/src/mobile/subscriber.c index 500dd76..059ae67 100644 --- a/src/host/layer23/src/mobile/subscriber.c +++ b/src/host/layer23/src/mobile/subscriber.c @@ -903,25 +903,6 @@ struct msgb *nmsg; struct sim_hdr *nsh; - /* not a SIM */ - if (!GSM_SIM_IS_READER(subscr->sim_type) - || !subscr->sim_valid || no_sim) { - struct gsm48_mm_event *nmme; - - LOGP(DMM, LOGL_INFO, "Sending dummy authentication response\n"); - nmsg = gsm48_mmevent_msgb_alloc(GSM48_MM_EVENT_AUTH_RESPONSE); - if (!nmsg) - return -ENOMEM; - nmme = (struct gsm48_mm_event *) nmsg->data; - nmme->sres[0] = 0x12; - nmme->sres[1] = 0x34; - nmme->sres[2] = 0x56; - nmme->sres[3] = 0x78; - gsm48_mmevent_msg(ms, nmsg); - - return 0; - } - /* test SIM */ if (subscr->sim_type == GSM_SIM_TYPE_TEST) { struct gsm48_mm_event *nmme; @@ -953,6 +934,25 @@ return 0; } + /* not a SIM */ + if (!GSM_SIM_IS_READER(subscr->sim_type) + || !subscr->sim_valid || no_sim) { + struct gsm48_mm_event *nmme; + + LOGP(DMM, LOGL_INFO, "Sending dummy authentication response\n"); + nmsg = gsm48_mmevent_msgb_alloc(GSM48_MM_EVENT_AUTH_RESPONSE); + if (!nmsg) + return -ENOMEM; + nmme = (struct gsm48_mm_event *) nmsg->data; + nmme->sres[0] = 0x12; + nmme->sres[1] = 0x34; + nmme->sres[2] = 0x56; + nmme->sres[3] = 0x78; + gsm48_mmevent_msg(ms, nmsg); + + return 0; + } + LOGP(DMM, LOGL_INFO, "Generating KEY at SIM\n"); /* command to SIM */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0ee910c171d383fb2cdcaf5eb54eafe18da3430b Gerrit-Change-Number: 27312 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: BSSAP: HO Request Ack: add missing Codec List (BSS Supported)

by neels

Attention is currently required from: pespin, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27307 ) Change subject: BSSAP: HO Request Ack: add missing Codec List (BSS Supported) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Please update TODO-RELEASE, you are breaking the ABI here. am I? that's what the more_items flag is for. I can add to TODO-RELEASE that there is a new member in the struct, but using the more_items boolean makes any version work with any other version. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9 Gerrit-Change-Number: 27307 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 16:52:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: BSSAP: HO Request Ack: add missing Codec List (BSS Supported)

by pespin

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27307 ) Change subject: BSSAP: HO Request Ack: add missing Codec List (BSS Supported) ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Please update TODO-RELEASE, you are breaking the ABI here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iab0a7b4d81592157fc111d1adb9e9f4cb53a94e9 Gerrit-Change-Number: 27307 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 16:28:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO in: expect codecs in HO Request ACK

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 ) Change subject: bsc: inter-BSC HO in: expect codecs in HO Request ACK ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311/comment/c2d25a76_af51… PS1, Line 6033: mtc.stop; Misc_Helpers.f_shutdown() would fit better here (also in other additions below). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2b4e27be241e2a92c0c3bffdf906bf22c09352b Gerrit-Change-Number: 27311 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 16:26:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022