December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-gsm-tester[master]: sysmocom/resources.conf.prod: power_supply for all BTSs

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30730 ) Change subject: sysmocom/resources.conf.prod: power_supply for all BTSs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Maybe state that despite those being added, at the current time only bts_nanobts.py and bts_osmotrx.py classes really support operating the power_supply objects. Missing bts classes supporting it: bts_oc2g.py bts_octphy.py bts_osmovirtual.py bts_sysmo.py -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ib17207447d346378b6050a49d1dddb3b9b7df028 Gerrit-Change-Number: 30730 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Dec 2022 17:27:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-gsm-tester[master]: sysmocom/resources.conf.prod: power_supply for all BTSs

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30730 ) Change subject: sysmocom/resources.conf.prod: power_supply for all BTSs ...................................................................... sysmocom/resources.conf.prod: power_supply for all BTSs We now have a Intellinet PDU channel for each of the BTSs. Related: OS#5838 Change-Id: Ib17207447d346378b6050a49d1dddb3b9b7df028 --- M sysmocom/resources.conf.prod 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/30/30730/1 diff --git a/sysmocom/resources.conf.prod b/sysmocom/resources.conf.prod index 461ada9..d05af9d 100644 --- a/sysmocom/resources.conf.prod +++ b/sysmocom/resources.conf.prod @@ -25,6 +25,10 @@ band: GSM-1800 trx_list: - arfcn: 868 + power_supply: + type: 'intellinet' + device: '10.42.42.250' + port: '7' direct_pcu: true ciphers: [a5_0, a5_1, a5_3] @@ -35,6 +39,10 @@ band: GSM-1800 trx_list: - arfcn: 850 + power_supply: + type: 'intellinet' + device: '10.42.42.251' + port: '8' - arfcn: 852 ciphers: [a5_0, a5_1, a5_3] osmo_trx: @@ -53,6 +61,10 @@ band: GSM-1800 trx_list: - arfcn: 854 + power_supply: + type: 'intellinet' + device: '10.42.42.251' + port: '7' - arfcn: 856 ciphers: [a5_0, a5_1, a5_3] osmo_trx: @@ -70,6 +82,10 @@ band: GSM-1800 trx_list: - arfcn: 858 + power_supply: + type: 'intellinet' + device: '10.42.42.251' + port: '6' ciphers: [a5_0, a5_1, a5_3] osmo_trx: type: lms @@ -88,6 +104,10 @@ band: GSM-1800 trx_list: - arfcn: 860 + power_supply: + type: 'intellinet' + device: '10.42.42.251' + port: '5' ciphers: [a5_0, a5_1] osmo_trx: type: lms @@ -125,6 +145,10 @@ - hw_addr: 00:0c:90:2e:80:1e net_device: enp2s0 arfcn: 864 + power_supply: + type: 'intellinet' + device: '10.42.42.250' + port: '8' - label: NanoBTS-ONW-1900 type: nanobts @@ -173,6 +197,10 @@ band: GSM-900 trx_list: - arfcn: 50 + power_supply: + type: 'intellinet' + device: '10.42.42.250' + port: '4' direct_pcu: true ciphers: [a5_0, a5_1, a5_3] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ib17207447d346378b6050a49d1dddb3b9b7df028 Gerrit-Change-Number: 30730 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-bts[master]: rsl.adoc: add info about RSL_IE_OSMO_HR_GSM_RTP_FMT

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/30728 to look at the new patch set (#2). Change subject: rsl.adoc: add info about RSL_IE_OSMO_HR_GSM_RTP_FMT ...................................................................... rsl.adoc: add info about RSL_IE_OSMO_HR_GSM_RTP_FMT Change-Id: I1d40f688ad1729efffee846e7f9efd06cf64ce28 Related: OS#5688 --- M doc/manuals/abis/rsl.adoc 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/30728/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1d40f688ad1729efffee846e7f9efd06cf64ce28 Gerrit-Change-Number: 30728 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: stream: Fix tx data dropped upon show socket write

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30722 ) Change subject: stream: Fix tx data dropped upon show socket write ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I3755aada02ceb186fb990604e3496126fe47e1fb Gerrit-Change-Number: 30722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:52:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bts[master]: rsl.adoc: add info about RSL_IE_OSMO_REP_ACCH_CAP

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30728 ) Change subject: rsl.adoc: add info about RSL_IE_OSMO_REP_ACCH_CAP ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: the commit title is wrong, it's another IE. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1d40f688ad1729efffee846e7f9efd06cf64ce28 Gerrit-Change-Number: 30728 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:37:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: allow extending FBSB timeout (quirks for slow PHYs)

by pespin

Attention is currently required from: Hoernchen, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30612 ) Change subject: trxcon: allow extending FBSB timeout (quirks for slow PHYs) ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia68954c5bdacda45fc871ffea0ccdf2460936408 Gerrit-Change-Number: 30612 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:36:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: use strtoul() instead of atoi(), detect errors

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30729 ) Change subject: trxcon: use strtoul() instead of atoi(), detect errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I18ec88f1ee30c58d088fe65650d0257b262c1fee Gerrit-Change-Number: 30729 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:36:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: allow extending FBSB timeout (quirks for slow PHYs)

by fixeria

Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30612 ) Change subject: trxcon: allow extending FBSB timeout (quirks for slow PHYs) ...................................................................... Patch Set 3: (2 comments) File src/host/trxcon/src/trxcon_main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30612/comment/bb212623_e46bd075 PS2, Line 71: int phyq_fbsb_extend_fns; > unsigned? this cannot be negative right? Done https://gerrit.osmocom.org/c/osmocom-bb/+/30612/comment/b6b5c3e5_25a5cc01 PS2, Line 243: app_data.phyq_fbsb_extend_fns = atoi(optarg); > ah so you are declaring it as an int just in order to be able to use atoi. […] Ok, I spent additional time switching from atoi() to strtoul(): https://gerrit.osmocom.org/c/osmocom-bb/+/30729 But now I don't see how can I detect negative values and print an error. The strtoul() would simply return a huge value and indicate no errors. In any case, this is already taking more time than implementing the FBSB timeout extension feature itself, so I am giving up. Not critical. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia68954c5bdacda45fc871ffea0ccdf2460936408 Gerrit-Change-Number: 30612 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:31:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: use strtoul() instead of atoi(), detect errors

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30729 ) Change subject: trxcon: use strtoul() instead of atoi(), detect errors ...................................................................... trxcon: use strtoul() instead of atoi(), detect errors Change-Id: I18ec88f1ee30c58d088fe65650d0257b262c1fee --- M src/host/trxcon/src/trxcon_main.c 1 file changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/29/30729/1 diff --git a/src/host/trxcon/src/trxcon_main.c b/src/host/trxcon/src/trxcon_main.c index 95e5549..742246e 100644 --- a/src/host/trxcon/src/trxcon_main.c +++ b/src/host/trxcon/src/trxcon_main.c @@ -188,6 +188,7 @@ static void handle_options(int argc, char **argv) { while (1) { + char *endptr = NULL; int option_index = 0, c; static struct option long_options[] = { {"help", 0, 0, 'h'}, @@ -211,6 +212,8 @@ if (c == -1) break; + errno = 0; + switch (c) { case 'h': print_usage(argv[0]); @@ -227,10 +230,18 @@ app_data.trx_remote_ip = optarg; break; case 'p': - app_data.trx_base_port = atoi(optarg); + app_data.trx_base_port = strtoul(optarg, &endptr, 10); + if (errno || *endptr != '\0') { + fprintf(stderr, "Failed to parse -p/--trx-port=%s\n", optarg); + exit(EXIT_FAILURE); + } break; case 'f': - app_data.trx_fn_advance = atoi(optarg); + app_data.trx_fn_advance = strtoul(optarg, &endptr, 10); + if (errno || *endptr != '\0') { + fprintf(stderr, "Failed to parse -f/--trx-advance=%s\n", optarg); + exit(EXIT_FAILURE); + } break; case 's': app_data.bind_socket = optarg; @@ -239,7 +250,11 @@ app_data.gsmtap_ip = optarg; break; case 'C': - app_data.max_clients = atoi(optarg); + app_data.max_clients = strtoul(optarg, &endptr, 10); + if (errno || *endptr != '\0') { + fprintf(stderr, "Failed to parse -C/--max-clients=%s\n", optarg); + exit(EXIT_FAILURE); + } break; case 'D': app_data.daemonize = 1; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I18ec88f1ee30c58d088fe65650d0257b262c1fee Gerrit-Change-Number: 30729 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: allow extending FBSB timeout (quirks for slow PHYs)

by fixeria

Attention is currently required from: Hoernchen, laforge, fixeria. Hello Jenkins Builder, Hoernchen, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30612 to look at the new patch set (#3). Change subject: trxcon: allow extending FBSB timeout (quirks for slow PHYs) ...................................................................... trxcon: allow extending FBSB timeout (quirks for slow PHYs) This is needed for SDR based PHYs, because for them it takes longer to tune, flush the buffers and so on. Add a field to the trxcon_inst structure and a command line option (-F) for the trxcon app. Change-Id: Ia68954c5bdacda45fc871ffea0ccdf2460936408 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/trxcon_fsm.c M src/host/trxcon/src/trxcon_inst.c M src/host/trxcon/src/trxcon_main.c 4 files changed, 27 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/12/30612/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia68954c5bdacda45fc871ffea0ccdf2460936408 Gerrit-Change-Number: 30612 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022