December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/30726 ) Change subject: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE ...................................................................... rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE Unfortunately there are two different RTP formats (RFC5993 and TS 101.318) for HR GSM specified and it is unclear which should be used with GSM networks. Also esch BTS model may have a preference for either one or the other format. We already accept both formats but we do not have a way to select the transmitting format yet. Lets add a new RSL IE to control which format is used. Depends: libosmocore I843c8a0cbe5898311f3af3294cec7c8bc96c4eb8 Change-Id: Id53ebebdf987fc59cf4e38bcddb75663fd7bb8fc Related: OS#5688 --- M include/osmo-bts/bts.h M include/osmo-bts/lchan.h M src/common/l1sap.c M src/common/rsl.c 4 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/26/30726/1 diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h index b1a594c..e5fc90a 100644 --- a/include/osmo-bts/bts.h +++ b/include/osmo-bts/bts.h @@ -65,6 +65,11 @@ #define BTS_INTERNAL_FLAG_NM_RCHANNEL_DEPENDS_RCARRIER (1 << 2) /* Whether the BTS model reports interference measurements to L1SAP. */ #define BTS_INTERNAL_FLAG_INTERF_MEAS (1 << 3) +/* Whether the BTS model supports HR GSM RTP payload in + * GSM ETSI TS.101.138 (TIPHON) format */ +#define BTS_INTERNAL_FLAG_SPEECH_H_V1_TS101318 (1 << 4) +/* Whether the BTS model supports HR GSM RTP payload in RFC 5883 format */ +#define BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993 (1 << 5) /* BTS implementation flags (internal use, not exposed via OML) */ #define bts_internal_flag_get(bts, flag) \ diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h index d89aa1f..4a3215c 100644 --- a/include/osmo-bts/lchan.h +++ b/include/osmo-bts/lchan.h @@ -133,6 +133,12 @@ uint8_t current; }; +enum hr_hsm_rtp_fmt { + RTP_FMT_NATIVE, + RTP_FMT_SPEECH_H_V1_TS101318, + RTP_FMT_SPEECH_H_V1_RFC5993, +}; + struct gsm_lchan { /* The TS that we're part of */ struct gsm_bts_trx_ts *ts; @@ -164,6 +170,7 @@ uint8_t rtp_payload; uint8_t rtp_payload2; uint8_t speech_mode; + bool rtp_hr_rfc5993; struct { bool use; uint8_t local_cid; @@ -311,6 +318,9 @@ struct abis_rsl_osmo_temp_ovp_acch_cap top_acch_cap; bool top_acch_active; + /* HR GSM RTP format setting. This sets the RTP format the BTS emits. */ + enum hr_hsm_rtp_fmt hr_hsm_rtp_fmt; + struct msgb *pending_rel_ind_msg; /* ECU (Error Concealment Unit) state */ diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 410fb91..d24161f 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1625,6 +1625,16 @@ msgb_pull_to_l2(msg); + /* Convert GSM HR RTP to the output format that was specified by the BSC via RSL */ + if (lchan->tch_mode == GSM48_CMODE_SPEECH_V1 && lchan->type == GSM_LCHAN_TCH_H) { + if (lchan->hr_hsm_rtp_fmt == RTP_FMT_SPEECH_H_V1_TS101318 && msg->len == GSM_HR_BYTES + 1) { + msgb_pull(msg, 1); + } else if (lchan->hr_hsm_rtp_fmt == RTP_FMT_SPEECH_H_V1_RFC5993 && msg->len == GSM_HR_BYTES) { + msgb_push(msg, 1); + msg->data[0] = 0x00; + } + } + /* Low level layers always call us when TCH content is expected, even if * the content is not available due to decoding issues. Content not * available is expected as empty payload. We also check if quality is diff --git a/src/common/rsl.c b/src/common/rsl.c index 91af6cb..214cb51 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1618,6 +1618,29 @@ return 0; } +/* Parse RSL_IE_OSMO_HR_GSM_RTP_FMT */ +static int parse_hr_gsm_fmt_setting(struct gsm_lchan *lchan, const struct tlv_parsed *tp) +{ + /* When the TLV is not present the BTS will emit RTP packets in the format it natively supports. (e.g. for + * osmo-bts-trx this will be RFC 5993) */ + if (!TLVP_PRES_LEN(tp, RSL_IE_OSMO_HR_GSM_RTP_FMT, 1)) { + lchan->hr_hsm_rtp_fmt = RTP_FMT_NATIVE; + return 0; + } + + if (TLVP_VAL(tp, RSL_IE_OSMO_HR_GSM_RTP_FMT)[0] == 0x00) { + lchan->hr_hsm_rtp_fmt = RTP_FMT_SPEECH_H_V1_TS101318; + } else if (TLVP_VAL(tp, RSL_IE_OSMO_HR_GSM_RTP_FMT)[0] == 0x01) { + lchan->hr_hsm_rtp_fmt = RTP_FMT_SPEECH_H_V1_RFC5993; + } else { + LOGP(DRSL, LOGL_ERROR, "ignoring unknown HR GSM RTP format %02x!\n", + TLVP_VAL(tp, RSL_IE_OSMO_HR_GSM_RTP_FMT)[0]); + lchan->hr_hsm_rtp_fmt = RTP_FMT_NATIVE; + } + + return 0; +} + /* Parse (O) MultiRate configuration IE (see 9.3.52) */ static int parse_multirate_config(struct gsm_lchan *lchan, const struct tlv_parsed *tp) @@ -1967,6 +1990,9 @@ rc = parse_temporary_overpower_acch_capability(lchan, &tp); if (rc < 0) return rsl_tx_chan_act_acknack(lchan, -rc); + rc = parse_hr_gsm_fmt_setting(lchan, &tp); + if (rc < 0) + return rsl_tx_chan_act_acknack(lchan, -rc); /* Take the first ACCH overpower decision (if allowed): it can be * enabled immediately if the RxQual threshold is disabled (0). */ @@ -2239,6 +2265,9 @@ rc = parse_temporary_overpower_acch_capability(lchan, &tp); if (rc < 0) return rsl_tx_mode_modif_nack(lchan, -rc); + rc = parse_hr_gsm_fmt_setting(lchan, &tp); + if (rc < 0) + return rsl_tx_mode_modif_nack(lchan, -rc); /* Immediately disable ACCH overpower if the value is 0 dB, * or enable if the RxQual threshold becomes disabled (0). */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id53ebebdf987fc59cf4e38bcddb75663fd7bb8fc Gerrit-Change-Number: 30726 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/30725 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ...................................................................... l1sap: Accept RFC5993 and TS 101.318 HR GSM payload Unfotunately there are two different RTP formats for HR GSM specified and it is unclear which should be used with GSM networks. Also esch BTS model may have a preference for either one or the other format. Lets set internal flags to determine the preference for each BTS model and then lets use this information to convert incoming RTP packets into the prefered format. Doing so we will make sure that always both formats are accepted. Change-Id: I17f0b546042fa333780fd2f5c315898ab0df574c Related: OS#5688 --- M src/common/l1sap.c M src/osmo-bts-lc15/main.c M src/osmo-bts-oc2g/main.c M src/osmo-bts-sysmo/main.c M src/osmo-bts-trx/main.c M src/osmo-bts-virtual/main.c 6 files changed, 66 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/30725/1 diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 22b5e8c..410fb91 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1253,6 +1253,35 @@ osmo_hexdump(resp_msg->data, resp_msg->len)); return false; } + + /* Avoid sending an incompatible HR GSM RTP format to lower layers. Two + * formats exist: ETSI TS 101.318 and RFC 5993. This check is only + * carried out when the BTS model explicitly states a preference. */ + if (lchan->tch_mode == GSM48_CMODE_SPEECH_V1 && lchan->type == GSM_LCHAN_TCH_H) { + if (bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993)) { + if (resp_msg->len != GSM_HR_BYTES + 1) { + LOGPLCHAN(lchan, DL1P, LOGL_NOTICE, + "RTP->L1: Dropping unexpected HR GSM encoding (expected RFC 5993, got TS 101.318?) %s\n", + osmo_hexdump(resp_msg->data, resp_msg->len)); + return false; + } + } else if (bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_TS101318)) { + if (resp_msg->len != GSM_HR_BYTES) { + LOGPLCHAN(lchan, DL1P, LOGL_NOTICE, + "RTP->L1: Dropping unexpected HR GSM encoding (expected TS 101.318, got RFC 5993?) %s\n", + osmo_hexdump(resp_msg->data, resp_msg->len)); + return false; + } + } else { + /* NOTE: Each BTS model must specify which HR GSM RTP format it supports. Since forwarding a + * random payload format might lead to unexpected effects and unreliable operation in the field + * it is better to drop the payload early. */ + LOGPLCHAN(lchan, DL1P, LOGL_ERROR, + "BTS model does not specify HR GSM RTP format (RFC5993 or ETSI TS 101.318?), dropping payload!\n"); + return false; + } + } + return true; } @@ -1888,10 +1917,37 @@ if (lchan->loopback) return; - msg = l1sap_msgb_alloc(rtp_pl_len); - if (!msg) - return; - memcpy(msgb_put(msg, rtp_pl_len), rtp_pl, rtp_pl_len); + /* There are two different specifications that describe how HR GSM audio should be encapsulated in RTP frames: + * RFC 5993 and ETSI TS 101.318 (TIPHON). In order to be able to accept both formats we convert them on + * reception depending on what the particular BTS model supports. */ + switch (lchan->tch_mode) { + case GSM48_CMODE_SPEECH_V1: + if (lchan->type == GSM_LCHAN_TCH_H && rtp_pl_len == GSM_HR_BYTES + && bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993)) { + msg = l1sap_msgb_alloc(rtp_pl_len + 1); + if (!msg) + return; + /* Note: The only difference between both formats is that RFC 5993 specifies an additional one + * byte TOC header in front of the audio payload. (See also: RFC 5993, section 5.2) */ + msgb_put_u8(msg, 0x00); + memcpy(msgb_put(msg, rtp_pl_len), rtp_pl, rtp_pl_len); + break; + } else if (lchan->type == GSM_LCHAN_TCH_H && rtp_pl_len == GSM_HR_BYTES + 1 + && bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_TS101318)) { + msg = l1sap_msgb_alloc(rtp_pl_len - 1); + if (!msg) + return; + memcpy(msgb_put(msg, rtp_pl_len - 1), rtp_pl + 1, rtp_pl_len - 1); + break; + } + /* fallthrough, no conversion required */ + default: + msg = l1sap_msgb_alloc(rtp_pl_len); + if (!msg) + return; + memcpy(msgb_put(msg, rtp_pl_len), rtp_pl, rtp_pl_len); + } + msgb_pull(msg, sizeof(struct osmo_phsap_prim)); /* Store RTP header Marker bit in control buffer */ diff --git a/src/osmo-bts-lc15/main.c b/src/osmo-bts-lc15/main.c index cb2a9ac..dd82f5e 100644 --- a/src/osmo-bts-lc15/main.c +++ b/src/osmo-bts-lc15/main.c @@ -113,6 +113,7 @@ bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_MS_PWR_CTRL_DSP); bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_NM_RCHANNEL_DEPENDS_RCARRIER); + bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_TS101318); return 0; } diff --git a/src/osmo-bts-oc2g/main.c b/src/osmo-bts-oc2g/main.c index 4484d58..560c6c3 100644 --- a/src/osmo-bts-oc2g/main.c +++ b/src/osmo-bts-oc2g/main.c @@ -114,6 +114,7 @@ bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_MS_PWR_CTRL_DSP); bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_NM_RCHANNEL_DEPENDS_RCARRIER); + bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_TS101318); return 0; } diff --git a/src/osmo-bts-sysmo/main.c b/src/osmo-bts-sysmo/main.c index 95492eb..e2a9882 100644 --- a/src/osmo-bts-sysmo/main.c +++ b/src/osmo-bts-sysmo/main.c @@ -81,6 +81,7 @@ bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_MEAS_PAYLOAD_COMB); bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_MS_PWR_CTRL_DSP); bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_NM_RCHANNEL_DEPENDS_RCARRIER); + bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_TS101318); return 0; } diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c index 4bd7f0f..19aaa8c 100644 --- a/src/osmo-bts-trx/main.c +++ b/src/osmo-bts-trx/main.c @@ -157,6 +157,7 @@ bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_MEAS_PAYLOAD_COMB); bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_INTERF_MEAS); + bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993); return 0; } diff --git a/src/osmo-bts-virtual/main.c b/src/osmo-bts-virtual/main.c index 20b480f..ad0d27e 100644 --- a/src/osmo-bts-virtual/main.c +++ b/src/osmo-bts-virtual/main.c @@ -71,6 +71,8 @@ osmo_bts_set_feature(bts->features, BTS_FEAT_SPEECH_H_AMR); osmo_bts_set_feature(bts->features, BTS_FEAT_SPEECH_H_V1); + bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993); + return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I17f0b546042fa333780fd2f5c315898ab0df574c Gerrit-Change-Number: 30725 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

by arehbein

Attention is currently required from: arehbein, laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30703 to look at the new patch set (#4). Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... libosmocore: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 --- M include/osmocom/vty/telnet_interface.h M src/vty/telnet_interface.c 2 files changed, 34 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/30703/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: signal HR GSM RTP format to BTS via RSL

by dexter

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30630 to look at the new patch set (#2). Change subject: abis_rsl: signal HR GSM RTP format to BTS via RSL ...................................................................... abis_rsl: signal HR GSM RTP format to BTS via RSL There are two RTP formats that can be used to transfer HR GSM audio (RFC 5339 and ETSI TS 101.318) Depends: libosmocore I843c8a0cbe5898311f3af3294cec7c8bc96c4eb8 Change-Id: I16804364d95da9e1f5ac3b831c31079a7409e58d Related: OS#5688 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts_vty.c 3 files changed, 86 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/30/30630/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I16804364d95da9e1f5ac3b831c31079a7409e58d Gerrit-Change-Number: 30630 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: signal HR GSM RTP format to BTS via RSL

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30630 ) Change subject: abis_rsl: signal HR GSM RTP format to BTS via RSL ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30630/comment/9edd7c9c_1ee80a0a PS1, Line 1017: "Disable HR GSM RTP payload format setting)\n") > Missing NO_STR. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I16804364d95da9e1f5ac3b831c31079a7409e58d Gerrit-Change-Number: 30630 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 15:54:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: gsm_08_58: add IEI to signal HR GSM RTP format via RSL

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/30724 ) Change subject: gsm_08_58: add IEI to signal HR GSM RTP format via RSL ...................................................................... gsm_08_58: add IEI to signal HR GSM RTP format via RSL Change-Id: I843c8a0cbe5898311f3af3294cec7c8bc96c4eb8 Related: OS#5688 --- M include/osmocom/gsm/protocol/gsm_08_58.h M src/gsm/rsl.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/30724/1 diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index 7ccd918..05b6f5d 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -369,6 +369,7 @@ RSL_IE_OSMO_TRAINING_SEQUENCE = 0x61, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP = 0x62, RSL_IE_OSMO_OSMUX_CID = 0x63, + RSL_IE_OSMO_HR_GSM_RTP_FMT = 0x64, /* ip.access */ RSL_IE_IPAC_SRTP_CONFIG = 0xe0, diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c index 3668cea..a4c0053 100644 --- a/src/gsm/rsl.c +++ b/src/gsm/rsl.c @@ -125,6 +125,7 @@ [RSL_IE_OSMO_REP_ACCH_CAP] = { TLV_TYPE_TLV }, [RSL_IE_OSMO_TRAINING_SEQUENCE] = { TLV_TYPE_TLV }, [RSL_IE_OSMO_TEMP_OVP_ACCH_CAP] = { TLV_TYPE_TLV }, + [RSL_IE_OSMO_HR_GSM_RTP_FMT] = { TLV_TYPE_TLV }, [RSL_IE_OSMO_OSMUX_CID] = { TLV_TYPE_TLV }, [RSL_IE_IPAC_SRTP_CONFIG] = { TLV_TYPE_TLV }, [RSL_IE_IPAC_PROXY_UDP] = { TLV_TYPE_FIXED, 2 }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I843c8a0cbe5898311f3af3294cec7c8bc96c4eb8 Gerrit-Change-Number: 30724 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

by pespin

Attention is currently required from: arehbein, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 ) Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/vty/telnet_interface.c: https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/4e471563_8cd037a3 PS3, Line 110: int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port) You missed calling _telnet_init_dynif() in here instead of duplicating code. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Dec 2022 15:52:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-smlc[master]: ctrl: take both address and port from vty config

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/30672 ) Change subject: ctrl: take both address and port from vty config ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/30672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I5d73257c0233ce6772847809a6163b6ca4c88f83 Gerrit-Change-Number: 30672 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 20 Dec 2022 15:51:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

by arehbein

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30703 to look at the new patch set (#3). Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... libosmocore: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 --- M include/osmocom/vty/telnet_interface.h M src/vty/telnet_interface.c 2 files changed, 41 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/30703/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-hlr[master]: ctrl: take both address and port from vty config

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/30665 ) Change subject: ctrl: take both address and port from vty config ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Iecae15333a4e77b38d9bce8c8e591af3d5fcf347 Gerrit-Change-Number: 30665 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 20 Dec 2022 15:50:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022