December 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: llc: fix typo: OSMO_GPRS_LLC_SAPI_SNDCP{12->11}

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30731 ) Change subject: llc: fix typo: OSMO_GPRS_LLC_SAPI_SNDCP{12->11} ...................................................................... llc: fix typo: OSMO_GPRS_LLC_SAPI_SNDCP{12->11} Change-Id: Icee190d0e20044d3808a8b1beb237a987a795d8e Related: OS#5502 --- M include/osmocom/gprs/llc/llc.h M src/llc/llc_pdu.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/31/30731/1 diff --git a/include/osmocom/gprs/llc/llc.h b/include/osmocom/gprs/llc/llc.h index e27fb8a..ff12884 100644 --- a/include/osmocom/gprs/llc/llc.h +++ b/include/osmocom/gprs/llc/llc.h @@ -16,7 +16,7 @@ OSMO_GPRS_LLC_SAPI_SMS = 7, OSMO_GPRS_LLC_SAPI_TOM8 = 8, OSMO_GPRS_LLC_SAPI_SNDCP9 = 9, - OSMO_GPRS_LLC_SAPI_SNDCP12 = 11, + OSMO_GPRS_LLC_SAPI_SNDCP11 = 11, }; extern const struct value_string osmo_gprs_llc_sapi_names[]; diff --git a/src/llc/llc_pdu.c b/src/llc/llc_pdu.c index 5430377..6f0a17f 100644 --- a/src/llc/llc_pdu.c +++ b/src/llc/llc_pdu.c @@ -43,7 +43,7 @@ { OSMO_GPRS_LLC_SAPI_SMS, "SMS" }, { OSMO_GPRS_LLC_SAPI_TOM8, "TOM8" }, { OSMO_GPRS_LLC_SAPI_SNDCP9, "SNDCP9" }, - { OSMO_GPRS_LLC_SAPI_SNDCP12, "SNDCP12" }, + { OSMO_GPRS_LLC_SAPI_SNDCP11, "SNDCP11" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icee190d0e20044d3808a8b1beb237a987a795d8e Gerrit-Change-Number: 30731 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmo-gprs[master]: llc: libosmo-gprs-llc.pc.in: add 'Requires.private: talloc'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30732 ) Change subject: llc: libosmo-gprs-llc.pc.in: add 'Requires.private: talloc' ...................................................................... llc: libosmo-gprs-llc.pc.in: add 'Requires.private: talloc' This is needed for the follow-up patch [1]. Change-Id: Ie8ba61b124585e55accdaf2713b72e3ace78772f Related: [1] I588eb576b2703262f4ab9566ec362920d8390cfd Related: OS#5502 --- M libosmo-gprs-llc.pc.in 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/32/30732/1 diff --git a/libosmo-gprs-llc.pc.in b/libosmo-gprs-llc.pc.in index 8a1ae95..25a6509 100644 --- a/libosmo-gprs-llc.pc.in +++ b/libosmo-gprs-llc.pc.in @@ -7,5 +7,6 @@ Description: C Utility Library Version: @VERSION@ Requires: libosmocore +Requires.private: talloc Libs: -L${libdir} -losmo-gprs-llc Cflags: -I${includedir}/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie8ba61b124585e55accdaf2713b72e3ace78772f Gerrit-Change-Number: 30732 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmo-gprs[master]: llc: add libosmogsm dependency

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30733 ) Change subject: llc: add libosmogsm dependency ...................................................................... llc: add libosmogsm dependency libosmogsm is needed for the follow-up patch [1]. Change-Id: Iee45fb87905ea29df02a48003396bde27e6c550c Related: [1] I588eb576b2703262f4ab9566ec362920d8390cfd Related: OS#5502 --- M configure.ac M contrib/libosmo-gprs.spec.in M libosmo-gprs-llc.pc.in M src/llc/Makefile.am M tests/llc/Makefile.am 5 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/33/30733/1 diff --git a/configure.ac b/configure.ac index 1ebd185..9ceb679 100644 --- a/configure.ac +++ b/configure.ac @@ -32,6 +32,7 @@ dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.7.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/libosmo-gprs.spec.in b/contrib/libosmo-gprs.spec.in index 9c27c2d..b560769 100644 --- a/contrib/libosmo-gprs.spec.in +++ b/contrib/libosmo-gprs.spec.in @@ -11,6 +11,7 @@ BuildRequires: libtool >= 2 BuildRequires: pkgconfig >= 0.20 BuildRequires: pkgconfig(libosmocore) >= 1.7.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.7.0 BuildRequires: pkgconfig(talloc) %description diff --git a/libosmo-gprs-llc.pc.in b/libosmo-gprs-llc.pc.in index 25a6509..7502d95 100644 --- a/libosmo-gprs-llc.pc.in +++ b/libosmo-gprs-llc.pc.in @@ -6,7 +6,7 @@ Name: Osmocom [E]GPRS LLC (Logical Link Control) Library Description: C Utility Library Version: @VERSION@ -Requires: libosmocore +Requires: libosmocore, libosmogsm Requires.private: talloc Libs: -L${libdir} -losmo-gprs-llc Cflags: -I${includedir}/ diff --git a/src/llc/Makefile.am b/src/llc/Makefile.am index 6c0e680..c25841e 100644 --- a/src/llc/Makefile.am +++ b/src/llc/Makefile.am @@ -11,10 +11,12 @@ AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOGSM_CFLAGS) \ $(NULL) AM_LDFLAGS = \ $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOGSM_LIBS) \ $(NULL) lib_LTLIBRARIES = \ @@ -36,4 +38,5 @@ libosmo_gprs_llc_la_LIBADD = \ $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOGSM_LIBS) \ $(NULL) diff --git a/tests/llc/Makefile.am b/tests/llc/Makefile.am index 0079964..2c9d578 100644 --- a/tests/llc/Makefile.am +++ b/tests/llc/Makefile.am @@ -1,6 +1,7 @@ AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOGSM_CFLAGS) \ -I$(top_srcdir)/include/ \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iee45fb87905ea29df02a48003396bde27e6c550c Gerrit-Change-Number: 30733 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmo-gprs[master]: llc: Proper separation of public & private APIs, Introduce llc_prim API

by fixeria

Attention is currently required from: pespin, dexter. fixeria has uploaded a new patch set (#4) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30489 ) Change subject: llc: Proper separation of public & private APIs, Introduce llc_prim API ...................................................................... llc: Proper separation of public & private APIs, Introduce llc_prim API Most of the existing (and added) data structures are kept private, since most of those don't really need to be used outside internal code in the library. Most if not all the interaction from upper and lower layers towards LLC is now done through the new llc_prim pubic interface. This interface is based on 3GPP TS 44.064 section 7.1.2. This commit also implements some of the code paths of the public API by means on importing LLC code from osmo-sgsn.git commit 57b63875c762a784127a13becd1c2549ca6c5454. The import of code cannot be done in a separate commit since existing code in osmo-sgsn.git is low quality and has tons of layer violations in all directions. Hence, this commit aims at being an initial point of having some working LLC stack by means of a few unit tests, but by no means aims to be a total working implementation. Some code paths are missing; bugs are expected at this point. Related: OS#5502 Change-Id: I588eb576b2703262f4ab9566ec362920d8390cfd --- M include/osmocom/gprs/llc/Makefile.am M include/osmocom/gprs/llc/llc.h M include/osmocom/gprs/llc/llc_prim.h A include/osmocom/gprs/llc/llc_private.h M src/llc/Makefile.am A src/llc/llc.c A src/llc/llc_bssgp.c A src/llc/llc_grr.c A src/llc/llc_ll.c A src/llc/llc_llgmm.c M src/llc/llc_pdu.c M src/llc/llc_prim.c M src/llc/llc_xid.c M tests/llc/Makefile.am A tests/llc/llc_prim_test.c A tests/llc/llc_prim_test.err A tests/llc/llc_prim_test.ok M tests/llc/pdu_codec_test.c M tests/llc/pdu_codec_test.ok A tests/llc/xid_codec_test.c A tests/llc/xid_codec_test.err A tests/llc/xid_codec_test.ok M tests/testsuite.at 23 files changed, 2,805 insertions(+), 402 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/89/30489/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I588eb576b2703262f4ab9566ec362920d8390cfd Gerrit-Change-Number: 30489 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: use strtoul() instead of atoi(), detect errors

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30729 ) Change subject: trxcon: use strtoul() instead of atoi(), detect errors ...................................................................... trxcon: use strtoul() instead of atoi(), detect errors Change-Id: I18ec88f1ee30c58d088fe65650d0257b262c1fee --- M src/host/trxcon/src/trxcon_main.c 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/trxcon/src/trxcon_main.c b/src/host/trxcon/src/trxcon_main.c index 95e5549..742246e 100644 --- a/src/host/trxcon/src/trxcon_main.c +++ b/src/host/trxcon/src/trxcon_main.c @@ -188,6 +188,7 @@ static void handle_options(int argc, char **argv) { while (1) { + char *endptr = NULL; int option_index = 0, c; static struct option long_options[] = { {"help", 0, 0, 'h'}, @@ -211,6 +212,8 @@ if (c == -1) break; + errno = 0; + switch (c) { case 'h': print_usage(argv[0]); @@ -227,10 +230,18 @@ app_data.trx_remote_ip = optarg; break; case 'p': - app_data.trx_base_port = atoi(optarg); + app_data.trx_base_port = strtoul(optarg, &endptr, 10); + if (errno || *endptr != '\0') { + fprintf(stderr, "Failed to parse -p/--trx-port=%s\n", optarg); + exit(EXIT_FAILURE); + } break; case 'f': - app_data.trx_fn_advance = atoi(optarg); + app_data.trx_fn_advance = strtoul(optarg, &endptr, 10); + if (errno || *endptr != '\0') { + fprintf(stderr, "Failed to parse -f/--trx-advance=%s\n", optarg); + exit(EXIT_FAILURE); + } break; case 's': app_data.bind_socket = optarg; @@ -239,7 +250,11 @@ app_data.gsmtap_ip = optarg; break; case 'C': - app_data.max_clients = atoi(optarg); + app_data.max_clients = strtoul(optarg, &endptr, 10); + if (errno || *endptr != '\0') { + fprintf(stderr, "Failed to parse -C/--max-clients=%s\n", optarg); + exit(EXIT_FAILURE); + } break; case 'D': app_data.daemonize = 1; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I18ec88f1ee30c58d088fe65650d0257b262c1fee Gerrit-Change-Number: 30729 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: allow extending FBSB timeout (quirks for slow PHYs)

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30612 ) Change subject: trxcon: allow extending FBSB timeout (quirks for slow PHYs) ...................................................................... trxcon: allow extending FBSB timeout (quirks for slow PHYs) This is needed for SDR based PHYs, because for them it takes longer to tune, flush the buffers and so on. Add a field to the trxcon_inst structure and a command line option (-F) for the trxcon app. Change-Id: Ia68954c5bdacda45fc871ffea0ccdf2460936408 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/trxcon_fsm.c M src/host/trxcon/src/trxcon_inst.c M src/host/trxcon/src/trxcon_main.c 4 files changed, 27 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h index 9148771..15e63f7 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h @@ -32,6 +32,12 @@ uint8_t tx_power; int8_t ta; } l1p; + + /* PHY specific quirks */ + struct { + /* FBSB timeout extension (in TDMA FNs) */ + unsigned int fbsb_extend_fns; + } phy_quirks; }; enum trxcon_log_cat { diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index 10663b1..11b60ac 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -164,9 +164,11 @@ case TRXCON_EV_FBSB_SEARCH_REQ: { const struct trxcon_param_fbsb_search_req *req = data; - unsigned long timeout_ms; + unsigned long timeout_fns, timeout_ms; - timeout_ms = req->timeout_fns * GSM_TDMA_FN_DURATION_uS / 1000; + /* Some PHYs need additional time to tune (in TDMA FNs) */ + timeout_fns = req->timeout_fns + trxcon->phy_quirks.fbsb_extend_fns; + timeout_ms = timeout_fns * GSM_TDMA_FN_DURATION_uS / 1000; osmo_fsm_inst_state_chg_ms(fi, TRXCON_ST_FBSB_SEARCH, timeout_ms, 0); l1sched_configure_ts(trxcon->sched, 0, req->pchan_config); diff --git a/src/host/trxcon/src/trxcon_inst.c b/src/host/trxcon/src/trxcon_inst.c index 7d3813e..da4d618 100644 --- a/src/host/trxcon/src/trxcon_inst.c +++ b/src/host/trxcon/src/trxcon_inst.c @@ -91,6 +91,8 @@ return NULL; } + trxcon->phy_quirks.fbsb_extend_fns = 0; + return trxcon; } diff --git a/src/host/trxcon/src/trxcon_main.c b/src/host/trxcon/src/trxcon_main.c index 742246e..26a5742 100644 --- a/src/host/trxcon/src/trxcon_main.c +++ b/src/host/trxcon/src/trxcon_main.c @@ -67,6 +67,9 @@ uint16_t trx_base_port; uint32_t trx_fn_advance; + /* PHY quirk: FBSB timeout extension (in TDMA FNs) */ + unsigned int phyq_fbsb_extend_fns; + /* GSMTAP specific */ struct gsmtap_inst *gsmtap; const char *gsmtap_ip; @@ -77,6 +80,7 @@ .trx_bind_ip = "0.0.0.0", .trx_base_port = 6700, .trx_fn_advance = 3, + .phyq_fbsb_extend_fns = 0, }; static void *tall_trxcon_ctx = NULL; @@ -153,6 +157,7 @@ } trxcon->gsmtap = app_data.gsmtap; + trxcon->phy_quirks.fbsb_extend_fns = app_data.phyq_fbsb_extend_fns; } static void l1ctl_conn_close_cb(struct l1ctl_client *l1c) @@ -179,6 +184,7 @@ printf(" -i --trx-remote TRX remote IP address (default 127.0.0.1)\n"); printf(" -p --trx-port Base port of TRX instance (default 6700)\n"); printf(" -f --trx-advance Uplink burst scheduling advance (default 3)\n"); + printf(" -F --fbsb-extend FBSB timeout extension (in TDMA FNs, default 0)\n"); printf(" -s --socket Listening socket for layer23 (default /tmp/osmocom_l2)\n"); printf(" -g --gsmtap-ip The destination IP used for GSMTAP (disabled by default)\n"); printf(" -C --max-clients Maximum number of L1CTL connections (default 1)\n"); @@ -201,13 +207,14 @@ {"trx-remote", 1, 0, 'i'}, {"trx-port", 1, 0, 'p'}, {"trx-advance", 1, 0, 'f'}, + {"fbsb-extend", 1, 0, 'F'}, {"gsmtap-ip", 1, 0, 'g'}, {"max-clients", 1, 0, 'C'}, {"daemonize", 0, 0, 'D'}, {0, 0, 0, 0} }; - c = getopt_long(argc, argv, "d:b:i:p:f:s:g:C:Dh", + c = getopt_long(argc, argv, "d:b:i:p:f:F:s:g:C:Dh", long_options, &option_index); if (c == -1) break; @@ -243,6 +250,13 @@ exit(EXIT_FAILURE); } break; + case 'F': + app_data.phyq_fbsb_extend_fns = strtoul(optarg, &endptr, 10); + if (errno || *endptr != '\0') { + fprintf(stderr, "Failed to parse -F/--fbsb-extend=%s\n", optarg); + exit(EXIT_FAILURE); + } + break; case 's': app_data.bind_socket = optarg; break; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia68954c5bdacda45fc871ffea0ccdf2460936408 Gerrit-Change-Number: 30612 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: allow extending FBSB timeout (quirks for slow PHYs)

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30612 ) Change subject: trxcon: allow extending FBSB timeout (quirks for slow PHYs) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia68954c5bdacda45fc871ffea0ccdf2460936408 Gerrit-Change-Number: 30612 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Dec 2022 19:58:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: use strtoul() instead of atoi(), detect errors

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30729 ) Change subject: trxcon: use strtoul() instead of atoi(), detect errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I18ec88f1ee30c58d088fe65650d0257b262c1fee Gerrit-Change-Number: 30729 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 19:58:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: allow extending FBSB timeout (quirks for slow PHYs)

by Hoernchen

Attention is currently required from: laforge, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30612 ) Change subject: trxcon: allow extending FBSB timeout (quirks for slow PHYs) ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia68954c5bdacda45fc871ffea0ccdf2460936408 Gerrit-Change-Number: 30612 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 19:58:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: use strtoul() instead of atoi(), detect errors

by Hoernchen

Attention is currently required from: fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30729 ) Change subject: trxcon: use strtoul() instead of atoi(), detect errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I18ec88f1ee30c58d088fe65650d0257b262c1fee Gerrit-Change-Number: 30729 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 19:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022