December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: rsl.adoc: add info about RSL_IE_OSMO_REP_ACCH_CAP

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/30728 ) Change subject: rsl.adoc: add info about RSL_IE_OSMO_REP_ACCH_CAP ...................................................................... rsl.adoc: add info about RSL_IE_OSMO_REP_ACCH_CAP Change-Id: I1d40f688ad1729efffee846e7f9efd06cf64ce28 Related: OS#5688 --- M doc/manuals/abis/rsl.adoc 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/30728/1 diff --git a/doc/manuals/abis/rsl.adoc b/doc/manuals/abis/rsl.adoc index ab1d5e7..2f8edbb 100644 --- a/doc/manuals/abis/rsl.adoc +++ b/doc/manuals/abis/rsl.adoc @@ -864,6 +864,7 @@ | 0x01 | RSL_IE_CHAN_NR | <<RSL_IE_CHAN_NR>> | 0x60 | RSL_IE_OSMO_REP_ACCH_CAP | <<RSL_IE_OSMO_REP_ACCH_CAP>> | 0x61 | RSL_IE_OSMO_TRAINING_SEQUENCE | <<RSL_IE_OSMO_TRAINING_SEQUENCE>> +| 0x64 | RSL_IE_OSMO_HR_GSM_RTP_FMT | <<RSL_IE_OSMO_HR_GSM_RTP_FMT>> | 0xf0 | RSL_IE_IPAC_REMOTE_IP | <<RSL_IE_IPAC_REMOTE_IP>> | 0xf1 | RSL_IE_IPAC_REMOTE_PORT | <<RSL_IE_IPAC_REMOTE_PORT>> | 0xf3 | RSL_IE_IPAC_LOCAL_PORT | <<RSL_IE_IPAC_LOCAL_PORT>> @@ -1085,6 +1086,25 @@ | 8..255 | reserved values |=== +[[RSL_IE_OSMO_HR_GSM_RTP_FMT]] +==== RSL_IE_OSMO_HR_GSM_RTP_FMT + +This one byte length TLV IE is used to select the RTP payload format for HR GSM during +Channel Activation and Mode Modify. + +There are two different RTP payload formats defined for HR GSM (RFC 5993 and TS 101.318). +On the receiving side (Downlink) osmoBTS will always accept both formats. The format +used on the transmitting side (Uplink) depends on the BTS model unless it is explicitly +specified using the RSL IE mentioned above. + +[options="header"] +|=== +| *bit* | 7 - 1 | 0 +| byte at offset 0 | (reserved) | 0 = TS 101.318, 1 = RFC 5993 +|=== + +(Bits 7 - 1 are reserved for future use and must be set to zero.) + === A-bis RSL Initialization / BTS bring-up Upon receiving the 'IPA RSL CONNECT' OML message by the respective -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1d40f688ad1729efffee846e7f9efd06cf64ce28 Gerrit-Change-Number: 30728 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-e1-recorder[master]: Add git-review config

by pespin

Attention is currently required from: arehbein, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30727 ) Change subject: Add git-review config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I4ce3f6806fed00c452d859c164a42a4f9f3f7d1f Gerrit-Change-Number: 30727 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:25:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-mgw[master]: ctrl: take both address and port from vty config

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30666 ) Change subject: ctrl: take both address and port from vty config ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id053bc02e0a6359e52a0f5e110128d3bb87ed151 Gerrit-Change-Number: 30666 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:25:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

by pespin

Attention is currently required from: arehbein, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 ) Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Forgot to say. the title for the commit is too generic, doesn't explain what they do. What about: "Deprecate APIs telnet_init(_dynip)()" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:25:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: gsm_08_58: add IEI to signal HR GSM RTP format via RSL

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30724 ) Change subject: gsm_08_58: add IEI to signal HR GSM RTP format via RSL ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Some context on why is this needed in the commit description would be great. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I843c8a0cbe5898311f3af3294cec7c8bc96c4eb8 Gerrit-Change-Number: 30724 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:21:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-e1-recorder[master]: Add git-review config

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30727 ) Change subject: Add git-review config ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I4ce3f6806fed00c452d859c164a42a4f9f3f7d1f Gerrit-Change-Number: 30727 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 16:06:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-mgw[master]: ctrl: take both address and port from vty config

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30666 ) Change subject: ctrl: take both address and port from vty config ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id053bc02e0a6359e52a0f5e110128d3bb87ed151 Gerrit-Change-Number: 30666 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 20 Dec 2022 16:01:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

by arehbein

Attention is currently required from: laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 ) Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 4: (2 comments) File src/vty/telnet_interface.c: https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/6ff617a5_cb97322a PS2, Line 71: #pragma GCC diagnostic push > I suppose so Done File src/vty/telnet_interface.c: https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/f864ca37_e943a752 PS3, Line 110: int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port) > You missed calling _telnet_init_dynif() in here instead of duplicating code. yeah thanks for the heads up, noticed it looking at my patchset -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 15:57:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: ctrl: take both address and port from vty config

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30662 ) Change subject: ctrl: take both address and port from vty config ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic2c56ffee6237333d919c72bf26076ac24a1fa52 Gerrit-Change-Number: 30662 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 20 Dec 2022 15:56:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bts[master]: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30726 ) Change subject: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2139): https://gerrit.osmocom.org/c/osmo-bts/+/30726/comment/4678b222_c7083986 PS1, Line 1633: } else if (TLVP_VAL(tp, RSL_IE_OSMO_HR_GSM_RTP_FMT)[0] == 0x01) { please, no space before tabs -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id53ebebdf987fc59cf4e38bcddb75663fd7bb8fc Gerrit-Change-Number: 30726 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 20 Dec 2022 15:55:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022