November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: UPF_Tests: adjust to rename 'endecaps' to 'tunend'

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30259 ) Change subject: UPF_Tests: adjust to rename 'endecaps' to 'tunend' ...................................................................... UPF_Tests: adjust to rename 'endecaps' to 'tunend' osmo-upf has changed the naming of GTP action kinds, need to adjust the test here to avoid failing tests. Related: I49ac7b1f8b5b74f586edfed1dfb29f9af55a521b (osmo-upf) Change-Id: I6fe4a4cf02ca05b772491d11a5edbdbd7b0b429a --- M upf/UPF_Tests.ttcn 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index ca1a0f6..fb4ef08 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -163,6 +163,7 @@ } type record GTP_Action { + /* kind = ("tunend"|"tunmap") */ charstring kind, charstring gtp_access_ip, OCT4 teid_access_r, @@ -629,7 +630,7 @@ } /* Return a rule set that does GTP encapsulation/decapsulation */ -private function f_ruleset_endecaps(GTP_Action gtp) return PFCP_Ruleset +private function f_ruleset_tunend(GTP_Action gtp) return PFCP_Ruleset { var PFCP_Ruleset rules := { {}, {} }; f_ruleset_add_GTP_decaps(rules, ts_PFCP_F_TEID_ipv4(gtp.teid_access_l, gtp.gtp_access_ip)); @@ -655,7 +656,7 @@ up_seid := -, cp_seid := f_next_seid(), gtp := { - kind := "endecaps", + kind := "tunend", gtp_access_ip := "127.0.0.2", teid_access_r := f_next_remote_teid(), teid_access_l := f_next_local_teid(), @@ -671,7 +672,7 @@ private function f_session_est_default() runs on CPF_ConnHdlr return PFCP_session { var PFCP_session s := f_create_PFCP_session(); - f_session_est(s, f_ruleset_endecaps(s.gtp)); + f_session_est(s, f_ruleset_tunend(s.gtp)); return s; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6fe4a4cf02ca05b772491d11a5edbdbd7b0b429a Gerrit-Change-Number: 30259 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: UPF_Tests: adjust to rename 'endecaps' to 'tunend'

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30259 ) Change subject: UPF_Tests: adjust to rename 'endecaps' to 'tunend' ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: another test fallout fix after osmo-upf changed the naming -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6fe4a4cf02ca05b772491d11a5edbdbd7b0b429a Gerrit-Change-Number: 30259 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 16:21:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: vty: revert rename of 'show gtp'

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30258 ) Change subject: vty: revert rename of 'show gtp' ...................................................................... vty: revert rename of 'show gtp' Rename 'show tunend' back to 'show gtp'. Clarify the VTY doc. While renaming 'gtp' to 'tunend', i also renamed the general 'show gtp' VTY command by accident / by misunderstanding. This command shows all GTP tunnel state, not just the tunend state. Reverts a small portion of commit "VTY: rename 'gtp' to 'tunend'" 95eb2c6a8949b3c0971e5c7d7a743bc72dffc4a6 I49ac7b1f8b5b74f586edfed1dfb29f9af55a521b Change-Id: I8f619d4ddda3efffb62cf594878d3166cb37fe45 --- M src/osmo-upf/upf_vty.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: neels: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-upf/upf_vty.c b/src/osmo-upf/upf_vty.c index f92ab05..f57429c 100644 --- a/src/osmo-upf/upf_vty.c +++ b/src/osmo-upf/upf_vty.c @@ -286,10 +286,10 @@ return CMD_SUCCESS; } -DEFUN(show_tunend, show_tunend_cmd, - "show tunend", +DEFUN(show_gtp, show_gtp_cmd, + "show gtp", SHOW_STR - "Active GTP tunnels and forwardings\n") + "Active GTP tunnels, both tunend and tunmap\n") { struct up_peer *peer; int count = 0; @@ -351,7 +351,7 @@ OSMO_ASSERT(g_upf != NULL); install_element_ve(&show_pdr_cmd); - install_element_ve(&show_tunend_cmd); + install_element_ve(&show_gtp_cmd); install_element_ve(&show_session_cmd); install_node(&cfg_pfcp_node, config_write_pfcp); -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I8f619d4ddda3efffb62cf594878d3166cb37fe45 Gerrit-Change-Number: 30258 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: UPF_Tests: adjust to rename 'endecaps' to 'tunend'

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30259 ) Change subject: UPF_Tests: adjust to rename 'endecaps' to 'tunend' ...................................................................... UPF_Tests: adjust to rename 'endecaps' to 'tunend' osmo-upf has changed the naming of GTP action kinds, need to adjust the test here to avoid failing tests. Related: I49ac7b1f8b5b74f586edfed1dfb29f9af55a521b (osmo-upf) Change-Id: I6fe4a4cf02ca05b772491d11a5edbdbd7b0b429a --- M upf/UPF_Tests.ttcn 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/30259/1 diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index ca1a0f6..fb4ef08 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -163,6 +163,7 @@ } type record GTP_Action { + /* kind = ("tunend"|"tunmap") */ charstring kind, charstring gtp_access_ip, OCT4 teid_access_r, @@ -629,7 +630,7 @@ } /* Return a rule set that does GTP encapsulation/decapsulation */ -private function f_ruleset_endecaps(GTP_Action gtp) return PFCP_Ruleset +private function f_ruleset_tunend(GTP_Action gtp) return PFCP_Ruleset { var PFCP_Ruleset rules := { {}, {} }; f_ruleset_add_GTP_decaps(rules, ts_PFCP_F_TEID_ipv4(gtp.teid_access_l, gtp.gtp_access_ip)); @@ -655,7 +656,7 @@ up_seid := -, cp_seid := f_next_seid(), gtp := { - kind := "endecaps", + kind := "tunend", gtp_access_ip := "127.0.0.2", teid_access_r := f_next_remote_teid(), teid_access_l := f_next_local_teid(), @@ -671,7 +672,7 @@ private function f_session_est_default() runs on CPF_ConnHdlr return PFCP_session { var PFCP_session s := f_create_PFCP_session(); - f_session_est(s, f_ruleset_endecaps(s.gtp)); + f_session_est(s, f_ruleset_tunend(s.gtp)); return s; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6fe4a4cf02ca05b772491d11a5edbdbd7b0b429a Gerrit-Change-Number: 30259 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: vty: revert rename of 'show gtp'

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30258 ) Change subject: vty: revert rename of 'show gtp' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I8f619d4ddda3efffb62cf594878d3166cb37fe45 Gerrit-Change-Number: 30258 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 16:14:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: vty: revert rename of 'show gtp'

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30258 ) Change subject: vty: revert rename of 'show gtp' ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: fast track this, to revert a change that causes ttcn3-upf-test fallout -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I8f619d4ddda3efffb62cf594878d3166cb37fe45 Gerrit-Change-Number: 30258 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 15:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: vty: revert rename of 'show gtp'

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/30258 ) Change subject: vty: revert rename of 'show gtp' ...................................................................... vty: revert rename of 'show gtp' Rename 'show tunend' back to 'show gtp'. Clarify the VTY doc. While renaming 'gtp' to 'tunend', i also renamed the general 'show gtp' VTY command by accident / by misunderstanding. This command shows all GTP tunnel state, not just the tunend state. Reverts a small portion of commit "VTY: rename 'gtp' to 'tunend'" 95eb2c6a8949b3c0971e5c7d7a743bc72dffc4a6 I49ac7b1f8b5b74f586edfed1dfb29f9af55a521b Change-Id: I8f619d4ddda3efffb62cf594878d3166cb37fe45 --- M src/osmo-upf/upf_vty.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/58/30258/1 diff --git a/src/osmo-upf/upf_vty.c b/src/osmo-upf/upf_vty.c index f92ab05..f57429c 100644 --- a/src/osmo-upf/upf_vty.c +++ b/src/osmo-upf/upf_vty.c @@ -286,10 +286,10 @@ return CMD_SUCCESS; } -DEFUN(show_tunend, show_tunend_cmd, - "show tunend", +DEFUN(show_gtp, show_gtp_cmd, + "show gtp", SHOW_STR - "Active GTP tunnels and forwardings\n") + "Active GTP tunnels, both tunend and tunmap\n") { struct up_peer *peer; int count = 0; @@ -351,7 +351,7 @@ OSMO_ASSERT(g_upf != NULL); install_element_ve(&show_pdr_cmd); - install_element_ve(&show_tunend_cmd); + install_element_ve(&show_gtp_cmd); install_element_ve(&show_session_cmd); install_node(&cfg_pfcp_node, config_write_pfcp); -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I8f619d4ddda3efffb62cf594878d3166cb37fe45 Gerrit-Change-Number: 30258 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: layer23/mobile: Add missing dependency cflags

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30257 ) Change subject: layer23/mobile: Add missing dependency cflags ...................................................................... layer23/mobile: Add missing dependency cflags The *_LIBS vars were already added, but the *_CFLAGS were missing. Change-Id: If904589b33357395e10f078857979aaecf5dbf68 --- M src/host/layer23/src/mobile/Makefile.am 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/30257/1 diff --git a/src/host/layer23/src/mobile/Makefile.am b/src/host/layer23/src/mobile/Makefile.am index 8fefdfa..3db27b7 100644 --- a/src/host/layer23/src/mobile/Makefile.am +++ b/src/host/layer23/src/mobile/Makefile.am @@ -6,7 +6,9 @@ AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ + $(LIBOSMOCODEC_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(LIBLUA_CFLAGS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If904589b33357395e10f078857979aaecf5dbf68 Gerrit-Change-Number: 30257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: pfcp_test: add missing 'pdi_present = true'

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30247 ) Change subject: pfcp_test: add missing 'pdi_present = true' ...................................................................... pfcp_test: add missing 'pdi_present = true' test_enc_dec[8] includes a PDI IE in Update PDR. The PDI is optional here, so it requires setting a presence flag to true. This was missing, hence the PDI part was not being tested at all. Add this presence flag. This was probably a copy-paste error from testing the Create PDR IE, where the PDI is mandatory and has no presence flag. Change-Id: Idc70ae23f15d3af65f98557cc51a111f2e6d75c9 --- M tests/libosmo-pfcp/pfcp_test.c M tests/libosmo-pfcp/pfcp_test.ok 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/tests/libosmo-pfcp/pfcp_test.c b/tests/libosmo-pfcp/pfcp_test.c index d6853b1..b204a9f 100644 --- a/tests/libosmo-pfcp/pfcp_test.c +++ b/tests/libosmo-pfcp/pfcp_test.c @@ -344,6 +344,7 @@ .upd_pdr = { { .pdr_id = 1, + .pdi_present = true, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_ACCESS, .local_f_teid_present = true, diff --git a/tests/libosmo-pfcp/pfcp_test.ok b/tests/libosmo-pfcp/pfcp_test.ok index 2b8cc1a..23ce16d 100644 --- a/tests/libosmo-pfcp/pfcp_test.ok +++ b/tests/libosmo-pfcp/pfcp_test.ok @@ -89,10 +89,10 @@ === start test_enc_dec[8] encoding: SESSION_MOD_REQ -PFCPv1 SESSION_MOD_REQ hdr={seq=9 SEID=0x0} ies={ 'Remove PDR'={ { 'PDR ID'=1 } } 'Remove FAR'={ { 'FAR ID'=1 } } 'Create PDR'={ { 'PDR ID'=3 'Precedence'=255 'PDI'={ 'Source Interface'=Access 'F-TEID'=CHOOSE-v4 } 'Outer Header Removal'=GTP_U_UDP_IPV4 'FAR ID'=3 } } 'Create FAR'={ { 'FAR ID'=3 'Apply Action'=( FORW ) 'Forwarding Parameters'={ 'Destination Interface'=Access 'Outer Header Creation'=( GTP_U_UDP_IPV4 ),TEID:0xabcdef,v4:10.9.8.7 } } } 'Update PDR'={ { 'PDR ID'=1 'Outer Header Removal'=GTP_U_UDP_IPV4 'FAR ID'=1 } } 'Update FAR'={ { 'FAR ID'=1 'Update Forwarding Parameters'={ 'Network Instance'="internet" } } } } +PFCPv1 SESSION_MOD_REQ hdr={seq=9 SEID=0x0} ies={ 'Remove PDR'={ { 'PDR ID'=1 } } 'Remove FAR'={ { 'FAR ID'=1 } } 'Create PDR'={ { 'PDR ID'=3 'Precedence'=255 'PDI'={ 'Source Interface'=Access 'F-TEID'=CHOOSE-v4 } 'Outer Header Removal'=GTP_U_UDP_IPV4 'FAR ID'=3 } } 'Create FAR'={ { 'FAR ID'=3 'Apply Action'=( FORW ) 'Forwarding Parameters'={ 'Destination Interface'=Access 'Outer Header Creation'=( GTP_U_UDP_IPV4 ),TEID:0xabcdef,v4:10.9.8.7 } } } 'Update PDR'={ { 'PDR ID'=1 'Outer Header Removal'=GTP_U_UDP_IPV4 'PDI'={ 'Source Interface'=Access 'F-TEID'=CHOOSE-v4 } 'FAR ID'=1 } } 'Update FAR'={ { 'FAR ID'=1 'Update Forwarding Parameters'={ 'Network Instance'="internet" } } } } osmo_pfcp_msg_encode() rc = 0 -21 34 00 ab 00 00 00 00 00 00 00 00 00 00 09 00 00 0f 00 06 00 38 00 02 00 01 00 10 00 08 00 6c 00 04 00 00 00 01 00 01 00 29 00 38 00 02 00 03 00 1d 00 04 00 00 00 ff 00 02 00 0a 00 14 00 01 00 00 15 00 01 05 00 5f 00 01 00 00 6c 00 04 00 00 00 03 00 03 00 25 00 6c 00 04 00 00 00 03 00 2c 00 02 02 00 00 04 00 13 00 2a 00 01 00 00 54 00 0a 01 00 00 ab cd ef 0a 09 08 07 00 09 00 13 00 38 00 02 00 01 00 5f 00 01 00 00 6c 00 04 00 00 00 01 00 0a 00 18 00 6c 00 04 00 00 00 01 00 0b 00 0c 00 16 00 08 69 6e 74 65 72 6e 65 74 . -osmo_pfcp_msg_decode_header() rc = 175 +21 34 00 b9 00 00 00 00 00 00 00 00 00 00 09 00 00 0f 00 06 00 38 00 02 00 01 00 10 00 08 00 6c 00 04 00 00 00 01 00 01 00 29 00 38 00 02 00 03 00 1d 00 04 00 00 00 ff 00 02 00 0a 00 14 00 01 00 00 15 00 01 05 00 5f 00 01 00 00 6c 00 04 00 00 00 03 00 03 00 25 00 6c 00 04 00 00 00 03 00 2c 00 02 02 00 00 04 00 13 00 2a 00 01 00 00 54 00 0a 01 00 00 ab cd ef 0a 09 08 07 00 09 00 21 00 38 00 02 00 01 00 5f 00 01 00 00 02 00 0a 00 14 00 01 00 00 15 00 01 05 00 6c 00 04 00 00 00 01 00 0a 00 18 00 6c 00 04 00 00 00 01 00 0b 00 0c 00 16 00 08 69 6e 74 65 72 6e 65 74 . +osmo_pfcp_msg_decode_header() rc = 189 rc == msgb_length() osmo_pfcp_msg_decode_tlv() rc = 0 parsed == orig -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Idc70ae23f15d3af65f98557cc51a111f2e6d75c9 Gerrit-Change-Number: 30247 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: pfcp_test: init logging, for PFCP errors

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30246 ) Change subject: pfcp_test: init logging, for PFCP errors ...................................................................... pfcp_test: init logging, for PFCP errors Initialize logging so that potential errors are shown by the test. Normally, pfcp_test does not cause any logging. However, I encountered a linking problem, which caused error logging from libosmo-pfcp, which was not shown because osmo logging aborted the program first. Change-Id: I32a99d27ff72edceacb2cf4f4cd996650bc10710 --- M tests/libosmo-pfcp/pfcp_test.c 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/tests/libosmo-pfcp/pfcp_test.c b/tests/libosmo-pfcp/pfcp_test.c index b0f3a50..d6853b1 100644 --- a/tests/libosmo-pfcp/pfcp_test.c +++ b/tests/libosmo-pfcp/pfcp_test.c @@ -500,13 +500,32 @@ } } +static const struct log_info_cat log_categories[] = { +}; + +const struct log_info log_info = { + .cat = log_categories, + .num_cat = ARRAY_SIZE(log_categories), +}; + int main(int argc, char **argv) { ctx = talloc_named_const(NULL, 0, "pfcp_test"); msgb_talloc_ctx_init(ctx, 0); + /* If libosmo-pfcp encounters encoding/decoding errors, it causes logging in DLPFCP. */ + osmo_init_logging2(ctx, &log_info); + log_set_print_category_hex(osmo_stderr_target, 0); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_level(osmo_stderr_target, 1); + log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); + log_set_print_timestamp(osmo_stderr_target, 0); + log_set_print_extended_timestamp(osmo_stderr_target, 0); + test_enc_dec(); + log_fini(); + talloc_free(ctx); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I32a99d27ff72edceacb2cf4f4cd996650bc10710 Gerrit-Change-Number: 30246 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022