November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-pfcp[master]: pfcp_test: init logging, for PFCP errors

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30246 ) Change subject: pfcp_test: init logging, for PFCP errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I32a99d27ff72edceacb2cf4f4cd996650bc10710 Gerrit-Change-Number: 30246 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 15:21:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: PFCP: add Network Instance IE in PDI IE

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30248 ) Change subject: PFCP: add Network Instance IE in PDI IE ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I162299e70b4fb0c3fef8039d693ac7d3fe4df16a Gerrit-Change-Number: 30248 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 15:11:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: pfcp_test: fix order of dependencies

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30256 ) Change subject: pfcp_test: fix order of dependencies ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I63880c1b4f326687ce9a35584a55742c1016d72b Gerrit-Change-Number: 30256 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 15:10:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: PFCP: add Network Instance IE in PDI IE

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30248 ) Change subject: PFCP: add Network Instance IE in PDI IE ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I162299e70b4fb0c3fef8039d693ac7d3fe4df16a Gerrit-Change-Number: 30248 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 21 Nov 2022 15:04:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: pfcp_test: fix order of dependencies

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30256 ) Change subject: pfcp_test: fix order of dependencies ...................................................................... pfcp_test: fix order of dependencies When LIBOSMOCORE_LIBS comes before locally built libs, for some reason libtool puts system lib/ first in LD_LIBRARY_PATH, leading to ABI breakage in pfcp_test when an older libosmo-pfcp is still installed. Change-Id: I63880c1b4f326687ce9a35584a55742c1016d72b --- M tests/libosmo-pfcp/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/56/30256/1 diff --git a/tests/libosmo-pfcp/Makefile.am b/tests/libosmo-pfcp/Makefile.am index 6f3eca1..bd18d06 100644 --- a/tests/libosmo-pfcp/Makefile.am +++ b/tests/libosmo-pfcp/Makefile.am @@ -22,9 +22,9 @@ $(NULL) pfcp_test_LDADD = \ - $(LIBOSMOCORE_LIBS) \ $(top_builddir)/src/libosmo-pfcp/libosmo-pfcp.la \ $(top_builddir)/src/libosmo-gtlv/libosmo-gtlv.la \ + $(LIBOSMOCORE_LIBS) \ $(NULL) .PHONY: update_exp -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I63880c1b4f326687ce9a35584a55742c1016d72b Gerrit-Change-Number: 30256 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: make burst pointer in trxcon_phyif_burst_ind const

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30254 ) Change subject: trxcon: make burst pointer in trxcon_phyif_burst_ind const ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30254/comment/b1342487_a14a24aa PS1, Line 658: sbit_t *burst = (sbit_t *)&buf[8]; > To clarify things further: […] I simply meant moving the for loop before the "bi = { ... }" block, so that first the buf is modified,and then it is assigned const to the field where it will be used from now on. Hope that makes sense to you too. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I68773d247725a6dc2cbbc58b63c0fd19ffdb1a16 Gerrit-Change-Number: 30254 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 14:52:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: make burst pointer in trxcon_phyif_burst_ind const

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30254 ) Change subject: trxcon: make burst pointer in trxcon_phyif_burst_ind const ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30254/comment/af7ae5a1_400b9ea1 PS1, Line 658: sbit_t *burst = (sbit_t *)&buf[8]; > Ah I see what you mean. […] To clarify things further: * This function has a static buffer buf[], which is used for read()ing TRXD datagrams from socket. Obviously, it cannot be const here. * This function needs to convert from usbits to sbits, so within the loop I am casting from (uint8_t *) to (sbit_t *). * The upper layers get (const sbit_t *) via bi->burst. I can move this *burst outside of the loop if this makes things cleaner. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I68773d247725a6dc2cbbc58b63c0fd19ffdb1a16 Gerrit-Change-Number: 30254 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 14:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: make burst pointer in trxcon_phyif_burst_ind const

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30254 ) Change subject: trxcon: make burst pointer in trxcon_phyif_burst_ind const ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30254/comment/16d42b1e_b3faaea2 PS1, Line 658: sbit_t *burst = (sbit_t *)&buf[8]; > I am not making the buf[] const. Ah I see what you mean. Still it looks a bit weird to asign a buffer as a const pointer somewhere, and later on modifying that pointer. Would feel a lot less strange if you edited the buffer before assigning it as a const pointer IMHO. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I68773d247725a6dc2cbbc58b63c0fd19ffdb1a16 Gerrit-Change-Number: 30254 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 13:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: SMPP: make smpp_smsc_stop() static

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30255 ) Change subject: SMPP: make smpp_smsc_stop() static ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3d0d850ffe6ebf9d623c1f250d4293a3c427d5d8 Gerrit-Change-Number: 30255 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 21 Nov 2022 13:39:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: libosmonetify SMPP

by pespin

Attention is currently required from: laforge, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 ) Change subject: libosmonetify SMPP ...................................................................... Patch Set 59: (1 comment) File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/5f2505fa_087da461 PS49, Line 851: static int esme_link_close_cb(struct osmo_stream_srv *conn) > Could you formulate them as unit/ttcn3 test? That would be most helpful. Simply give a look at the code. For instance: esme_destroy() osmo_stream_srv_destroy() esme_link_close_cb() smpp_esme_put() esme_destroy() -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 59 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 13:39:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022