November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: rework l1sched_trigger(), split l1sched_pull_burst()

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30239 ) Change subject: trxcon: rework l1sched_trigger(), split l1sched_pull_burst() ...................................................................... Patch Set 3: (1 comment) File src/host/trxcon/src/sched_clck.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30239/comment/ea1ac6f7_e2699408 PS2, Line 47: #define l1sched_trigger_all_advance(sched) \ > Agree with Max, I think you are at least missing explaining a bit the context of this change and wha […] Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibb7f9d7de26733f21b0753a2c655a250286bf1f0 Gerrit-Change-Number: 30239 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 20:26:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: rework l1sched_trigger(), split l1sched_pull_burst()

by fixeria

Attention is currently required from: fixeria, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30239 to look at the new patch set (#3). Change subject: trxcon: rework l1sched_trigger(), split l1sched_pull_burst() ...................................................................... trxcon: rework l1sched_trigger(), split l1sched_pull_burst() The key idea is to allow triggering the scheduler only for a specific timeslot of a frame, while keeping the API for triggering all together. Split off the main part from l1sched_trigger() to l1sched_pull_burst(). While at it, rename l1sched_trigger() to l1sched_pull_send_frame(). Change-Id: Ibb7f9d7de26733f21b0753a2c655a250286bf1f0 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/src/sched_clck.c M src/host/trxcon/src/sched_trx.c 3 files changed, 85 insertions(+), 81 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/39/30239/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibb7f9d7de26733f21b0753a2c655a250286bf1f0 Gerrit-Change-Number: 30239 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: adjust coding style in l1sched_pull_burst()

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30240 to look at the new patch set (#3). Change subject: trxcon: adjust coding style in l1sched_pull_burst() ...................................................................... trxcon: adjust coding style in l1sched_pull_burst() Change-Id: I96a40fdbea5085999b9aeb98b418ae27132f6fda Related: OS#5599 --- M src/host/trxcon/src/sched_trx.c 1 file changed, 14 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/30240/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I96a40fdbea5085999b9aeb98b418ae27132f6fda Gerrit-Change-Number: 30240 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: implement Ready-to-Send PHYIF API

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30241 to look at the new patch set (#4). Change subject: trxcon: implement Ready-to-Send PHYIF API ...................................................................... trxcon: implement Ready-to-Send PHYIF API This API is going to be used by osmo-trx-ms for pulling Uplink bursts from the scheduler in a synchronous way, without relying on the timer driven libtrxcon's internal scheduler. Change-Id: Ic8f74413f5fad277340e007dd4296f890155a2c1 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/trxcon/phyif.h M src/host/trxcon/src/trxcon_shim.c 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/41/30241/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic8f74413f5fad277340e007dd4296f890155a2c1 Gerrit-Change-Number: 30241 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: make burst pointer in trxcon_phyif_burst_ind const

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30254 to look at the new patch set (#2). Change subject: trxcon: make burst pointer in trxcon_phyif_burst_ind const ...................................................................... trxcon: make burst pointer in trxcon_phyif_burst_ind const The trx_data_rx_cb() needs to be modified because it's accessing and modifying the receive buffer via the bi.burst pointer, which becomes const after this patch. Change-Id: I68773d247725a6dc2cbbc58b63c0fd19ffdb1a16 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/trxcon/phyif.h M src/host/trxcon/src/trx_if.c 2 files changed, 13 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/54/30254/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I68773d247725a6dc2cbbc58b63c0fd19ffdb1a16 Gerrit-Change-Number: 30254 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: host/layer23: Add modem app

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30260 ) Change subject: host/layer23: Add modem app ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/host/layer23/src/modem/modem_main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30260/comment/c17782c9_bc75973d PS2, Line 115: ;; > error here Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a1121b3287da7d7330c30e3118affa8fd1da61b Gerrit-Change-Number: 30260 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 19:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: host/layer23: Add modem app

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30260 to look at the new patch set (#4). Change subject: host/layer23: Add modem app ...................................................................... host/layer23: Add modem app This app will allow setting up a tun device to transmit/receive data as a GPRS MS against a GSM network. This is just the initial skeleton so that people can work on it further in follow-up commits. Related: OS#5503 Change-Id: I8a1121b3287da7d7330c30e3118affa8fd1da61b --- M src/host/layer23/configure.ac M src/host/layer23/include/osmocom/bb/Makefile.am A src/host/layer23/include/osmocom/bb/modem/Makefile.am A src/host/layer23/include/osmocom/bb/modem/modem.h M src/host/layer23/src/Makefile.am A src/host/layer23/src/modem/Makefile.am A src/host/layer23/src/modem/modem_main.c 7 files changed, 207 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/60/30260/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a1121b3287da7d7330c30e3118affa8fd1da61b Gerrit-Change-Number: 30260 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: host/layer23: Add modem app

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30260 to look at the new patch set (#3). Change subject: host/layer23: Add modem app ...................................................................... host/layer23: Add modem app This app will allow setting up a tun device to transmit/receive data as a GPRS MS against a GSM network. This is just the initial skeleton so that people can work on it further in follow-up commits. Related: OS#5503 Change-Id: I8a1121b3287da7d7330c30e3118affa8fd1da61b --- M src/host/layer23/configure.ac M src/host/layer23/include/osmocom/bb/Makefile.am A src/host/layer23/include/osmocom/bb/modem/Makefile.am A src/host/layer23/include/osmocom/bb/modem/modem.h M src/host/layer23/src/Makefile.am A src/host/layer23/src/modem/Makefile.am A src/host/layer23/src/modem/modem_main.c 7 files changed, 210 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/60/30260/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a1121b3287da7d7330c30e3118affa8fd1da61b Gerrit-Change-Number: 30260 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: host/layer23: Add modem app

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30260 ) Change subject: host/layer23: Add modem app ...................................................................... Patch Set 2: (1 comment) File src/host/layer23/src/modem/modem_main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30260/comment/372ae326_e12f0cc3 PS2, Line 115: ;; error here -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a1121b3287da7d7330c30e3118affa8fd1da61b Gerrit-Change-Number: 30260 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 18:47:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: layer23/mobile: Add missing dependency cflags

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30257 ) Change subject: layer23/mobile: Add missing dependency cflags ...................................................................... layer23/mobile: Add missing dependency cflags The *_LIBS vars were already added, but the *_CFLAGS were missing. Change-Id: If904589b33357395e10f078857979aaecf5dbf68 --- M src/host/layer23/src/mobile/Makefile.am 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/layer23/src/mobile/Makefile.am b/src/host/layer23/src/mobile/Makefile.am index 8fefdfa..3db27b7 100644 --- a/src/host/layer23/src/mobile/Makefile.am +++ b/src/host/layer23/src/mobile/Makefile.am @@ -6,7 +6,9 @@ AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ + $(LIBOSMOCODEC_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(LIBLUA_CFLAGS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If904589b33357395e10f078857979aaecf5dbf68 Gerrit-Change-Number: 30257 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022