November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: rework l1sched_trigger(), split l1sched_pull_burst()

by laforge

Attention is currently required from: fixeria, pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30239 ) Change subject: trxcon: rework l1sched_trigger(), split l1sched_pull_burst() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibb7f9d7de26733f21b0753a2c655a250286bf1f0 Gerrit-Change-Number: 30239 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:31:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30250 ) Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' When using 'check_PROGRAMS', autoconf/automake generates smarter Makefiles, so that the test programs are not being compiled during the normal 'make all', but only during 'make check'. Change-Id: I62a7b4d76c910b3fa90deb0d35a8fc36146d66e6 --- M tests/libosmo-gtlv/Makefile.am M tests/libosmo-gtlv/test_gtlv_gen/Makefile.am M tests/libosmo-gtlv/test_tliv/Makefile.am M tests/libosmo-pfcp/Makefile.am 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/libosmo-gtlv/Makefile.am b/tests/libosmo-gtlv/Makefile.am index 20721c0..d73f940 100644 --- a/tests/libosmo-gtlv/Makefile.am +++ b/tests/libosmo-gtlv/Makefile.am @@ -13,7 +13,7 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) -noinst_PROGRAMS = \ +check_PROGRAMS = \ gtlv_test \ gtlv_dec_enc_test \ $(NULL) diff --git a/tests/libosmo-gtlv/test_gtlv_gen/Makefile.am b/tests/libosmo-gtlv/test_gtlv_gen/Makefile.am index e13e7b5..9f791fe 100644 --- a/tests/libosmo-gtlv/test_gtlv_gen/Makefile.am +++ b/tests/libosmo-gtlv/test_gtlv_gen/Makefile.am @@ -9,7 +9,7 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) -noinst_PROGRAMS = \ +check_PROGRAMS = \ gen__myproto_ies_auto \ gtlv_gen_test \ $(NULL) diff --git a/tests/libosmo-gtlv/test_tliv/Makefile.am b/tests/libosmo-gtlv/test_tliv/Makefile.am index 458a410..5b7dd7c 100644 --- a/tests/libosmo-gtlv/test_tliv/Makefile.am +++ b/tests/libosmo-gtlv/test_tliv/Makefile.am @@ -9,7 +9,7 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) -noinst_PROGRAMS = \ +check_PROGRAMS = \ gen__myproto_ies_auto \ tliv_test \ $(NULL) diff --git a/tests/libosmo-pfcp/Makefile.am b/tests/libosmo-pfcp/Makefile.am index 6f3eca1..b393d52 100644 --- a/tests/libosmo-pfcp/Makefile.am +++ b/tests/libosmo-pfcp/Makefile.am @@ -9,7 +9,7 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) -noinst_PROGRAMS = \ +check_PROGRAMS = \ pfcp_test \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I62a7b4d76c910b3fa90deb0d35a8fc36146d66e6 Gerrit-Change-Number: 30250 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30250 ) Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I62a7b4d76c910b3fa90deb0d35a8fc36146d66e6 Gerrit-Change-Number: 30250 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:30:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: implement Ready-to-Receive PHYIF API

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30262 ) Change subject: trxcon: implement Ready-to-Receive PHYIF API ...................................................................... trxcon: implement Ready-to-Receive PHYIF API This API is going to be used by osmo-trx-ms for inquiring the l1sched about an lchan state before attempting to demodulate a Downlink burst. Change-Id: I9a71b8a59733f4dd908b760c5e23ea3d624afb1a Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/include/osmocom/bb/trxcon/phyif.h M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trxcon_shim.c 4 files changed, 75 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/62/30262/1 diff --git a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h index 5202e5e..4b743ca 100644 --- a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h +++ b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h @@ -162,6 +162,16 @@ size_t burst_len; }; +/* Probed lchan is active */ +#define L1SCHED_PROBE_F_ACTIVE (1 << 0) + +/* RTR (Ready-to-Receive) probe */ +struct l1sched_probe { + uint32_t flags; /* see L1SCHED_PROBE_F_* above */ + uint32_t fn; + uint8_t tn; +}; + typedef int l1sched_lchan_rx_func(struct l1sched_lchan_state *lchan, const struct l1sched_burst_ind *bi); @@ -477,6 +487,8 @@ int l1sched_handle_rx_burst(struct l1sched_state *sched, struct l1sched_burst_ind *bi); +int l1sched_handle_rx_probe(struct l1sched_state *sched, + struct l1sched_probe *probe); /* Shared declarations for lchan handlers */ extern const uint8_t l1sched_nb_training_bits[8][26]; diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h b/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h index ac23ac6..abda393 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/phyif.h @@ -75,6 +75,20 @@ uint8_t tn; }; +/* RTR.ind - Ready-to-Receive indicaton */ +struct trxcon_phyif_rtr_ind { + uint32_t fn; + uint8_t tn; +}; + +/* The probed lchan is active */ +#define TRXCON_PHYIF_RTR_F_ACTIVE (1 << 0) + +/* RTR.rsp - Ready-to-Receive response */ +struct trxcon_phyif_rtr_rsp { + uint32_t flags; /* see TRXCON_PHYIF_RTR_F_* above */ +}; + /* BURST.req - a burst to be transmitted */ struct trxcon_phyif_burst_req { uint32_t fn; @@ -99,6 +113,8 @@ int trxcon_phyif_handle_clock_ind(void *priv, uint32_t fn); int trxcon_phyif_handle_rts_ind(void *priv, const struct trxcon_phyif_rts_ind *rts); +int trxcon_phyif_handle_rtr_ind(void *priv, const struct trxcon_phyif_rtr_ind *ind, + struct trxcon_phyif_rtr_rsp *rsp); int trxcon_phyif_handle_cmd(void *phyif, const struct trxcon_phyif_cmd *cmd); int trxcon_phyif_handle_rsp(void *priv, const struct trxcon_phyif_rsp *rsp); diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index b7d7854..4cedd8a 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -804,6 +804,36 @@ return 0; } +int l1sched_handle_rx_probe(struct l1sched_state *sched, + struct l1sched_probe *probe) +{ + struct l1sched_ts *ts = sched->ts[probe->tn]; + const struct l1sched_tdma_frame *frame; + struct l1sched_lchan_state *lchan; + unsigned int offset; + + /* Check whether required timeslot is allocated and configured */ + if (ts == NULL || ts->mf_layout == NULL) + return -EINVAL; + + /* Get frame from multiframe */ + offset = probe->fn % ts->mf_layout->period; + frame = &ts->mf_layout->frames[offset]; + + if (l1sched_lchan_desc[frame->dl_chan].rx_fn == NULL) + return -ENODEV; + + /* Find the appropriate logical channel */ + lchan = l1sched_find_lchan(ts, frame->dl_chan); + if (lchan == NULL) + return -ENODEV; + + if (lchan->active) + probe->flags |= L1SCHED_PROBE_F_ACTIVE; + + return 0; +} + #define MEAS_HIST_FIRST(hist) \ (&hist->buf[0]) #define MEAS_HIST_LAST(hist) \ diff --git a/src/host/trxcon/src/trxcon_shim.c b/src/host/trxcon/src/trxcon_shim.c index 9da3cb7..60fbf74 100644 --- a/src/host/trxcon/src/trxcon_shim.c +++ b/src/host/trxcon/src/trxcon_shim.c @@ -233,6 +233,23 @@ return l1sched_handle_burst_req(trxcon->sched, &br); } +int trxcon_phyif_handle_rtr_ind(void *priv, const struct trxcon_phyif_rtr_ind *ind, + struct trxcon_phyif_rtr_rsp *rsp) +{ + struct trxcon_inst *trxcon = priv; + struct l1sched_probe probe = { + .fn = ind->fn, + .tn = ind->tn, + }; + + l1sched_handle_rx_probe(trxcon->sched, &probe); + + if (probe.flags & L1SCHED_PROBE_F_ACTIVE) + rsp->flags |= TRXCON_PHYIF_RTR_F_ACTIVE; + + return 0; +} + int trxcon_phyif_handle_burst_ind(void *priv, const struct trxcon_phyif_burst_ind *phybi) { struct trxcon_inst *trxcon = priv; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9a71b8a59733f4dd908b760c5e23ea3d624afb1a Gerrit-Change-Number: 30262 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: conv_codes_gsm: Cosmetic improvements

by fixeria

Attention is currently required from: laforge, tnt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30261 ) Change subject: conv_codes_gsm: Cosmetic improvements ...................................................................... Patch Set 1: (3 comments) File utils/conv_codes_gsm.py: https://gerrit.osmocom.org/c/libosmocore/+/30261/comment/e2dacbbb_36b1a67a PS1, Line 390: 98 - 6 It was 98 before this patch, and now becomes 92. If it's an intentional change, I would expect it to be done in a separate patch. https://gerrit.osmocom.org/c/libosmocore/+/30261/comment/225633ef_a624a956 PS1, Line 576: 190 - 6 same here https://gerrit.osmocom.org/c/libosmocore/+/30261/comment/9d31c4f4_96f30c95 PS1, Line 590: 238 - 6 same here -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7cc6056114f997b5d4febf612ecd347b2d6d69b1 Gerrit-Change-Number: 30261 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 20:59:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: implement Ready-to-Send PHYIF API

by fixeria

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30241 ) Change subject: trxcon: implement Ready-to-Send PHYIF API ...................................................................... Patch Set 4: (1 comment) File src/host/trxcon/include/osmocom/bb/trxcon/phyif.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30241/comment/a99e8faa_be532e05 PS4, Line 101: trxcon_phyif_handle_rts_ind @Hoernchen: would it be more useful for you if I added a 'struct trxcon_phyif_burst_req *br' argument to this function, so that you could get the burst (or NOPE.req) in place? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic8f74413f5fad277340e007dd4296f890155a2c1 Gerrit-Change-Number: 30241 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 20:53:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: conv_codes_gsm: Cosmetic improvements

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/30261 ) Change subject: conv_codes_gsm: Cosmetic improvements ...................................................................... conv_codes_gsm: Cosmetic improvements * Fix mixed tab/space indent * Switch from 05.03 to 45.003 * give the 3GPP spec / section for each code * make the "magic number" of input bits to the convolutional code match the spec. The code always subtracts any known-zero tail bits as this improves decoding. Change-Id: I7cc6056114f997b5d4febf612ecd347b2d6d69b1 --- M utils/conv_codes_gsm.py 1 file changed, 41 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/30261/1 diff --git a/utils/conv_codes_gsm.py b/utils/conv_codes_gsm.py index 42f340b..cee5efc 100644 --- a/utils/conv_codes_gsm.py +++ b/utils/conv_codes_gsm.py @@ -4,7 +4,7 @@ from conv_gen import ConvolutionalCode from conv_gen import poly -# Polynomials according to 3GPP TS 05.03 Annex B +# Polynomials according to 3GPP TS 45.003 Annex B G0 = poly(0, 3, 4) G1 = poly(0, 1, 3, 4) G2 = poly(0, 2, 4) @@ -29,9 +29,9 @@ # Convolutional code definitions conv_codes = [ - # xCCH definition + # xCCH definition, 3GPP TS 45.003 Section 4.1 ConvolutionalCode( - 224, + 228 - 4, # 4 tail bits are known to be zero shared_polys["xcch"], name = "xcch", description = [ @@ -42,7 +42,7 @@ ] ), - # RACH definition + # RACH definition, 3GPP TS 45.003 Section 4.6.1 ConvolutionalCode( 14, shared_polys["xcch"], @@ -50,7 +50,7 @@ description = ["RACH convolutional code"] ), - # Extended RACH definition from 3GPP TS 45.003 §5.3.2 + # Extended RACH definition, 3GPP TS 45.003 Section 5.3.2 ConvolutionalCode( 17, shared_polys["xcch"], @@ -59,7 +59,7 @@ description = ["Extended RACH (11 bit) convolutional code"] ), - # SCH definition + # SCH definition, 3GPP TS 45.003 Section 4.7 ConvolutionalCode( 35, shared_polys["xcch"], @@ -67,9 +67,9 @@ description = ["SCH convolutional code"] ), - # CS2 definition + # CS2 definition, 3GPP TS 45.003 Section 5.1.2 ConvolutionalCode( - 290, + 294 - 4, # 4 tail bits are known to be zero shared_polys["xcch"], puncture = [ 15, 19, 23, 27, 31, 35, 43, 47, 51, 55, 59, 63, 67, 71, @@ -91,9 +91,9 @@ ] ), - # CS3 definition + # CS3 definition. 3GPP TS 45.003 Section 5.1.3 ConvolutionalCode( - 334, + 338 - 4, # 4 tail bits are known to be zero shared_polys["xcch"], puncture = [ 15, 17, 21, 23, 27, 29, 33, 35, 39, 41, 45, 47, 51, 53, @@ -123,7 +123,7 @@ # CS2 definition (non-punctured) ConvolutionalCode( - 290, + 294 - 4, # 4 tail bits are known to be zero shared_polys["xcch"], name = "cs2_np", description = [ @@ -135,7 +135,7 @@ # CS3 definition (non-punctured) ConvolutionalCode( - 334, + 338 - 4, # 4 tail bits are known to be zero shared_polys["xcch"], name = "cs3_np", description = [ @@ -377,17 +377,17 @@ ] ), - # TCH_FR definition + # TCH_FR definition, 3GPP TS 45.003 Section 3.1.2 ConvolutionalCode( - 185, + 189 - 4, # 4 tail bits are known to be zero shared_polys["xcch"], name = "tch_fr", description = ["TCH/F convolutional code"] ), - # TCH_HR definition + # TCH_HR definition, 3GPP TS 45.003 Section 3.2 ConvolutionalCode( - 98, + 98 - 6, # 6 tail bits are known to be zero [ ( G4, 1 ), ( G5, 1 ), @@ -522,7 +522,7 @@ description = ["TCH/AHS 4.75 kbits convolutional code"] ), - # TCH_AXS SID UPDATE definition + # TCH_AXS SID UPDATE definition, 3GPP TS 45.003 Section 3.9.1 + 3.10.1 ConvolutionalCode( 49, [ @@ -541,7 +541,7 @@ ] ), - # EDGE MCS1_DL_HDR definition + # EDGE MCS1_DL_HDR definition, 3GPP TS 45.003 Section 5.1.5.1.3 ConvolutionalCode( 36, shared_polys["mcs"], @@ -556,7 +556,7 @@ ] ), - # EDGE MCS1_UL_HDR definition + # EDGE MCS1_UL_HDR definition, 3GPP TS 45.003 Section 5.1.5.2.2 ConvolutionalCode( 39, shared_polys["mcs"], @@ -571,9 +571,9 @@ ] ), - # EDGE MCS1 definition + # EDGE MCS1 definition, 3GPP TS 45.003 Section 5.1.5.1.4 ConvolutionalCode( - 190, + 190 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs1", description = [ @@ -585,9 +585,9 @@ ] ), - # EDGE MCS2 definition + # EDGE MCS2 definition, 3GPP TS 45.003 Section 5.1.6.1.4 ConvolutionalCode( - 238, + 238 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs2", description = [ @@ -599,9 +599,9 @@ ] ), - # EDGE MCS3 definition + # EDGE MCS3 definition, 3GPP TS 45.003 Section 5.1.7.1.4 ConvolutionalCode( - 310, + 316 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs3", description = [ @@ -613,9 +613,9 @@ ] ), - # EDGE MCS4 definition + # EDGE MCS4 definition, 3GPP TS 45.003 Section 5.1.8.1.4 ConvolutionalCode( - 366, + 372 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs4", description = [ @@ -627,7 +627,7 @@ ] ), - # EDGE MCS5_DL_HDR definition + # EDGE MCS5_DL_HDR definition, 3GPP TS 45.003 Section 5.1.9.1.3 ConvolutionalCode( 33, shared_polys["mcs"], @@ -642,7 +642,7 @@ ] ), - # EDGE MCS5_UL_HDR definition + # EDGE MCS5_UL_HDR definition, 3GPP TS 45.003 Section 5.1.9.2.3 ConvolutionalCode( 45, shared_polys["mcs"], @@ -657,9 +657,9 @@ ] ), - # EDGE MCS5 definition + # EDGE MCS5 definition, 3GPP TS 45.003 Section 5.1.9.1.4 ConvolutionalCode( - 462, + 468 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs5", description = [ @@ -671,9 +671,9 @@ ] ), - # EDGE MCS6 definition + # EDGE MCS6 definition, 3GPP TS 45.003 Section 5.1.10.1.4 ConvolutionalCode( - 606, + 612 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs6", description = [ @@ -685,7 +685,7 @@ ] ), - # EDGE MCS7_DL_HDR definition + # EDGE MCS7_DL_HDR definition, 3GPP TS 45.003 Section 5.1.11.1.3 ConvolutionalCode( 45, shared_polys["mcs"], @@ -700,7 +700,7 @@ ] ), - # EDGE MCS7_UL_HDR definition + # EDGE MCS7_UL_HDR definition, 3GPP TS 45.003 Section 5.1.11.2.3 ConvolutionalCode( 54, shared_polys["mcs"], @@ -715,9 +715,9 @@ ] ), - # EDGE MCS7 definition + # EDGE MCS7 definition, 3GPP TS 45.003 Section 5.1.11.1.4 ConvolutionalCode( - 462, + 468 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs7", description = [ @@ -729,9 +729,9 @@ ] ), - # EDGE MCS8 definition + # EDGE MCS8 definition, 3GPP TS 45.003 Section 5.1.12.1.4 ConvolutionalCode( - 558, + 564 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs8", description = [ @@ -743,9 +743,9 @@ ] ), - # EDGE MCS9 definition + # EDGE MCS9 definition, 3GPP TS 45.003 Section 5.1.13.1.4 ConvolutionalCode( - 606, + 612 - 6, # 6 tail bits are known to be zero shared_polys["mcs"], name = "mcs9", description = [ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7cc6056114f997b5d4febf612ecd347b2d6d69b1 Gerrit-Change-Number: 30261 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: make burst pointer in trxcon_phyif_burst_ind const

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30254 ) Change subject: trxcon: make burst pointer in trxcon_phyif_burst_ind const ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30254/comment/13b9cdf1_8a8677bc PS1, Line 658: sbit_t *burst = (sbit_t *)&buf[8]; > I simply meant moving the for loop before the "bi = { ... […] Sure, just did that. Marking as resolved. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I68773d247725a6dc2cbbc58b63c0fd19ffdb1a16 Gerrit-Change-Number: 30254 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 20:30:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: group Rx burst params into struct l1sched_burst_ind

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30253 ) Change subject: trxcon: group Rx burst params into struct l1sched_burst_ind ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3363c38a43d2f54f846527b70cedac8fa57bcb27 Gerrit-Change-Number: 30253 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 20:29:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: rx_sch_fn(): do not use sched->fn_counter_proc

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30242 ) Change subject: trxcon: rx_sch_fn(): do not use sched->fn_counter_proc ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I56027876b50e53b474c2f54ac216cd141142020e Gerrit-Change-Number: 30242 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 20:26:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022