November 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: LAPD: move tx_hist code into static functions

by msuraev

Attention is currently required from: fixeria, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 ) Change subject: LAPD: move tx_hist code into static functions ...................................................................... Patch Set 7: (1 comment) File src/gsm/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/30244/comment/bd427ecf_2deb7d9b PS7, Line 1750: msg_to_tx_hist0 > I don't like this. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 Gerrit-Change-Number: 30244 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 12:40:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: LAPD: move tx_hist code into static functions

by msuraev

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30244 to look at the new patch set (#8). Change subject: LAPD: move tx_hist code into static functions ...................................................................... LAPD: move tx_hist code into static functions Related: OS#4074 Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 --- M src/gsm/lapd_core.c 1 file changed, 22 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/30244/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 Gerrit-Change-Number: 30244 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: Add assert for link check to osmo_stream_srv_create()

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30226 ) Change subject: Add assert for link check to osmo_stream_srv_create() ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If494eac5dcce6c5ae30e928b92e57067d5681a42 Gerrit-Change-Number: 30226 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 12:30:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: LAPD: move tx_hist code into static functions

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 ) Change subject: LAPD: move tx_hist code into static functions ...................................................................... Patch Set 7: Code-Review-1 (1 comment) File src/gsm/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/30244/comment/244dcc91_6667f6a4 PS7, Line 1750: msg_to_tx_hist0 I don't like this. Why not pass a struct lapd_history pointer (be it &dl->tx_hist[h] or &dl->tx_hist[0]) directly to msg_to_tx_hist()? You're not accessing any other fields in dl anyway, AFAICS. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 Gerrit-Change-Number: 30244 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 12:28:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: Add assert for link check to osmo_stream_srv_create()

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/30226 to look at the new patch set (#6). Change subject: Add assert for link check to osmo_stream_srv_create() ...................................................................... Add assert for link check to osmo_stream_srv_create() We implicitly rely on conn->srv availability in several functions. Let's ensure it's available in function creating conn. Change-Id: If494eac5dcce6c5ae30e928b92e57067d5681a42 --- M src/stream.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/26/30226/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If494eac5dcce6c5ae30e928b92e57067d5681a42 Gerrit-Change-Number: 30226 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: LAPD: move tx_hist code into static functions

by msuraev

Attention is currently required from: pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 ) Change subject: LAPD: move tx_hist code into static functions ...................................................................... Patch Set 7: (1 comment) This change is ready for review. File src/gsm/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/30244/comment/f0ad3a2f_9dee0118 PS4, Line 1916: dl->tx_hist[h].msg = lapd_msgb_alloc(msg->len, "HIST"); > Good catch. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 Gerrit-Change-Number: 30244 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 12:20:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Convert gprs_debug.cpp to C

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/30251 ) Change subject: Convert gprs_debug.cpp to C ...................................................................... Convert gprs_debug.cpp to C Change-Id: I142b870abda36950db5ff296c7c22228b0b11f55 --- M src/Makefile.am R src/gprs_debug.c M src/gprs_debug.h 3 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/30251/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I142b870abda36950db5ff296c7c22228b0b11f55 Gerrit-Change-Number: 30251 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Convert gprs_debug.cpp to C

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30251 ) Change subject: Convert gprs_debug.cpp to C ...................................................................... Patch Set 1: (1 comment) File src/gprs_debug.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1201): https://gerrit.osmocom.org/c/osmo-pcu/+/30251/comment/4b32bae5_3e6dbd08 PS1, Line 51: #endif adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I142b870abda36950db5ff296c7c22228b0b11f55 Gerrit-Change-Number: 30251 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 21 Nov 2022 12:07:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Convert gprs_debug.cpp to C

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30251 ) Change subject: Convert gprs_debug.cpp to C ...................................................................... Convert gprs_debug.cpp to C Change-Id: I142b870abda36950db5ff296c7c22228b0b11f55 --- M src/Makefile.am R src/gprs_debug.c M src/gprs_debug.h 3 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/30251/1 diff --git a/src/Makefile.am b/src/Makefile.am index ccc40ac..e7e94e0 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -39,7 +39,7 @@ noinst_LTLIBRARIES = libgprs.la libgprs_la_SOURCES = \ - gprs_debug.cpp \ + gprs_debug.c \ csn1.c \ csn1_dec.c \ csn1_enc.c \ diff --git a/src/gprs_debug.cpp b/src/gprs_debug.c similarity index 97% rename from src/gprs_debug.cpp rename to src/gprs_debug.c index 61c1c87..03ef083 100644 --- a/src/gprs_debug.cpp +++ b/src/gprs_debug.c @@ -1,7 +1,8 @@ -/* gprs_debug.cpp +/* gprs_debug.c * * Copyright (C) 2012 Ivan Klyuchnikov * Copyright (C) 2019 Harald Welte <laforge(a)gnumonks.org> + * Copyright (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -14,10 +15,8 @@ * GNU General Public License for more details. */ -extern "C" { #include <osmocom/core/utils.h> #include <osmocom/core/logging.h> -} #include <gprs_debug.h> diff --git a/src/gprs_debug.h b/src/gprs_debug.h index b683a63..eddbe75 100644 --- a/src/gprs_debug.h +++ b/src/gprs_debug.h @@ -19,9 +19,6 @@ extern "C" { #endif #include <osmocom/core/logging.h> -#ifdef __cplusplus -}; -#endif /* we used to have DBSSGP definded in each application, and applications telling * libosmogb which sub-system to use. That creates problems and has been deprecated */ @@ -48,3 +45,7 @@ }; extern const struct log_info gprs_log_info; + +#ifdef __cplusplus +}; +#endif \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I142b870abda36950db5ff296c7c22228b0b11f55 Gerrit-Change-Number: 30251 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: ttcn3-{pgw,ggsn}-test: Update smf.yml with new metrics section location

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30249 ) Change subject: ttcn3-{pgw,ggsn}-test: Update smf.yml with new metrics section location ...................................................................... ttcn3-{pgw,ggsn}-test: Update smf.yml with new metrics section location The "metrics" section was moved inside each program node to avoid clashes when several network programs are run in the same process and use the same config file. Depends: open5gs.git 2d4fbf92eb1be9ffe84df6dc103ee7401d1d3b0f Change-Id: Iae16bfccfbaaed37701e671ba619f8082f55506d --- M ttcn3-ggsn-test/ogs/open5gs-smf.yaml M ttcn3-pgw-test/open5gs-smf.yaml 2 files changed, 20 insertions(+), 29 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/ttcn3-ggsn-test/ogs/open5gs-smf.yaml b/ttcn3-ggsn-test/ogs/open5gs-smf.yaml index 9d47250..38579be 100644 --- a/ttcn3-ggsn-test/ogs/open5gs-smf.yaml +++ b/ttcn3-ggsn-test/ogs/open5gs-smf.yaml @@ -109,6 +109,13 @@ # gtpu: # name: localhost # +# <Metrics Server> +# +# o Metrics Server(http://<any address>:9090) +# metrics: +# addr: 0.0.0.0 +# port: 9090 +# # <Subnet for UE Pool> # # o IPv4 Pool @@ -342,6 +349,9 @@ port: 2152 option: so_bindtodevice: eth0 + metrics: + addr: 172.18.3.201 + port: 9090 subnet: - addr: 176.16.16.1/20 dnn: internet @@ -351,7 +361,6 @@ dnn: inet46 - addr: 2001:780:44:2100:0:0:0:1/56 dnn: inet46 - dns: - 172.18.3.222 - 8.8.8.8 @@ -533,17 +542,3 @@ # handover: # duration: 500 time: - -# -# metrics: -# -# <Metrics Server> -# -# o Metrics Server(http://<any address>:9090) -# metrics: -# addr: 0.0.0.0 -# port: 9090 -# -metrics: - addr: 172.18.3.201 - port: 9090 diff --git a/ttcn3-pgw-test/open5gs-smf.yaml b/ttcn3-pgw-test/open5gs-smf.yaml index b637aee..ac8bd80 100644 --- a/ttcn3-pgw-test/open5gs-smf.yaml +++ b/ttcn3-pgw-test/open5gs-smf.yaml @@ -109,6 +109,13 @@ # gtpu: # name: localhost # +# <Metrics Server> +# +# o Metrics Server(http://<any address>:9090) +# metrics: +# addr: 0.0.0.0 +# port: 9090 +# # <Subnet for UE Pool> # # o IPv4 Pool @@ -337,6 +344,9 @@ - addr: 172.18.18.4 gtpu: - addr: 172.18.18.4 + metrics: + addr: 172.18.18.4 + port: 9090 subnet: - addr: 10.45.0.1/16 dnn: internet @@ -521,17 +531,3 @@ # handover: # duration: 500 time: - -# -# metrics: -# -# <Metrics Server> -# -# o Metrics Server(http://<any address>:9090) -# metrics: -# addr: 0.0.0.0 -# port: 9090 -# -metrics: - addr: 172.18.18.4 - port: 9090 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iae16bfccfbaaed37701e671ba619f8082f55506d Gerrit-Change-Number: 30249 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022