November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: tbf_fsm: Move tbf_fsm_state_chg macro to .c file

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30215 ) Change subject: tbf_fsm: Move tbf_fsm_state_chg macro to .c file ...................................................................... tbf_fsm: Move tbf_fsm_state_chg macro to .c file It is nowadays only used internally, hence it can be moved to the .c file to better describe its scope. Change-Id: I23cfa5b7efbeb6a58855099780749741c9c947e9 --- M src/tbf_fsm.c M src/tbf_fsm.h 2 files changed, 9 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c index 6fe2a7a..c08fb88 100644 --- a/src/tbf_fsm.c +++ b/src/tbf_fsm.c @@ -38,6 +38,15 @@ [TBF_ST_RELEASING] = {}, }; +/* Transition to a state, using the T timer defined in tbf_fsm_timeouts. + * The actual timeout value is in turn obtained from conn->T_defs. + * Assumes local variable fi exists. */ +#define tbf_fsm_state_chg(fi, NEXT_STATE) \ + osmo_tdef_fsm_inst_state_chg(fi, NEXT_STATE, \ + tbf_fsm_timeouts, \ + the_pcu->T_defs, \ + -1) + const struct value_string tbf_fsm_event_names[] = { { TBF_EV_ASSIGN_ADD_CCCH, "ASSIGN_ADD_CCCH" }, { TBF_EV_ASSIGN_ADD_PACCH, "ASSIGN_ADD_PACCH" }, diff --git a/src/tbf_fsm.h b/src/tbf_fsm.h index 0acd4e5..c46d86c 100644 --- a/src/tbf_fsm.h +++ b/src/tbf_fsm.h @@ -56,14 +56,4 @@ unsigned int T_release; /* Timer to be used to end release: T3169 or T3195 */ }; -extern const struct osmo_tdef_state_timeout tbf_fsm_timeouts[32]; -/* Transition to a state, using the T timer defined in tbf_fsm_timeouts. - * The actual timeout value is in turn obtained from conn->T_defs. - * Assumes local variable fi exists. */ -#define tbf_fsm_state_chg(fi, NEXT_STATE) \ - osmo_tdef_fsm_inst_state_chg(fi, NEXT_STATE, \ - tbf_fsm_timeouts, \ - the_pcu->T_defs, \ - -1) - extern struct osmo_fsm tbf_fsm; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I23cfa5b7efbeb6a58855099780749741c9c947e9 Gerrit-Change-Number: 30215 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: tbf_fsm: Move osmo_fsm_inst fi out of struct tbf_fsm_ctx

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30216 ) Change subject: tbf_fsm: Move osmo_fsm_inst fi out of struct tbf_fsm_ctx ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I03e691ccf6a94431caa55653349158f5b85db017 Gerrit-Change-Number: 30216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 10:01:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Improve logging of osmux_xfrm_input

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30211 ) Change subject: osmux: Improve logging of osmux_xfrm_input ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30211/comment/dd17786b_ece7668b PS3, Line 189: state->rtph->ssrc > alignment is broken here Done https://gerrit.osmocom.org/c/libosmo-netif/+/30211/comment/e7d5d3f1_4150bf0d PS3, Line 334: struct osmux_link *link > const? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016 Gerrit-Change-Number: 30211 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 10:01:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: pfcp_test: add missing 'pdi_present = true'

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30247 ) Change subject: pfcp_test: add missing 'pdi_present = true' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Idc70ae23f15d3af65f98557cc51a111f2e6d75c9 Gerrit-Change-Number: 30247 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 10:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: pfcp_test: init logging, for PFCP errors

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30246 ) Change subject: pfcp_test: init logging, for PFCP errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I32a99d27ff72edceacb2cf4f4cd996650bc10710 Gerrit-Change-Number: 30246 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 09:59:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Improve logging of osmux_xfrm_input

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, laforge, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211 to look at the new patch set (#4). Change subject: osmux: Improve logging of osmux_xfrm_input ...................................................................... osmux: Improve logging of osmux_xfrm_input This allows easily identifying and following state and lifecycle of CIDs when looking at logs. Related: SYS#6161 Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016 --- M src/osmux_input.c M tests/osmux/osmux_test.ok 2 files changed, 272 insertions(+), 232 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/11/30211/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016 Gerrit-Change-Number: 30211 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Use new osmux_xfrm_input API to set name on each link

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30212 ) Change subject: osmux: Use new osmux_xfrm_input API to set name on each link ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id5b7d497be4b3405403d30e40e1a52f13101cf5f Gerrit-Change-Number: 30212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 09:53:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmux: Use new osmux_xfrm_input API to set name on each link

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30213 ) Change subject: osmux: Use new osmux_xfrm_input API to set name on each link ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/30213/comment/ca801d33_56e1f838 PS1, Line 168: to_ > To be consistent with the sockaddr API output I suggest using "r=ADDR" instead of "to_ADDR". Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaea980a2e11282add12f9af585500d90f0462279 Gerrit-Change-Number: 30213 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Nov 2022 09:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Use new osmux_xfrm_input API to set name on each link

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/30212 to look at the new patch set (#2). Change subject: osmux: Use new osmux_xfrm_input API to set name on each link ...................................................................... osmux: Use new osmux_xfrm_input API to set name on each link Depends: libosmo-netif.git Change-Id 8bb688e4827f345416c2a4526ced956a07fcc60b Change-Id: Id5b7d497be4b3405403d30e40e1a52f13101cf5f --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/12/30212/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id5b7d497be4b3405403d30e40e1a52f13101cf5f Gerrit-Change-Number: 30212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmux: Use new osmux_xfrm_input API to set name on each link

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/30213 to look at the new patch set (#2). Change subject: osmux: Use new osmux_xfrm_input API to set name on each link ...................................................................... osmux: Use new osmux_xfrm_input API to set name on each link Change-Id: Iaea980a2e11282add12f9af585500d90f0462279 Depends: libosmo-netif.git Change-Id 8bb688e4827f345416c2a4526ced956a07fcc60b --- M src/common/osmux.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/30213/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaea980a2e11282add12f9af585500d90f0462279 Gerrit-Change-Number: 30213 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022