Attention is currently required from: laforge, fixeria, msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 )
Change subject: libosmonetify SMPP
......................................................................
Patch Set 57:
(2 comments)
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/852cee57_0e2a899c
PS49, Line 985: osmo_stream_srv_link_close(smsc->link);
> Actually, assigning NULL in here breaks the ext tests.
Then this needs to be investigated further and fixed, it probably means there's a bug.
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/2d9b0407_e11e1907
PS57, Line 855: lost
> I would say 'closed', because 'lost' sounds like things went wrong.
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890
Gerrit-Change-Number: 28849
Gerrit-PatchSet: 57
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Nov 2022 09:49:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30225 )
Change subject: osmux: Refactor osmux_xfrm_output_pull() to simplify code flow
......................................................................
Patch Set 3:
(1 comment)
File src/osmux_output.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/30225/comment/37b15c8c_c2a07b50
PS3, Line 62: next
> While at it, maybe replace the goto with a proper while-loop?
I also though at it, but in the end found out the result was not as nice, specially since the goto is only for a specific case.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30225
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I0da1d7875bd32f6c1022676b64f9f0d14bad3144
Gerrit-Change-Number: 30225
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Nov 2022 09:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 )
Change subject: LAPD: move tx_hist code into static function
......................................................................
Patch Set 4: -Code-Review
(1 comment)
File src/gsm/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/30244/comment/248673cc_549895c0
PS4, Line 1916: dl->tx_hist[h].msg = lapd_msgb_alloc(msg->len, "HIST");
> is h always 0 here? because you are replacing it with 0 in this patch...
Good catch.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1
Gerrit-Change-Number: 30244
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Nov 2022 09:45:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 )
Change subject: LAPD: move tx_hist code into static function
......................................................................
Patch Set 4: -Code-Review
(1 comment)
File src/gsm/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/30244/comment/c01c3cf6_5604cd1d
PS4, Line 1916: dl->tx_hist[h].msg = lapd_msgb_alloc(msg->len, "HIST");
is h always 0 here? because you are replacing it with 0 in this patch...
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1
Gerrit-Change-Number: 30244
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Nov 2022 09:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30239 )
Change subject: trxcon: rework l1sched_trigger(), split l1sched_trigger_all()
......................................................................
Patch Set 2:
(1 comment)
File src/host/trxcon/src/sched_clck.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30239/comment/cd90e61c_6a64eaa6
PS2, Line 47: #define l1sched_trigger_all_advance(sched) \
> Pretty much the same question as for previous patch: if l1sched_trigger_all() is only called that wa […]
Agree with Max, I think you are at least missing explaining a bit the context of this change and what's the improvement.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ibb7f9d7de26733f21b0753a2c655a250286bf1f0
Gerrit-Change-Number: 30239
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Nov 2022 09:41:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30238 )
Change subject: trxcon: make l1sched_trigger() accept the [advanced] TDMA Fn
......................................................................
Patch Set 2:
(1 comment)
File src/host/trxcon/src/sched_clck.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30238/comment/c84d2d2e_8ebb7417
PS2, Line 45: /* Advance TDMA frame number in order to give the transceiver
> That's pretty confusing: you accept as parameter exact same thing which was computed internally befo […]
Agree with Max, I think you are at least missing explaining a bit the context of this change and what's the improvement.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30238
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icc9127bfacfbb78ab9d74103b2db03be850f3d4f
Gerrit-Change-Number: 30238
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Nov 2022 09:41:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment