November 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: Disable -Wstrict-prototypes for logging_vty_add_cmds()

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/30036 ) Change subject: Disable -Wstrict-prototypes for logging_vty_add_cmds() ...................................................................... Disable -Wstrict-prototypes for logging_vty_add_cmds() Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, its declaration in C file didn't contain "(void)", which meant the number of parameters is undefined and thus compiler doesn't complain. However, in recent Change-Id I84fd99442d0cc400fa562fa33623c142649230e2 we changed the declaration to '(void)' to allow building with -Wstrict-prototypes. This caused downstream build-failures of osmo-mgw and osmo-e1-recorder. So let's make one very small-scoped exception here. Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f --- M include/osmocom/vty/logging.h 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/30036/1 diff --git a/include/osmocom/vty/logging.h b/include/osmocom/vty/logging.h index 0ea6432..9be96e5 100644 --- a/include/osmocom/vty/logging.h +++ b/include/osmocom/vty/logging.h @@ -6,7 +6,12 @@ #define FILTER_STR "Filter log messages\n" struct log_info; -void logging_vty_add_cmds(void); +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wstrict-prototypes" +/* note this undefined argument declaration is intentional. There used + * to be an argument until 2017 which we no longer need .*/ +void logging_vty_add_cmds(); +#pragma GCC diagnostic pop void logging_vty_add_deprecated_subsys(void *ctx, const char *name); struct vty; struct log_target *osmo_log_vty2tgt(struct vty *vty); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f Gerrit-Change-Number: 30036 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: README: update explaining the difference to other approaches

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30033 ) Change subject: README: update explaining the difference to other approaches ...................................................................... README: update explaining the difference to other approaches Change-Id: Ie6afe8016c0168c2f0beee96d6c151c5b4cc5e81 --- M README 1 file changed, 17 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/README b/README index 149b547..1f7bc72 100644 --- a/README +++ b/README @@ -2,11 +2,24 @@ =================== (C) 2016 by Harald Welte <laforge(a)gnumonks.org> -The idea of this program is to be able to passively record E1/T1 based -communications for purposes of data analysis. +The idea of this program is to be able to build a "poor mans E1/T1 +recorder" purposes of data analysis, *without* any special +equipment. -Recording of a single E1 link always requires two E1 interface cards, -one for each direction. +This approach is more risky than a purely passive, hardware based +approach as that of the Osmocom e1-tracer released at +https://osmocom.org/projects/e1-t1-adapter/wiki/E1_tracer + +If you can, it is strongly recommended to use the purely passive, +high-impedance tap approach of e1-tracer and not the poor-man's +software proxy approach presented in osmo-e1-recorder. + +Setup +----- + +To do so, two E1 cards are used as some kind of proxy for the E1 +communication. Recording of a single E1 link always requires two E1 +interface cards, one for each direction. Recording can be performed either * passively, using a E1 Tap aapter -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ie6afe8016c0168c2f0beee96d6c151c5b4cc5e81 Gerrit-Change-Number: 30033 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: README: Migrate to README.md

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30034 ) Change subject: README: Migrate to README.md ...................................................................... README: Migrate to README.md Change-Id: Ic6553d7f672d737cc2813b3b0aeb7fc1d4715ce5 --- R README.md 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/README b/README.md similarity index 100% rename from README rename to README.md -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ic6553d7f672d737cc2813b3b0aeb7fc1d4715ce5 Gerrit-Change-Number: 30034 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: README.md: Fix lots of typos + formatting in markdown

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30035 ) Change subject: README.md: Fix lots of typos + formatting in markdown ...................................................................... README.md: Fix lots of typos + formatting in markdown Change-Id: I14cad6ae7e20479aea0c872fc57100f6a890a209 --- M README.md 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/README.md b/README.md index 1f7bc72..ad91df4 100644 --- a/README.md +++ b/README.md @@ -22,11 +22,12 @@ interface cards, one for each direction. Recording can be performed either -* passively, using a E1 Tap aapter -* asa proxy / man-in-the-middle + +* passively, using a E1 Tap adapter +* as a proxy / man-in-the-middle All timeslots will be opened in "raw" mode, making sure the recording -will work wheter or not there is HLDC-based signalling (MTP or LAPD), +will work whether or not there is HDLC-based signalling (MTP or LAPD), PCM voice, TRAU frames or anything else on the line. Recording will be done on a per-timeslot basis, dumping the raw bytes @@ -37,4 +38,4 @@ Later possible extensions could include automatic detection of the payload and a more intelligent storage format (e.g. in case of HDLC -bsaed signalling). +based signalling). -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I14cad6ae7e20479aea0c872fc57100f6a890a209 Gerrit-Change-Number: 30035 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: README.md: Fix lots of typos + formatting in markdown

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30035 ) Change subject: README.md: Fix lots of typos + formatting in markdown ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I14cad6ae7e20479aea0c872fc57100f6a890a209 Gerrit-Change-Number: 30035 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 09:46:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: README: Migrate to README.md

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30034 ) Change subject: README: Migrate to README.md ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ic6553d7f672d737cc2813b3b0aeb7fc1d4715ce5 Gerrit-Change-Number: 30034 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 09:46:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: README: update explaining the difference to other approaches

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30033 ) Change subject: README: update explaining the difference to other approaches ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ie6afe8016c0168c2f0beee96d6c151c5b4cc5e81 Gerrit-Change-Number: 30033 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 09:46:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: Fix use of logging_vty_add_cmds(void) API function.

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30031 ) Change subject: Fix use of logging_vty_add_cmds(void) API function. ...................................................................... Fix use of logging_vty_add_cmds(void) API function. This function never accepted any arguments. However, a sloppy declaration in the header file as logging_vty_add_cmds() allowed to pass any number of any type arguments until recently. Change-Id: Icdbe2f253c9e17ff82bd3b1dc3d4fbea4ad6f333 --- M src/e1_recorder.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/e1_recorder.c b/src/e1_recorder.c index 333375d..7a93470 100644 --- a/src/e1_recorder.c +++ b/src/e1_recorder.c @@ -187,7 +187,7 @@ osmo_init_logging2(rec_tall_ctx, &info); vty_init(&vty_info); - logging_vty_add_cmds(&info); + logging_vty_add_cmds(); osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); libosmo_abis_init(rec_tall_ctx); e1inp_vty_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Icdbe2f253c9e17ff82bd3b1dc3d4fbea4ad6f333 Gerrit-Change-Number: 30031 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: jenkins.sh: Fix printed URL of osmo-ci git repository

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30032 ) Change subject: jenkins.sh: Fix printed URL of osmo-ci git repository ...................................................................... jenkins.sh: Fix printed URL of osmo-ci git repository Change-Id: I043c2c613a3b204403f3b0fb41cab9f41bfc77fe --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index d9895ec..4565a80 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -7,7 +7,7 @@ # if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then - echo "Error: We need to have scripts/osmo-deps.sh from http://git.osmocom.org/osmo-ci/ in PATH !" + echo "Error: We need to have scripts/osmo-deps.sh from https://gitea.osmocom.org/osmocom/osmo-ci in PATH !" exit 2 fi -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I043c2c613a3b204403f3b0fb41cab9f41bfc77fe Gerrit-Change-Number: 30032 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: jenkins.sh: Fix printed URL of osmo-ci git repository

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30032 ) Change subject: jenkins.sh: Fix printed URL of osmo-ci git repository ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I043c2c613a3b204403f3b0fb41cab9f41bfc77fe Gerrit-Change-Number: 30032 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 09:37:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022