November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: move the trxcon_fsm related stuff into its own header

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30030 ) Change subject: trxcon: move the trxcon_fsm related stuff into its own header ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30030/comment/106ebe00_2c1b30f2 PS1, Line 2: > you probably should #include at least stdint and stdbool, as well as fsm. […] Good point. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I32097b27f8de8d2b765a4399ad5fd3a1bdba85f4 Gerrit-Change-Number: 30030 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 10:21:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Disable -Wstrict-prototypes for logging_vty_add_cmds()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30036 ) Change subject: Disable -Wstrict-prototypes for logging_vty_add_cmds() ...................................................................... Disable -Wstrict-prototypes for logging_vty_add_cmds() Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, its declaration in C file didn't contain "(void)", which meant the number of parameters is undefined and thus compiler doesn't complain. However, in recent Change-Id I84fd99442d0cc400fa562fa33623c142649230e2 we changed the declaration to '(void)' to allow building with -Wstrict-prototypes. This caused downstream build-failures of osmo-mgw (1.4.0) and osmo-e1-recorder (master). So let's make one very small-scoped exception here. Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f --- M include/osmocom/vty/logging.h 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/include/osmocom/vty/logging.h b/include/osmocom/vty/logging.h index 0ea6432..9be96e5 100644 --- a/include/osmocom/vty/logging.h +++ b/include/osmocom/vty/logging.h @@ -6,7 +6,12 @@ #define FILTER_STR "Filter log messages\n" struct log_info; -void logging_vty_add_cmds(void); +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wstrict-prototypes" +/* note this undefined argument declaration is intentional. There used + * to be an argument until 2017 which we no longer need .*/ +void logging_vty_add_cmds(); +#pragma GCC diagnostic pop void logging_vty_add_deprecated_subsys(void *ctx, const char *name); struct vty; struct log_target *osmo_log_vty2tgt(struct vty *vty); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f Gerrit-Change-Number: 30036 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Disable -Wstrict-prototypes for logging_vty_add_cmds()

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30036 ) Change subject: Disable -Wstrict-prototypes for logging_vty_add_cmds() ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f Gerrit-Change-Number: 30036 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 10:03:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Disable -Wstrict-prototypes for logging_vty_add_cmds()

by laforge

Attention is currently required from: laforge. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30036 ) Change subject: Disable -Wstrict-prototypes for logging_vty_add_cmds() ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f Gerrit-Change-Number: 30036 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: move the trxcon_fsm related stuff into its own header

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30030 ) Change subject: trxcon: move the trxcon_fsm related stuff into its own header ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30030/comment/62817bcb_e7653d19 PS1, Line 2: you probably should #include at least stdint and stdbool, as well as fsm.h ? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I32097b27f8de8d2b765a4399ad5fd3a1bdba85f4 Gerrit-Change-Number: 30030 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 10:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: abstract out trx_if.c from struct trxcon_inst

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30029 ) Change subject: trxcon: abstract out trx_if.c from struct trxcon_inst ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1a97c4c783ab671636ca33700eca97dede2a4a09 Gerrit-Change-Number: 30029 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 10:00:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: deliver measurement results via the PHYIF primitives

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30028 ) Change subject: trxcon: deliver measurement results via the PHYIF primitives ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie20616c288c16559d0a566979b24d57b50369fab Gerrit-Change-Number: 30028 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 10:00:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trxcon_fsm.c: remove unused import of l1ctl_server.h

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30027 ) Change subject: trxcon: trxcon_fsm.c: remove unused import of l1ctl_server.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I81a877845160db3b9d6823091ac9243be0836729 Gerrit-Change-Number: 30027 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 09:59:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Disable -Wstrict-prototypes for logging_vty_add_cmds()

by laforge

laforge has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/30036 ) Change subject: Disable -Wstrict-prototypes for logging_vty_add_cmds() ...................................................................... Disable -Wstrict-prototypes for logging_vty_add_cmds() Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, its declaration in C file didn't contain "(void)", which meant the number of parameters is undefined and thus compiler doesn't complain. However, in recent Change-Id I84fd99442d0cc400fa562fa33623c142649230e2 we changed the declaration to '(void)' to allow building with -Wstrict-prototypes. This caused downstream build-failures of osmo-mgw (1.4.0) and osmo-e1-recorder (master). So let's make one very small-scoped exception here. Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f --- M include/osmocom/vty/logging.h 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/30036/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f Gerrit-Change-Number: 30036 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Disable -Wstrict-prototypes for logging_vty_add_cmds()

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30036 ) Change subject: Disable -Wstrict-prototypes for logging_vty_add_cmds() ...................................................................... Patch Set 1: (1 comment) File include/osmocom/vty/logging.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-796): https://gerrit.osmocom.org/c/libosmocore/+/30036/comment/9cd6e4d8_3000d3a6 PS1, Line 13: void logging_vty_add_cmds(); Bad function definition - void logging_vty_add_cmds() should probably be void logging_vty_add_cmds(void) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadb54848b67db937b640dc2102dddb6e708a6a9f Gerrit-Change-Number: 30036 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 06 Nov 2022 09:56:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022