Attention is currently required from: laforge.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30024 )
Change subject: jenkins.sh: Support for building + publishing the manual
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File Makefile.am:
https://gerrit.osmocom.org/c/osmo-e1d/+/30024/comment/46564b38_aae96221
PS4, Line 5: doc \
Is the order of subdirs matter?
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ic399662e6ac5e5e7f999e6e7127df9a9580a0627
Gerrit-Change-Number: 30024
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 06 Nov 2022 11:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30040 )
Change subject: Support RPM building via contrib/osmo-e1-recorder.spec.in
......................................................................
Support RPM building via contrib/osmo-e1-recorder.spec.in
Change-Id: I1851b5c2a68ec9559e42c9da3f04d43c0fc7cdfe
---
M Makefile.am
M configure.ac
A contrib/osmo-e1-recorder.spec.in
3 files changed, 70 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-recorder refs/changes/40/30040/1
diff --git a/Makefile.am b/Makefile.am
index 24f0b24..d8c83a4 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,7 +15,7 @@
$(NULL)
BUILT_SOURCES = $(top_srcdir)/.version
-EXTRA_DIST = git-version-gen osmoappdesc.py .version
+EXTRA_DIST = git-version-gen osmoappdesc.py .version contrib/osmo-e1-recorder.spec.in
AM_DISTCHECK_CONFIGURE_FLAGS = \
--with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
diff --git a/configure.ac b/configure.ac
index 65a2c7f..568584d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -192,4 +192,5 @@
doc/Makefile
tests/Makefile
doc/examples/Makefile
+ contrib/osmo-e1-recorder.spec
Makefile)
diff --git a/contrib/osmo-e1-recorder.spec.in b/contrib/osmo-e1-recorder.spec.in
new file mode 100644
index 0000000..e7f1dba
--- /dev/null
+++ b/contrib/osmo-e1-recorder.spec.in
@@ -0,0 +1,68 @@
+#
+# spec file for package osmo-e1-recorder
+#
+# Copyright (c) 2018, Martin Hauke <mardnh(a)gmx.de>
+#
+# All modifications and additions to the file contributed by third parties
+# remain the property of their copyright owners, unless otherwise agreed
+# upon. The license for this file, and modifications and additions to the
+# file, is the same license as for the pristine package itself (unless the
+# license for the pristine package is not an Open Source License, in which
+# case the license is the MIT License). An "Open Source License" is a
+# license that conforms to the Open Source Definition (Version 1.9)
+# published by the Open Source Initiative.
+
+Name: osmo-e1-recorder
+Version: @VERSION@
+Release: 0
+Summary: Osmocom E1/T1 span recorder
+License: GPL-2.0-or-later
+Group: Productivity/Telephony/Utilities
+URL: https://gitea.osmocom.org/cellular-infrastructure/osmo-e1-recorder
+Source: %{name}-%{version}.tar.xz
+BuildRequires: autoconf
+BuildRequires: autoconf-archive
+BuildRequires: automake
+BuildRequires: libtool
+BuildRequires: pkgconfig
+BuildRequires: pkgconfig(libosmoabis)
+BuildRequires: pkgconfig(libosmocore)
+BuildRequires: pkgconfig(libosmogsm)
+BuildRequires: pkgconfig(libosmovty)
+BuildRequires: pkgconfig(talloc)
+
+%description
+The idea of this program is to be able to passively record E1/T1 based
+communications for purposes of data analysis.
+
+Recording of a single E1 link always requires two E1 interface cards,
+one for each direction.
+
+%prep
+%setup -q
+
+%build
+echo "%{version}" >.tarball-version
+autoreconf -fi
+%configure \
+ --docdir=%{_docdir}/%{name}
+make %{?_smp_mflags}
+
+%install
+%make_install
+
+%check
+make %{?_smp_mflags} check
+
+%files
+%doc README
+%{_docdir}/osmo-e1-recorder/examples/osmo-e1-recorder.cfg
+%dir %{_docdir}/%{name}/examples
+%{_docdir}/%{name}/examples/osmo-e1-recorder.cfg
+%dir %{_sysconfdir}/osmocom
+%config %{_sysconfdir}/osmocom/osmo-e1-recorder.cfg
+%{_bindir}//hdlc-test
+%{_bindir}/osmo-e1-recorder
+%{_bindir}/osmo-e1cap-dump
+
+%changelog
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30040
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-recorder
Gerrit-Branch: master
Gerrit-Change-Id: I1851b5c2a68ec9559e42c9da3f04d43c0fc7cdfe
Gerrit-Change-Number: 30040
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: laforge.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30022 )
Change subject: Initial user manual for osmo-e1d
......................................................................
Patch Set 4: Code-Review+1
(4 comments)
File doc/manuals/chapters/client-interface.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/8c9cd7ad_29867b57
PS3, Line 12:
Extra line can be dropped
File doc/manuals/chapters/overview.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/358806df_8ae61b77
PS3, Line 103: The osmo-e1d _vpair_ is not actual hardwarr, but a virtual pair of E1
Typo: hardware
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/9d4e6480_98feca56
PS3, Line 8: *osmo-e1d* [-h] [-d 'DBGMASK'] [-c 'CONFIGFILE']
[-V] missing
File doc/manuals/chapters/tdmoip.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/74858218_35ac0b65
PS3, Line 55: local-bind 0.0.0.0 9999 <2>
I think it would be easier to grasp when using the same port number as in the client configuration above.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30022
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I42f8da1990092b5a3d8c63fde33e49978ad83281
Gerrit-Change-Number: 30022
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 06 Nov 2022 11:35:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30023 )
Change subject: doxygen API documentation for libosmo-e1d
......................................................................
Patch Set 4:
(2 comments)
File Doxyfile.in:
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/30005548_c6b3863c
PS4, Line 586:
> Seems like a good idea to turn this on to prevent partially documented functions or forgetting to up […]
good point. I just copied it from another osmocom project. We should update all of those files in a separate task, then.
File Makefile.am:
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/7f3fd6e3_ca9edc5c
PS4, Line 32:
> Why is this necessary?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30023
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b
Gerrit-Change-Number: 30023
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 06 Nov 2022 11:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/30039 )
Change subject: Support RPM building via contrib/osmo-sysmon.spec.in
......................................................................
Support RPM building via contrib/osmo-sysmon.spec.in
Change-Id: I223bd1f20ad1710d4ce6ea5f170245ee8c1da46b
---
M Makefile.am
M configure.ac
A contrib/osmo-sysmon.spec.in
3 files changed, 66 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/39/30039/1
diff --git a/Makefile.am b/Makefile.am
index 59ac423..ab57cc6 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,5 +1,7 @@
SUBDIRS = doc src
+EXTRA_DIST = contrib/osmo-sysmon.spec.in
+
ACLOCAL_AMFLAGS = -I m4
@RELMAKE@
diff --git a/configure.ac b/configure.ac
index 2546b61..20b4279 100644
--- a/configure.ac
+++ b/configure.ac
@@ -124,4 +124,5 @@
doc/Makefile
doc/examples/Makefile
src/Makefile
+ contrib/osmo-sysmon.spec
Makefile)
diff --git a/contrib/osmo-sysmon.spec.in b/contrib/osmo-sysmon.spec.in
new file mode 100644
index 0000000..e1e7d32
--- /dev/null
+++ b/contrib/osmo-sysmon.spec.in
@@ -0,0 +1,63 @@
+#
+# spec file for package osmo-sysmon
+#
+# Copyright (c) 2018, Martin Hauke <mardnh(a)gmx.de>
+#
+# All modifications and additions to the file contributed by third parties
+# remain the property of their copyright owners, unless otherwise agreed
+# upon. The license for this file, and modifications and additions to the
+# file, is the same license as for the pristine package itself (unless the
+# license for the pristine package is not an Open Source License, in which
+# case the license is the MIT License). An "Open Source License" is a
+# license that conforms to the Open Source Definition (Version 1.9)
+# published by the Open Source Initiative.
+
+Name: osmo-sysmon
+Version: @VERSION@
+Release: 0
+Summary: Osmocom System Monitor
+License: GPL-2.0-or-later
+Group: Productivity/Telephony/Utilities
+URL: https://gitea.osmocom.org/osmocom/osmo-sysmon
+Source: %{name}-%{version}.tar.xz
+BuildRequires: autoconf-archive
+BuildRequires: automake
+BuildRequires: libtool
+BuildRequires: pkgconfig
+BuildRequires: pkgconfig(libmnl)
+BuildRequires: pkgconfig(libosmocore) >= 0.11.0
+BuildRequires: pkgconfig(libosmoctrl) >= 0.11.0
+BuildRequires: pkgconfig(libosmogsm) >= 0.11.0
+BuildRequires: pkgconfig(libosmovty) >= 0.11.0
+BuildRequires: pkgconfig(libosmo-netif) >= 0.4.0
+BuildRequires: pkgconfig(liboping) >= 1.9.0.
+
+%description
+Osmocom System Monitor.
+
+%prep
+%setup -q
+
+%build
+echo "%{version}" >.tarball-version
+autoreconf -fiv
+%configure \
+ --docdir=%{_docdir}/%{name} \
+ --with-systemdsystemunitdir=%{_unitdir}
+make %{?_smp_mflags}
+
+%install
+%make_install
+
+%files
+%license COPYING
+%dir %{_docdir}/%{name}
+%dir %{_docdir}/%{name}/examples
+%dir %{_docdir}/%{name}/examples/%{name}
+%{_docdir}/%{name}/examples/%{name}/osmo-sysmon.cfg
+%{_bindir}/osmo-ctrl-client
+%{_bindir}/osmo-sysmon
+%dir %{_sysconfdir}/osmocom
+%config(noreplace) %{_sysconfdir}/osmocom/osmo-sysmon.cfg
+
+%changelog
--
To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/30039
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-Change-Id: I223bd1f20ad1710d4ce6ea5f170245ee8c1da46b
Gerrit-Change-Number: 30039
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-uecups/+/30038
to look at the new patch set (#2).
Change subject: add spec.in file for RPM building
......................................................................
add spec.in file for RPM building
Change-Id: I7942b715a367f71b3fe74805f43dc45701983de8
---
M Makefile.am
M configure.ac
A contrib/osmo-uecups.spec.in
3 files changed, 85 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/38/30038/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/30038
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I7942b715a367f71b3fe74805f43dc45701983de8
Gerrit-Change-Number: 30038
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/30038 )
Change subject: add spec.in file for RPM building
......................................................................
Patch Set 1:
(1 comment)
File contrib/osmo-uecups.spec.in:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-805):
https://gerrit.osmocom.org/c/osmo-uecups/+/30038/comment/11661d25_67f7ff0c
PS1, Line 55: ### FIXME - no checks atm
trailing whitespace
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/30038
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I7942b715a367f71b3fe74805f43dc45701983de8
Gerrit-Change-Number: 30038
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 06 Nov 2022 11:29:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-e1d/+/30023
to look at the new patch set (#5).
Change subject: doxygen API documentation for libosmo-e1d
......................................................................
doxygen API documentation for libosmo-e1d
If we actually expect 3rd party applications to use libosmo-e1d to talk
to osmo-e1d, we'd better add some basic documentation on how this API
shall be used.
Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b
---
A Doxyfile.in
M configure.ac
M doc/Makefile.am
M doc/manuals/chapters/running.adoc
M include/osmocom/e1d/proto.h
M src/proto_clnt.c
6 files changed, 1,903 insertions(+), 54 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/23/30023/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30023
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b
Gerrit-Change-Number: 30023
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30023 )
Change subject: doxygen API documentation for libosmo-e1d
......................................................................
Patch Set 4:
(2 comments)
File Doxyfile.in:
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/3c6fd276_7becef72
PS4, Line 586:
Seems like a good idea to turn this on to prevent partially documented functions or forgetting to update docs after updating parameter list.
File Makefile.am:
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/98249c62_f5740a09
PS4, Line 32:
Why is this necessary?
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30023
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b
Gerrit-Change-Number: 30023
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 06 Nov 2022 11:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment