November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: fix -Werror=old-style-definition problems

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30017 ) Change subject: layer23: fix -Werror=old-style-definition problems ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0187acb02de6fd22ccc86c112640caa8aa3fa2bc Gerrit-Change-Number: 30017 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:59:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: layer23: configure.ac: print CFLAGS/CPPFLAGS using AC_MSG_RESULT()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30015 ) Change subject: layer23: configure.ac: print CFLAGS/CPPFLAGS using AC_MSG_RESULT() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib8d7138f7d5504176156ea5349336f5994c8fa80 Gerrit-Change-Number: 30015 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:59:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: virt_phy: configure.ac: add --enable-werror

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30014 ) Change subject: virt_phy: configure.ac: add --enable-werror ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I081ae20bfc6ed5f2906756a956b9fba0ae8e55f1 Gerrit-Change-Number: 30014 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:59:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: configure.ac: add --enable-werror

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30012 ) Change subject: trxcon: configure.ac: add --enable-werror ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id9b561f59599e5eb0267e3baaa33bf9cdde22ea3 Gerrit-Change-Number: 30012 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:59:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: virt_phy: support building with -Werror

by laforge

Attention is currently required from: fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30013 ) Change subject: virt_phy: support building with -Werror ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iccd2575faadee1ad3982466bf6a07fa5d52b0250 Gerrit-Change-Number: 30013 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:58:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: silence misleading error: "HEARTBEAT_REQ: Unknown message type"

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30045 ) Change subject: silence misleading error: "HEARTBEAT_REQ: Unknown message type" ...................................................................... silence misleading error: "HEARTBEAT_REQ: Unknown message type" Heartbeat is handled in libosmo-pfcp, osmo-upf does not need to take any action. Related: SYS#5599 Change-Id: Id81556129b528fa3a1f11ae4d01ad8b89a9be2f9 --- M src/osmo-upf/up_endpoint.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-upf/up_endpoint.c b/src/osmo-upf/up_endpoint.c index f687f4c..db765a4 100644 --- a/src/osmo-upf/up_endpoint.c +++ b/src/osmo-upf/up_endpoint.c @@ -221,6 +221,12 @@ case OSMO_PFCP_MSGT_SESSION_REP_REQ: up_ep_rx_session_rep_req(up_ep, m); return; + case OSMO_PFCP_MSGT_HEARTBEAT_REQ: + case OSMO_PFCP_MSGT_HEARTBEAT_RESP: + /* Heartbeat is already handled in osmo_pfcp_endpoint_handle_rx() in pfcp_endpoint.c. The heartbeat + * messages are also dispatched here, to the rx_cb, "on informtional basis", nothing needs to happen + * here. */ + return; default: OSMO_LOG_PFCP_MSG(m, LOGL_ERROR, "Unknown message type\n"); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30045 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id81556129b528fa3a1f11ae4d01ad8b89a9be2f9 Gerrit-Change-Number: 30045 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-upf[master]: silence misleading error: "HEARTBEAT_REQ: Unknown message type"

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30045 ) Change subject: silence misleading error: "HEARTBEAT_REQ: Unknown message type" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30045 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id81556129b528fa3a1f11ae4d01ad8b89a9be2f9 Gerrit-Change-Number: 30045 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:58:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: Initial user manual for osmo-e1d

by tnt

Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30022 ) Change subject: Initial user manual for osmo-e1d ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: LGTM -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I42f8da1990092b5a3d8c63fde33e49978ad83281 Gerrit-Change-Number: 30022 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:51:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: doxygen API documentation for libosmo-e1d

by tnt

Attention is currently required from: laforge, msuraev. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30023 ) Change subject: doxygen API documentation for libosmo-e1d ...................................................................... Patch Set 5: (4 comments) Patchset: PS5: Doc looks good except for the few comments. File src/proto_clnt.c: https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/a3a1755d_c51af873 PS5, Line 230: * \returns zero in case of success; negative in case of error. */ Maybe specify E1DP_INVALID can be specified to get info about all the interfaces ? https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/961ccc74_58d8a146 PS5, Line 267: * \param[in] line E1 line number (within interface) to query. Again, here 'line' is optional and can be E1DP_INVALID to get info about all the lines of the interface https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/1019ace8_cc1d6159 PS5, Line 306: * \param[in] ts E1 timeslot numer (within line) to query. Same ts can be E1DP_INVALID to get all ts of that line on that interface -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b Gerrit-Change-Number: 30023 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:38:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: api doc: explain heartbeat handling in rx_msg_cb

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30046 ) Change subject: api doc: explain heartbeat handling in rx_msg_cb ...................................................................... api doc: explain heartbeat handling in rx_msg_cb Related: SYS#5599 Change-Id: I3849060d703494ea43773c0208203f1fc206067f --- M include/osmocom/pfcp/pfcp_endpoint.h 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/46/30046/1 diff --git a/include/osmocom/pfcp/pfcp_endpoint.h b/include/osmocom/pfcp/pfcp_endpoint.h index d0ed113..7158582 100644 --- a/include/osmocom/pfcp/pfcp_endpoint.h +++ b/include/osmocom/pfcp/pfcp_endpoint.h @@ -69,7 +69,10 @@ osmo_pfcp_endpoint_cb set_msg_ctx_cb; /* Callback to receive a single incoming PFCP message from a remote peer, already decoded. See also the doc for - * osmo_pfcp_endpoint_cb. */ + * osmo_pfcp_endpoint_cb. + * All incoming messages are passed to this callback, including Heartbeat Request and Heartbeat Response + * messages. However, responding to heartbeat is already done in osmo_pfcp_endpoint_handle_rx() before + * rx_msg_cb() is invoked: a callback implementation can safely ignore Heartbeat Request messages. */ osmo_pfcp_endpoint_cb rx_msg_cb; /* Custom timer definitions to use, if any. Relevant timers are: OSMO_PFCP_TIMER_N1, OSMO_PFCP_TIMER_T1, -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I3849060d703494ea43773c0208203f1fc206067f Gerrit-Change-Number: 30046 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022