November 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: contrib/jenkins.sh: split test/pylint/docs
by osmith 07 Nov '22

07 Nov '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30004 ) Change subject: contrib/jenkins.sh: split test/pylint/docs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5245c529db729e209d78a02ab9c917a90d0e0206 Gerrit-Change-Number: 30004 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Nov 2022 08:16:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: layer23: fix -Werror=old-style-definition problems
by laforge 06 Nov '22

06 Nov '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30017 ) Change subject: layer23: fix -Werror=old-style-definition problems ...................................................................... layer23: fix -Werror=old-style-definition problems Change-Id: I0187acb02de6fd22ccc86c112640caa8aa3fa2bc --- M src/host/layer23/src/common/main.c M src/host/layer23/src/misc/app_bcch_scan.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/app_ccch_scan.c M src/host/layer23/src/misc/app_cell_log.c M src/host/layer23/src/misc/app_echo_test.c M src/host/layer23/src/mobile/main.c 7 files changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index 6781bae..f3d1ad1 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -73,7 +73,7 @@ printf("Usage: %s\n", app); } -static void print_help() +static void print_help(void) { int options = 0xff; struct l23_app_info *app = l23_app_info(); @@ -212,7 +212,7 @@ exit (0); } -static void print_copyright() +static void print_copyright(void) { struct l23_app_info *app; app = l23_app_info(); diff --git a/src/host/layer23/src/misc/app_bcch_scan.c b/src/host/layer23/src/misc/app_bcch_scan.c index c0c158b..257469c 100644 --- a/src/host/layer23/src/misc/app_bcch_scan.c +++ b/src/host/layer23/src/misc/app_bcch_scan.c @@ -60,7 +60,7 @@ .contribution = "Contributions by Holger Hans Peter Freyther\n", }; -struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/misc/app_cbch_sniff.c b/src/host/layer23/src/misc/app_cbch_sniff.c index e011a4d..33b1dfa 100644 --- a/src/host/layer23/src/misc/app_cbch_sniff.c +++ b/src/host/layer23/src/misc/app_cbch_sniff.c @@ -203,7 +203,7 @@ .contribution = "Contributions by Holger Hans Peter Freyther\n", }; -struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/misc/app_ccch_scan.c b/src/host/layer23/src/misc/app_ccch_scan.c index bde4dc3..dc16359 100644 --- a/src/host/layer23/src/misc/app_ccch_scan.c +++ b/src/host/layer23/src/misc/app_ccch_scan.c @@ -498,7 +498,7 @@ .contribution = "Contributions by Holger Hans Peter Freyther\n", }; -struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/misc/app_cell_log.c b/src/host/layer23/src/misc/app_cell_log.c index 97319fd..069e7d1 100644 --- a/src/host/layer23/src/misc/app_cell_log.c +++ b/src/host/layer23/src/misc/app_cell_log.c @@ -82,7 +82,7 @@ return 0; } -static int l23_cfg_supported() +static int l23_cfg_supported(void) { return L23_OPT_TAP | L23_OPT_DBG; } @@ -147,7 +147,7 @@ (*band_range)[i][1] = 0; } -static int l23_cfg_print_help() +static int l23_cfg_print_help(void) { printf("\nApplication specific\n"); printf(" -l --logfile LOGFILE Logfile for the cell log.\n"); @@ -237,7 +237,7 @@ .cfg_print_help = l23_cfg_print_help, }; -struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/misc/app_echo_test.c b/src/host/layer23/src/misc/app_echo_test.c index 531f10c..6d95e65 100644 --- a/src/host/layer23/src/misc/app_echo_test.c +++ b/src/host/layer23/src/misc/app_echo_test.c @@ -55,7 +55,7 @@ .contribution = "Contributions by Holger Hans Peter Freyther\n", }; -struct l23_app_info *l23_app_info() +struct l23_app_info *l23_app_info(void) { return &info; } diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index 0602654..9533553 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -76,7 +76,7 @@ printf("Usage: %s\n", app); } -static void print_help() +static void print_help(void) { printf(" Some help...\n"); printf(" -h --help this text\n"); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0187acb02de6fd22ccc86c112640caa8aa3fa2bc Gerrit-Change-Number: 30017 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: osmocon: add -Werror={implicit-int,int-conversion,old-style-definition}
by laforge 06 Nov '22

06 Nov '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30018 ) Change subject: osmocon: add -Werror={implicit-int,int-conversion,old-style-definition} ...................................................................... osmocon: add -Werror={implicit-int,int-conversion,old-style-definition} Change-Id: I46bdc87ef07704369bdc3ccc03b384aac87fe2f7 --- M src/host/osmocon/configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/osmocon/configure.ac b/src/host/osmocon/configure.ac index 7fa2692..556f60b 100644 --- a/src/host/osmocon/configure.ac +++ b/src/host/osmocon/configure.ac @@ -42,6 +42,7 @@ if test x"$werror" = x"yes" then WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" CFLAGS="$CFLAGS $WERROR_FLAGS" -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46bdc87ef07704369bdc3ccc03b384aac87fe2f7 Gerrit-Change-Number: 30018 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: virt_phy: configure.ac: add --enable-werror
by laforge 06 Nov '22

06 Nov '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30014 ) Change subject: virt_phy: configure.ac: add --enable-werror ...................................................................... virt_phy: configure.ac: add --enable-werror Change-Id: I081ae20bfc6ed5f2906756a956b9fba0ae8e55f1 --- M src/host/virt_phy/configure.ac 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/virt_phy/configure.ac b/src/host/virt_phy/configure.ac index fbff2c1..97c2e19 100644 --- a/src/host/virt_phy/configure.ac +++ b/src/host/virt_phy/configure.ac @@ -33,6 +33,28 @@ CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors, with exceptions: + a) deprecation (allow upstream to mark deprecation without breaking builds); + b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) + ] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" + WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + +AC_MSG_RESULT([CFLAGS="$CFLAGS"]) +AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) + AC_CONFIG_FILES([ Makefile include/Makefile -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I081ae20bfc6ed5f2906756a956b9fba0ae8e55f1 Gerrit-Change-Number: 30014 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: layer23: configure.ac: print CFLAGS/CPPFLAGS using AC_MSG_RESULT()
by laforge 06 Nov '22

06 Nov '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30015 ) Change subject: layer23: configure.ac: print CFLAGS/CPPFLAGS using AC_MSG_RESULT() ...................................................................... layer23: configure.ac: print CFLAGS/CPPFLAGS using AC_MSG_RESULT() Change-Id: Ib8d7138f7d5504176156ea5349336f5994c8fa80 --- M src/host/layer23/configure.ac 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/layer23/configure.ac b/src/host/layer23/configure.ac index 34dcbff..3ce9ead 100644 --- a/src/host/layer23/configure.ac +++ b/src/host/layer23/configure.ac @@ -60,6 +60,9 @@ dnl Checks for typedefs, structures and compiler characteristics +AC_MSG_RESULT([CFLAGS="$CFLAGS"]) +AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) + AC_OUTPUT( src/Makefile src/common/Makefile -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib8d7138f7d5504176156ea5349336f5994c8fa80 Gerrit-Change-Number: 30015 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: layer23: add -Werror={implicit-int,int-conversion,old-style-definition}
by laforge 06 Nov '22

06 Nov '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30016 ) Change subject: layer23: add -Werror={implicit-int,int-conversion,old-style-definition} ...................................................................... layer23: add -Werror={implicit-int,int-conversion,old-style-definition} Change-Id: Ia6e0c717c782ea000f1d40ad11af2ee725f9c309 --- M src/host/layer23/configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/layer23/configure.ac b/src/host/layer23/configure.ac index 3ce9ead..2817ed1 100644 --- a/src/host/layer23/configure.ac +++ b/src/host/layer23/configure.ac @@ -32,6 +32,7 @@ if test x"$werror" = x"yes" then WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" CFLAGS="$CFLAGS $WERROR_FLAGS" -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6e0c717c782ea000f1d40ad11af2ee725f9c309 Gerrit-Change-Number: 30016 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: virt_phy: support building with -Werror
by laforge 06 Nov '22

06 Nov '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30013 ) Change subject: virt_phy: support building with -Werror ...................................................................... virt_phy: support building with -Werror Change-Id: Iccd2575faadee1ad3982466bf6a07fa5d52b0250 --- M src/host/virt_phy/src/l1ctl_sap.c M src/host/virt_phy/src/virtphy.c 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/virt_phy/src/l1ctl_sap.c b/src/host/virt_phy/src/l1ctl_sap.c index a0e8c0c..35370f0 100644 --- a/src/host/virt_phy/src/l1ctl_sap.c +++ b/src/host/virt_phy/src/l1ctl_sap.c @@ -580,6 +580,7 @@ l1ctl_tx_tbf_cfg_conf(ms, cfg_req); } +#if 0 static const enum osmo_gprs_cs osmo_cs_by_l1ctl[] = { [L1CTL_CS_NONE] = OSMO_GPRS_CS_NONE, [L1CTL_CS1] = OSMO_GPRS_CS1, @@ -603,6 +604,7 @@ return -1; return osmo_cs_by_l1ctl[l1]; } +#endif static const enum l1ctl_coding_scheme l1ctl_cs_by_osmo[] = { [OSMO_GPRS_CS_NONE] = L1CTL_CS_NONE, diff --git a/src/host/virt_phy/src/virtphy.c b/src/host/virt_phy/src/virtphy.c index 412da9c..f2b8e5d 100644 --- a/src/host/virt_phy/src/virtphy.c +++ b/src/host/virt_phy/src/virtphy.c @@ -62,12 +62,12 @@ static char *mcast_netdev = NULL; static int mcast_ttl = -1; -static void print_usage() +static void print_usage(void) { printf("Usage: virtphy\n"); } -static void print_help() +static void print_help(void) { printf(" Some useful help...\n"); printf(" -h --help This text.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iccd2575faadee1ad3982466bf6a07fa5d52b0250 Gerrit-Change-Number: 30013 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: configure.ac: add --enable-werror
by laforge 06 Nov '22

06 Nov '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30012 ) Change subject: trxcon: configure.ac: add --enable-werror ...................................................................... trxcon: configure.ac: add --enable-werror Change-Id: Id9b561f59599e5eb0267e3baaa33bf9cdde22ea3 --- M src/host/trxcon/configure.ac 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/trxcon/configure.ac b/src/host/trxcon/configure.ac index 46991a2..554caab 100644 --- a/src/host/trxcon/configure.ac +++ b/src/host/trxcon/configure.ac @@ -32,6 +32,28 @@ CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors, with exceptions: + a) deprecation (allow upstream to mark deprecation without breaking builds); + b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) + ] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" + WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + +AC_MSG_RESULT([CFLAGS="$CFLAGS"]) +AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) + dnl Checks for typedefs, structures and compiler characteristics AC_CONFIG_MACRO_DIRS([m4]) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id9b561f59599e5eb0267e3baaa33bf9cdde22ea3 Gerrit-Change-Number: 30012 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: osmocon: add -Werror={implicit-int,int-conversion,old-style-definition}
by laforge 06 Nov '22

06 Nov '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30018 ) Change subject: osmocon: add -Werror={implicit-int,int-conversion,old-style-definition} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46bdc87ef07704369bdc3ccc03b384aac87fe2f7 Gerrit-Change-Number: 30018 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:59:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: layer23: add -Werror={implicit-int,int-conversion,old-style-definition}
by laforge 06 Nov '22

06 Nov '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30016 ) Change subject: layer23: add -Werror={implicit-int,int-conversion,old-style-definition} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6e0c717c782ea000f1d40ad11af2ee725f9c309 Gerrit-Change-Number: 30016 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 21:59:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log November 2022