November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1d[master]: doxygen API documentation for libosmo-e1d

by tnt

Attention is currently required from: laforge, msuraev. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30023 ) Change subject: doxygen API documentation for libosmo-e1d ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b Gerrit-Change-Number: 30023 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Nov 2022 09:39:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: gitreview: new file

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30050 ) Change subject: gitreview: new file ...................................................................... gitreview: new file Change-Id: I32ef094163ad157c6174730fa4f0b51038280107 --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/50/30050/1 diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..62fcab3 --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=osmo-e1d -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30050 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I32ef094163ad157c6174730fa4f0b51038280107 Gerrit-Change-Number: 30050 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-e1-recorder[master]: Support RPM building via contrib/osmo-e1-recorder.spec.in

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30040 ) Change subject: Support RPM building via contrib/osmo-e1-recorder.spec.in ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > osmith: Any idea why the gerrit job didn't appear to do a rpm build? it wasn't enabled yet: https://gerrit.osmocom.org/c/osmo-ci/+/30049 the reason is that this repository didn't have a debian repository (which is required before adding rpm specs, as we build a debian source package and use the source tarball from that in the rpm spec). I can take this over as well and add it. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30040 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I1851b5c2a68ec9559e42c9da3f04d43c0fc7cdfe Gerrit-Change-Number: 30040 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 07 Nov 2022 09:33:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit: osmo-e1-recorder: build deb/rpm

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30049 ) Change subject: jobs/gerrit: osmo-e1-recorder: build deb/rpm ...................................................................... jobs/gerrit: osmo-e1-recorder: build deb/rpm Related: osmo-e1-recorder I1851b5c2a68ec9559e42c9da3f04d43c0fc7cdfe Change-Id: Ie199e2ba4045ffc021307b2b22976c6a8311dc17 --- M jobs/gerrit-verifications.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/49/30049/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 8649635..4fb0c80 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -321,7 +321,7 @@ - osmo-cbc - osmo-e1-recorder: - pipeline_binpkgs: false + pipeline_binpkgs: true - gapk: pipeline_binpkgs: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30049 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie199e2ba4045ffc021307b2b22976c6a8311dc17 Gerrit-Change-Number: 30049 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: hnbgw: Only build with_pfcp on master

by osmith

Attention is currently required from: daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30047 ) Change subject: hnbgw: Only build with_pfcp on master ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4309c323c1d61e8f22dae499c407d57999f6f13a Gerrit-Change-Number: 30047 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Nov 2022 09:24:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: vty/logging.h: Avoid -Werror=pragmas error in C++ code

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30048 ) Change subject: vty/logging.h: Avoid -Werror=pragmas error in C++ code ...................................................................... Patch Set 1: Verified+1 Code-Review+2 (2 comments) Patchset: PS1: Patch looks good. Also I've reproduced the error locally and verified that this fixes it with osmo-pcu. File include/osmocom/vty/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/30048/comment/eb42158c_6a337eb4 PS1, Line 15: #pragma GCC diagnostic pop > but we've pushed only once? oh right, nvm -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85596cf4538d7a8c522f4bce1620a2d19e2a910e Gerrit-Change-Number: 30048 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 07 Nov 2022 09:23:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: doxygen API documentation for libosmo-e1d

by laforge

Attention is currently required from: tnt, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30023 ) Change subject: doxygen API documentation for libosmo-e1d ...................................................................... Patch Set 5: (3 comments) File src/proto_clnt.c: https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/38fb51fd_829924bb PS5, Line 230: * \returns zero in case of success; negative in case of error. */ > Maybe specify E1DP_INVALID can be specified to get info about all the interfaces ? Done https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/3ce65d1f_01ba65e7 PS5, Line 267: * \param[in] line E1 line number (within interface) to query. > Again, here 'line' is optional and can be E1DP_INVALID to get info about all the lines of the interf […] Done https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/390b3b72_44790ffd PS5, Line 306: * \param[in] ts E1 timeslot numer (within line) to query. > Same ts can be E1DP_INVALID to get all ts of that line on that interface Done -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b Gerrit-Change-Number: 30023 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Nov 2022 09:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: doxygen API documentation for libosmo-e1d

by laforge

Attention is currently required from: laforge, msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/30023 to look at the new patch set (#6). Change subject: doxygen API documentation for libosmo-e1d ...................................................................... doxygen API documentation for libosmo-e1d If we actually expect 3rd party applications to use libosmo-e1d to talk to osmo-e1d, we'd better add some basic documentation on how this API shall be used. Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b --- A Doxyfile.in M configure.ac M doc/Makefile.am M doc/manuals/chapters/running.adoc M include/osmocom/e1d/proto.h M src/proto_clnt.c 6 files changed, 1,905 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/23/30023/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b Gerrit-Change-Number: 30023 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: hnbgw: Only build with_pfcp on master

by laforge

Attention is currently required from: osmith, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30047 ) Change subject: hnbgw: Only build with_pfcp on master ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4309c323c1d61e8f22dae499c407d57999f6f13a Gerrit-Change-Number: 30047 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Nov 2022 09:16:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: vty/logging.h: Avoid -Werror=pragmas error in C++ code

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30048 ) Change subject: vty/logging.h: Avoid -Werror=pragmas error in C++ code ...................................................................... Patch Set 1: (1 comment) File include/osmocom/vty/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/30048/comment/e57d4de5_00459c06 PS1, Line 15: #pragma GCC diagnostic pop > needs another pop but we've pushed only once? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85596cf4538d7a8c522f4bce1620a2d19e2a910e Gerrit-Change-Number: 30048 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Nov 2022 09:15:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022