November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1d[master]: jenkins.sh: Support for building + publishing the manual

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30024 ) Change subject: jenkins.sh: Support for building + publishing the manual ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Hi osmith, I've invested already something like >= 2 hours in trying to hunt this down, but I cannot find the cause why the last build is not building (or not finding) the user manual pdf. It seems to build fine if I build it locally using contrib/jenkins.sh. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic399662e6ac5e5e7f999e6e7127df9a9580a0627 Gerrit-Change-Number: 30024 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 11:03:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: avoid segfault in 'show interface' of absent icE1usb

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30021 ) Change subject: avoid segfault in 'show interface' of absent icE1usb ...................................................................... avoid segfault in 'show interface' of absent icE1usb Don't segfault when processing a "show interfaces" for an interface that is configured via VTY but not actually attached/found in the system: usb.c:693:29: runtime error: member access within null pointer of type 'struct e1_usb_intf_data' Depends: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30019 Depends: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30020 Change-Id: I2ce990bb57f6ae4edb3a99a4b7bf26a49f362410 --- M src/usb.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/usb.c b/src/usb.c index fc461c4..ff624ea 100644 --- a/src/usb.c +++ b/src/usb.c @@ -694,6 +694,12 @@ OSMO_ASSERT(intf->drv == E1_DRIVER_USB); + if (!id) { + /* This can happen for statically configured devices (config/vty) which are not + * currently present */ + return snprintf(buf, len, "unknown"); + } + return snprintf(buf, len, "mode=%s, fix=%s, state=%s antenna=%s, tune=%u/%u, freq_est=%u", get_value_string(ice1usb_gpsdo_mode_str, last_st->mode), last_st->valid_fix ? "TRUE" : "FALSE", -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I2ce990bb57f6ae4edb3a99a4b7bf26a49f362410 Gerrit-Change-Number: 30021 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: avoid segfault in 'show interface' of absent icE1usb

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30021 ) Change subject: avoid segfault in 'show interface' of absent icE1usb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I2ce990bb57f6ae4edb3a99a4b7bf26a49f362410 Gerrit-Change-Number: 30021 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 11:01:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: Add support of RPM package building via osmo-e1d.spec.in

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30037 ) Change subject: Add support of RPM package building via osmo-e1d.spec.in ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi osmith, please take over here. I really don't see why this is not working, I should have copied things 1:1 from osmo-hlr.git but somehow the source tarball for osmo-e1d is not generated before trying to execute the spec file? -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: If9d3d4b7b06aef156fd895415db3b30bdecd74b4 Gerrit-Change-Number: 30037 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 06 Nov 2022 11:01:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-gsm-manuals[master]: gfdl.adoc: Fix cross-reference typo

by msuraev

Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30025 ) Change subject: gfdl.adoc: Fix cross-reference typo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I56abfc7467f77ec662351df8b64b9bb4185fa865 Gerrit-Change-Number: 30025 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 10:48:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: avoid segfault in 'show interface' of absent icE1usb

by msuraev

Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30021 ) Change subject: avoid segfault in 'show interface' of absent icE1usb ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > It's odd that Coverity hadn't found it. just a note -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I2ce990bb57f6ae4edb3a99a4b7bf26a49f362410 Gerrit-Change-Number: 30021 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 10:47:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: Add support of RPM package building via osmo-e1d.spec.in

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30037 ) Change subject: Add support of RPM package building via osmo-e1d.spec.in ...................................................................... Add support of RPM package building via osmo-e1d.spec.in Change-Id: If9d3d4b7b06aef156fd895415db3b30bdecd74b4 --- M configure.ac M contrib/Makefile.am A contrib/osmo-e1d.spec.in 3 files changed, 141 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/37/30037/1 diff --git a/configure.ac b/configure.ac index f671591..dbfd230 100644 --- a/configure.ac +++ b/configure.ac @@ -115,6 +115,7 @@ Makefile contrib/Makefile contrib/systemd/Makefile + contrib/osmo-e1d.spec doc/Makefile doc/examples/Makefile src/Makefile diff --git a/contrib/Makefile.am b/contrib/Makefile.am index 3439c97..094b092 100644 --- a/contrib/Makefile.am +++ b/contrib/Makefile.am @@ -1 +1,5 @@ SUBDIRS = systemd + +EXTRA_DIST = \ + osmo-e1d.spec.in \ + $(NULL) diff --git a/contrib/osmo-e1d.spec.in b/contrib/osmo-e1d.spec.in new file mode 100644 index 0000000..2e19ec9 --- /dev/null +++ b/contrib/osmo-e1d.spec.in @@ -0,0 +1,136 @@ +# +# spec file for package osmo-e1d +# +# Copyright (c) 2022 SUSE LLC +# Copyright (c) 2019-2021, Martin Hauke <mardnh(a)gmx.de> +# +# All modifications and additions to the file contributed by third parties +# remain the property of their copyright owners, unless otherwise agreed +# upon. The license for this file, and modifications and additions to the +# file, is the same license as for the pristine package itself (unless the +# license for the pristine package is not an Open Source License, in which +# case the license is the MIT License). An "Open Source License" is a +# license that conforms to the Open Source Definition (Version 1.9) +# published by the Open Source Initiative. + +Name: osmo-e1d +Version: @VERSION@ +Release: 0 +Summary: Osmocom E1 Daemon +License: GPL-2.0-or-later +Group: Productivity/Telephony/Utilities +URL: https://osmocom.org/projects/osmo-e1d/wiki/Wiki +Source: ${name}-${version}.tar.xz +BuildRequires: automake >= 1.9 +BuildRequires: libtool >= 2 +BuildRequires: pkg-config >= 0.20 +%if 0%{?suse_version} +BuildRequires: systemd-rpm-macros +%endif +BuildRequires: pkgconfig(libosmocore) >= 1.7.0 +BuildRequires: pkgconfig(libosmousb) >= 1.7.0 +BuildRequires: pkgconfig(libosmovty) >= 1.7.0 +BuildRequires: pkgconfig(talloc) >= 2.0.1 +%{?systemd_requires} + +%description +osmo-e1d is an E1 interface daemon that is part of the Osmocom E1 +interface driver architecture. It was primarily written for the +ICE40_E1_USB_interface (ICE40 based E1 framer IP core developed by +tnt). + +osmo-e1d acts as an interface between the hardware/firmware of the E1 +interface on the bottom side, and applications wanting to use E1 +timeslots on the top side. + +%package -n libosmo-e1d1 +Summary: Osmocom E1 daemon protocol library +License: LGPL-3.0-or-later +Group: System/Libraries + +%description -n libosmo-e1d1 +Osmocom E1 Daemon Protocol Library. + +%package -n libosmo-octoi0 +Summary: Library for the Osmocom Community TDMoIP network +License: LGPL-3.0-or-later +Group: System/Libraries + +%description -n libosmo-octoi0 +Library for the Osmocom Community TDMoIP network. + +%package devel +Summary: Header files for the Osmocom E1 daemon protocol library +License: LGPL-3.0-or-later +Group: Development/Libraries/C and C++ +Requires: libosmo-e1d1 = %version-%release +Requires: libosmo-octoi0 = %version-%release +Provides: libosmo-e1d-devel = %version-%release +Obsoletes: libosmo-e1d-devel < %version-%release + +%description devel +This subpackage contains libraries and header files for developing +applications that want to make use of libosmo-e1d. + +%prep +%autosetup -p1 + +%build +echo "%version" >.tarball-version +autoreconf -fiv +# bugzilla.opensuse.org/795968 for rationale +%configure --includedir="%_includedir/%name" --disable-static \ + --docdir="%_docdir/%name" \ + --with-systemdsystemunitdir="%_unitdir" +%make_build + +%install +%make_install +find "%buildroot" -type f -name "*.la" -delete -print +rm -Rf "%buildroot/%_sysconfdir/osmocom" + +%check +%make_build check || find . -name testsuite.log -exec cat {} + + +%post -n libosmo-e1d1 -p /sbin/ldconfig +%postun -n libosmo-e1d1 -p /sbin/ldconfig +%post -n libosmo-octoi0 -p /sbin/ldconfig +%postun -n libosmo-octoi0 -p /sbin/ldconfig + +%if 0%{?suse_version} +%preun +%service_del_preun %name.service + +%postun +%service_del_postun %name.service + +%pre +%service_add_pre %name.service + +%post +%service_add_post %name.service +%endif + +%files +%license COPYING COPYING.gpl2 COPYING.lgpl3 +%doc README.md +%_bindir/osmo-e1d +%_bindir/osmo-e1d-pipe +%dir %_docdir/%name +%dir %_docdir/%name/examples +%_docdir/%name/examples/ +%_unitdir/osmo-e1d.service + +%files -n libosmo-e1d1 +%_libdir/libosmo-e1d.so.* + +%files -n libosmo-octoi0 +%_libdir/libosmo-octoi.so.* + +%files devel +%_includedir/%name/ +%_libdir/libosmo-e1d.so +%_libdir/libosmo-octoi.so +%_libdir/pkgconfig/*.pc + +%changelog -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: If9d3d4b7b06aef156fd895415db3b30bdecd74b4 Gerrit-Change-Number: 30037 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: avoid segfault in 'show interface' of absent icE1usb

by msuraev

Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30021 ) Change subject: avoid segfault in 'show interface' of absent icE1usb ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: It's odd that Coverity hadn't found it. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I2ce990bb57f6ae4edb3a99a4b7bf26a49f362410 Gerrit-Change-Number: 30021 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Nov 2022 10:47:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: Initial user manual for osmo-e1d

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/30022 to look at the new patch set (#3). Change subject: Initial user manual for osmo-e1d ...................................................................... Initial user manual for osmo-e1d Still quite incomplete, but significantly better than nothing. Change-Id: I42f8da1990092b5a3d8c63fde33e49978ad83281 --- M configure.ac M doc/Makefile.am A doc/manuals/Makefile.am A doc/manuals/chapters/client-interface.adoc A doc/manuals/chapters/drivers.adoc A doc/manuals/chapters/overview.adoc A doc/manuals/chapters/running.adoc A doc/manuals/chapters/tdmoip.adoc A doc/manuals/osmoe1d-usermanual-docinfo.xml A doc/manuals/osmoe1d-usermanual.adoc 10 files changed, 488 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/22/30022/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I42f8da1990092b5a3d8c63fde33e49978ad83281 Gerrit-Change-Number: 30022 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-e1d[master]: jenkins.sh: Support for building + publishing the manual

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/30024 to look at the new patch set (#3). Change subject: jenkins.sh: Support for building + publishing the manual ...................................................................... jenkins.sh: Support for building + publishing the manual Change-Id: Ic399662e6ac5e5e7f999e6e7127df9a9580a0627 --- M Makefile.am M contrib/jenkins.sh 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/24/30024/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic399662e6ac5e5e7f999e6e7127df9a9580a0627 Gerrit-Change-Number: 30024 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022