osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-434-g9786c3e

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/wip/ms-struct has been updated via 9786c3efe4ecf0c710e3681a2aff73bb87320ea6 (commit) via 56d8c053acc482f2b972b68f91c605c215094645 (commit) via 087629ea2bfd5942cd8f6ae79f55c571b30c0b8b (commit) via 8e843883fb6b0ee8020c856f1220dcdb068d5272 (commit) via ce1ce40ad4d98d3b084ef1e37a72ba5dcb33f448 (commit) via 2ee112c2e134146c501601e0faf01014393bd7b7 (commit) via d1cb41bfd020eb9b94b17e5bcaa5be36bceccc12 (commit) via 5752285bc55c00ddcba45c0168eef0cb0238a3a7 (commit) via b75e23143b1d8733a0fdf155f431dcea8146296c (commit) from 4f459799e31ee8fe34ae5f7b584860f699019cfc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=9786c3efe4ecf0c710e3681a2aff73b… commit 9786c3efe4ecf0c710e3681a2aff73bb87320ea6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu May 21 11:10:15 2015 +0200 tbf: Remove IMSI handling from trigger_dl_ass Currently the BTS::trigger_dl_ass() method assigns the IMSI to the MS object. This should be (and is already) done earlier where the MS object is retrieved/created. This commit removes the corresponding code along with the 'imsi' parameter from trigger_dl_ass. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=56d8c053acc482f2b972b68f91c605c… commit 56d8c053acc482f2b972b68f91c605c215094645 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu May 21 11:07:53 2015 +0200 ms: Use the IMSI to retrieve the MS object This commit extends get_ms() to really compare the IMSI if it has been given. Note that the MS object list will be traversed only once and that the first entry with a matching TLLI or a matching IMSI will be returned. Thus there is no precedence. Ticket: #1674 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=087629ea2bfd5942cd8f6ae79f55c57… commit 087629ea2bfd5942cd8f6ae79f55c571b30c0b8b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu May 21 11:07:16 2015 +0200 tbf: Move IMSI to MS object Currently the IMSI is stored in the TBFs. Since it directly refers to an MS, it should rather be stored in an MS object. This patch move the m_imsi field from gprs_rlcmac_tbf to GprsMs, changes gprs_rlcmac_tbf::imsi() to get the IMSI from the associated MS object, and adds getter and setter to GprsMs. Note that the assign_imsi() method is now called set_imsi() for consistency within the GprsMs class. Ticket: #1674 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=8e843883fb6b0ee8020c856f1220dcd… commit 8e843883fb6b0ee8020c856f1220dcdb068d5272 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu May 21 12:06:58 2015 +0200 tbf/test: Fix IMSI creation Currently the generated IMSI contains blanks due to a missing '0' flag in the corresponding snprintf statement. In addition, the buffer is effectively limited to 15 bytes which is shorter than the generated character sequence, such that the last character of the IMSI is removed. This patch fixes both issues. Since snprintf itself will add a terminating \0 character, the whole buffer can be passed to snprintf. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ce1ce40ad4d98d3b084ef1e37a72ba5… commit ce1ce40ad4d98d3b084ef1e37a72ba5dcb33f448 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu May 21 16:58:22 2015 +0200 tbf: Always call set_tlli/confirm_tlli in update_ms Currently the m_tlli member in GprsMs is set by the constructor, circumventing the TLLI confirmation mechanism. This commit replaces the get_or_create_ms() method by a create_ms() method which takes the TLLI and the direction (UL or DL) as parameters to select either set_tlli() or confirm_tlli(). The MS object is instantiated with TLLI = 0, and therefore GprsMs::tlli() is extended to return the DL TLLI if both of the other TLLI are not set. Note that create_ms() will not check whether an MS object with a matching TLLI is already stored in the list, so it should only be called after a corresponding get_ms() in general. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=2ee112c2e134146c501601e0faf0101… commit 2ee112c2e134146c501601e0faf01014393bd7b7 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed May 20 12:06:46 2015 +0200 tbf: Remove the TLLI from the TBFs Currently the TLLI is stored in each TBF. Since each MS is now represented by a GprsMs object which takes care of TLLI updating, and each TBF that has been associated with an TLLI also contains a reference to a GprsMs object, per TBF TLLI handling is no longer needed. Keeping all TBF m_tlli members up to date is complex and doesn't currently work correctly in all circumstances. This commit removes m_tlli and related members from the TBF class and the tbf_by_tlli functions from the BTS class. Ticket: #1674 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: configure.ac | 2 +- src/bts.cpp | 51 ++------- src/bts.h | 4 +- src/gprs_ms.cpp | 27 +++++ src/gprs_ms.h | 16 ++- src/gprs_ms_storage.cpp | 15 ++- src/gprs_ms_storage.h | 3 +- src/openbts_sock.cpp | 5 +- src/sysmo_l1_if.c | 10 +- src/tbf.cpp | 62 ++++------- src/tbf.h | 15 +-- src/tbf_dl.cpp | 25 ++--- tests/Makefile.am | 3 - tests/alloc/AllocTest.cpp | 16 +-- tests/ms/MsTest.cpp | 36 +++++-- tests/ms/MsTest.err | 8 +- tests/tbf/TbfTest.cpp | 11 +- tests/tbf/TbfTest.err | 265 ++++++++++++++++++++++++++++------------------ 18 files changed, 317 insertions(+), 257 deletions(-) hooks/post-receive -- UNNAMED PROJECT