openbsc.git branch neels/bind updated. 0.15.0-179-gb95a611

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/bind has been updated discards 5e490419f2be30df330ca19cd219090ba8aa7eae (commit) discards 3b017c73e40769f15ee76dfbb55e63b31c143958 (commit) discards 5cf85a69e55e6eae3a26c7b72f1d0deb81afdcda (commit) discards dfe28a47032700d4cbeaf051a40c0f1f1f8bd94a (commit) discards c9ba14034b4f5a811aa6bba8657f08a84b4d4346 (commit) discards 62320a2c970bdda0458ed12a2ea9bfa3cd496c2b (commit) via b95a6113acc0d4372d000c29a37592d9b80b8f1c (commit) via ee6844b26642a6bc2a3893bc46351a17b1f40df8 (commit) via 4d919de0b22485f211a4398ef174691739d863c4 (commit) via c655f6bf311d4533c13309660eb5f9b2cb6c6631 (commit) via a180f6472cfaa7d89824a7777173cd0bf5af7aa2 (commit) via 271db46716db46adc5c65b018d11258bb7a23a03 (commit) via 18394fdbed069f03c2c7ad910632bfba84acdc04 (commit) via 75b580869498966c1359b7ab6588f7ac80422337 (commit) via d5dee43a03b6f8c34460d6f7e74f5bea16d72439 (commit) via f25f8cebb58ad1f5241a33d9bac76654cd2a68a2 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (5e490419f2be30df330ca19cd219090ba8aa7eae) \ N -- N -- N (b95a6113acc0d4372d000c29a37592d9b80b8f1c) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b95a6113acc0d4372d000c29a37592d9… commit b95a6113acc0d4372d000c29a37592d9b80b8f1c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 19:15:39 2016 +0100 smpp: refactor initialization, add bind address Make the SMPP bind address configurable (used to be harcoded as "0.0.0.0"). However, to be useful, this patch has to go somewhat further: refactor the initialization procedure, because it was impossible to run the VTY commands without an already established connection. The SMPP initialization procedure was weird. It would first open a connection on the default port, and a subsequent VTY port reconfiguration while reading the config file would try to re-establish a connection on a different port. If that failed, smpp would switch back to the default port instead of failing the program launch as the user would expect. If anything else ran on port 2775, SMPP would thus refuse to launch despite the config file having a different port: the first bind would always happen on 0.0.0.0:2775. Change that. In the VTY commands, merely store address and port if no fd is established yet. Introduce several SMPP initialization stages: * allocate struct and initialize pointers, * then read config file without immediately starting to listen, * and once the main program is ready, start listening. After that, the VTY command behaves as before: try to re-establish the old connection if the newly supplied address and port don't work out. I'm not actually sure why this switch-back behavior is needed, but fair enough. In detail, replace the function smpp_smsc_init() with the various steps smpp_smsc_alloc_init() -- prepare struct for VTY commands smpp_smsc_conf() -- set addr an port only, for reading the config file smpp_smsc_start() -- establish a first connection, for main() smpp_smsc_restart() -- switch running connection, for telnet VTY smpp_smsc_stop() -- tear down connection, used by _start() twice And replace smpp_openbsc_init() smpp_openbsc_set_net() with smpp_openbsc_alloc_init() smpp_openbsc_start() I'd have picked function names like "_bind"/"_unbind", but in the SMPP protocol there is also a bind/unbind process, so instead I chose the names "_start", "_restart" and "_stop". The smsc struct used to be talloc'd outside of smpp_smsc_init(). Since the smsc code internally uses talloc anyway and employs the smsc struct as talloc context, I decided to enforce talloc allocation within smpp_smsc_alloc_init(). Be stricter about osmo_signal_register_handler() return codes. http://cgit.osmocom.org/openbsc/commit/?id=ee6844b26642a6bc2a3893bc46351a17… commit ee6844b26642a6bc2a3893bc46351a17b1f40df8 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 15:10:33 2016 +0100 enable ctrl bind config for various programs Add ctrl_vty_init() calls and feed the ctrl_vty_get_bind_addr() return value to ctrl_interface_setup() in the following programs: osmo-bsc osmo-bsc_nat osmo-nitb osmo-sgsn For osmo-sgsn, move the control interface setup invocation below the config parsing, so that the ctrl_vty_get_bind_addr() can return the configured address. http://cgit.osmocom.org/openbsc/commit/?id=4d919de0b22485f211a4398ef1746917… commit 4d919de0b22485f211a4398ef174691739d863c4 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:59:43 2016 +0100 osmo-nitb: be strict about cmdline args Abort upon unknown options and missing option arguments. This came to my attention while rewiring the -m and -M options: passing -M without argument would launch nitb with wrong configuration. So, rather exit immediately. If there are legacy options that should be ignored, they deserve an own 'case:' in the option switch. There are none that I'm aware of though. http://cgit.osmocom.org/openbsc/commit/?id=c655f6bf311d4533c13309660eb5f9b2… commit c655f6bf311d4533c13309660eb5f9b2cb6c6631 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:57:22 2016 +0100 osmo-nitb: cosmetic: rename to rf_ctrl_path, following mncc_sock_path Strictly speaking, the unix domain socket location is not a name but a path. The MNCC socket is called path, so it is confusing to call the ctrl socket a 'name'. http://cgit.osmocom.org/openbsc/commit/?id=a180f6472cfaa7d89824a7777173cd0b… commit a180f6472cfaa7d89824a7777173cd0bf5af7aa2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:55:17 2016 +0100 osmo-nitb: add -M to pass specific MNCC socket path The old -m option without argument is still available and marked deprecated, to not make users' lives more difficult than necessary. http://cgit.osmocom.org/openbsc/commit/?id=271db46716db46adc5c65b018d11258b… commit 271db46716db46adc5c65b018d11258bb7a23a03 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:09:38 2016 +0100 enable telnet VTY bind address config for various programs Following the 'line vty'/'bind A.B.C.D' command added in libosmocore, use the configured address to set the telnet bind for the VTY line. It is now possible to publish the VTY on a specific local interface (including 0.0.0.0 aka "any"). Implement in all of: osmo-gbproxy osmo-gtphub osmo-sgsn osmo-bsc osmo-bsc_nat osmo-bsc_mgcp osmo-nitb In some of these main programs, move the telnet initialization below the configuration parsing. Historically, this was not a good idea for programs using bsc_init.c (aka bsc_bootstrap_network()), since they expected a gsm_network struct pointer in ((struct telnet_connection*)vty->priv)->priv, so that telnet had to be either initialized or replaced by a dummy struct. In the meantime, the gsm_network struct is not actually looked up in a priv pointer but in the static bsc_vty.c scope (bsc_gsmnet), so this limitation is mere legacy (even though said legacy is still there in an "#if 0" chunk). In the other binaries I have briefly looked at the init sequence dependencies and found no reason to initialize telnet above the config file parsing. In any case, I have tested every single one of abovementioned binaries to verify that they still parse the example config successfully and launch, allowing VTY connections on the configured address(es). I hope this suffices. In all of the above, log VTY address and port. LOGL_INFO is disabled by default in some of the logging scopes, and since it is a single log message right at program launch, I decided for the slightly more aggressive LOGL_NOTICE. http://cgit.osmocom.org/openbsc/commit/?id=18394fdbed069f03c2c7ad910632bfba… commit 18394fdbed069f03c2c7ad910632bfba84acdc04 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 19:30:52 2016 +0100 gsm340_rx_tpdu: comment-out two unused vars Kills two compiler warnings. http://cgit.osmocom.org/openbsc/commit/?id=75b580869498966c1359b7ab6588f7ac… commit 75b580869498966c1359b7ab6588f7ac80422337 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 19:29:59 2016 +0100 ipaccess_rcvmsg: fix returncode, add partial write warning Kills a compiler warning. http://cgit.osmocom.org/openbsc/commit/?id=d5dee43a03b6f8c34460d6f7e74f5bea… commit d5dee43a03b6f8c34460d6f7e74f5bea16d72439 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 03:12:44 2016 +0100 bsc_nat: fail if VTY telnet port cannot be bound, clarify comment http://cgit.osmocom.org/openbsc/commit/?id=f25f8cebb58ad1f5241a33d9bac76654… commit f25f8cebb58ad1f5241a33d9bac76654cd2a68a2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 19:31:33 2016 +0100 remove warning on 64bit, add warning on i386? ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/smpp.h | 4 +- openbsc/src/gprs/sgsn_ctrl.c | 2 +- openbsc/src/ipaccess/ipaccess-proxy.c | 8 +++- openbsc/src/libbsc/bsc_ctrl_lookup.c | 4 +- openbsc/src/libmsc/gsm_04_11.c | 7 ++- openbsc/src/libmsc/smpp_openbsc.c | 43 ++++++++++------- openbsc/src/libmsc/smpp_smsc.c | 90 +++++++++++++++++++++++++---------- openbsc/src/libmsc/smpp_smsc.h | 7 ++- openbsc/src/libmsc/smpp_vty.c | 75 ++++++++++++++++++++++++----- openbsc/src/osmo-bsc/osmo_bsc_vty.c | 4 +- openbsc/src/osmo-nitb/bsc_hack.c | 4 +- 11 files changed, 183 insertions(+), 65 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)