24 Aug
2015
24 Aug
'15
12:54 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/master has been updated
via 0eac0b6b43283fd7bcd6f8d7c7e55dc9ae97c516 (commit)
via c62216b4fc2a42ff9a8bea016565a772c585e2fb (commit)
via 6835cead8c9e13fbbbb7b100a4c18a031f92421f (commit)
via 6e013a136a9286e92cee0d9b5b4f0c7bcea5fd51 (commit)
via af387e2199de698fab9f180d68923c65b819be0c (commit)
via 444bc82081be0fd371805017a4c97b01cb41c15d (commit)
via 23c4b3f15899c0849fe63726fea404b9b215f103 (commit)
via af45473cd5b256e987515f0dc9d75ba604e5c5f1 (commit)
via cef20ae67a75b830cf024b5aa6dbc57ca9d07dbd (commit)
via ee31090b2e4204348f7b73d11abe2a07a723d6d8 (commit)
via 64921d217badb9f6938453174da6c2172a1e4cc6 (commit)
via 56f99d19c310b90632ac9b0b12898f4882f1020c (commit)
via e0b21f41c2b66d3f06a9aea5ac397857832671c8 (commit)
via 257b630216f0dc702013ecc51ac680b5296ae898 (commit)
via e91bd3babd5c04a154f296607b401a5050dcba31 (commit)
via b139598b1c5bd271675386be77370899b5707d61 (commit)
via 076f5c794d4af02914cd633671176437367b5af8 (commit)
via 537b149828be91189f99acc8d9c655b8a75b95ee (commit)
via 4a6fe534ce39b87f64a9b2013b654b92e6d7737d (commit)
via 2b349b5d33050f6484c375e545ecb9f05a6be961 (commit)
from ebebad1c92e8bcbe28780b4d5ee2ac32091089ff (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=0eac0b6b43283fd7bcd6f8d7c7e55dc…
commit 0eac0b6b43283fd7bcd6f8d7c7e55dc9ae97c516
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 16:02:11 2015 +0200
ms/vty: Show LLC queue octets and packets in both views
Currently the per IMSI/TLLI view only shows the number of packets and
the 'all' view does not show any LLC related information at all. This
information was really missing while debugging on a running system.
This commit adds the number of packets to the 'all' view and the
number of octets to the IMSI/TLLI views.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=c62216b4fc2a42ff9a8bea016565a77…
commit c62216b4fc2a42ff9a8bea016565a772c585e2fb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:46:16 2015 +0200
ms/vty: Show old TBFs
This commit extends the 'show ms imsi|tlli' command to show the old
TBFs, too.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=6835cead8c9e13fbbbb7b100a4c18a0…
commit 6835cead8c9e13fbbbb7b100a4c18a031f92421f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:24:02 2015 +0200
ms: Store references to replaced TBFs in the MS object
Currently when calling GprsMs::attach_tbf and a TBF of the same
direction already exists, the old TBF gets detached from the MS
object.
Therefore that TBF object loses access to that MS object including
for instance TLLI and IMSI.
This leads to failing DL TBF reuses, since the downlink assigment
cannot be sent on the PACCH later on because that must be sent on the
old DL TBF which ms() is NULL and the new DL TBF cannot be retrieved.
This commit fixes this bug by changing the GprsMs implementation to
keep a list of replaced (old) TBFs. TBFs are only removed when they
are being detached explicitely (see tbf_free and set_ms).
Addresses:
tbf.cpp:741 We have a schedule for downlink assignment at uplink
TBF(TFI=1 TLLI=0xf35a680e DIR=UL STATE=RELEASING), but there is no
downlink TBF
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=6e013a136a9286e92cee0d9b5b4f0c7…
commit 6e013a136a9286e92cee0d9b5b4f0c7bcea5fd51
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:10:23 2015 +0200
bssgp: Only call bssgp_tx_llc_discarded if the bctx exists
While this does not happen in real use, and unset btcx can lead to
segfaults in test cases. The other code outside of gprs_bssgp_pcu.cpp
does not depend on bctx being non-NULL:
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=af387e2199de698fab9f180d68923c6…
commit af387e2199de698fab9f180d68923c65b819be0c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 12:05:30 2015 +0200
llist: Add missing const qualifier in llist cast method
The missing const qualifier prevents the llist_empty() C++ wrapper
function from being compiled successfully when it is used.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=444bc82081be0fd371805017a4c97b0…
commit 444bc82081be0fd371805017a4c97b01cb41c15d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Aug 20 17:49:03 2015 +0200
tbf: Use C++/talloc magic to support TBF constructors/destructors
The TBF object are currently created by using talloc_zero/talloc_free
directly from plain functions. Therefore C++ constructors and destructors
are not called. So the only initialisation that is done is setting
every member to 0. Non POD members do not have their constructors
called either, which makes it impossible to use the current LListHead
class for real members when the LListHead::m_back member has to be set.
This commit changes the TBF allocation functions to call the
corresponding C++ constructor after the call to talloc_zero and to
register the C++ destructor with the talloc context, so that is is
called before talloc_free actually frees the memory.
With this change, non-POD members and custom
constructors/desctructors can be used with gprs_rlcmac_tbf,
gprs_rlcmac_dl_tbf, and gprs_rlcmac_ul_tbf.
Note that this change is only a single step of the plan to turn the
TBF classes into real C++ classes.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=23c4b3f15899c0849fe63726fea404b…
commit 23c4b3f15899c0849fe63726fea404b9b215f103
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:04:39 2015 +0200
tbf/test: Add test_tbf_dl_reuse
This tests the usage of an existing TBF that is no longer in FLOW
state to request a new DL TBF via the old TBF's PACCH.
The test triggers a bug that breaks the association between both TBF
objects, resulting in packet loss and transmission stalling.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=af45473cd5b256e987515f0dc9d75ba…
commit af45473cd5b256e987515f0dc9d75ba604e5c5f1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:03:23 2015 +0200
tbf/test: Do RLC based ack instead of just faking
Currently the assignment is completed by manipulating the state of
the TBF objects directly by setting the state fields to fixed values.
This way, the PCU's code that is responsible to update the state
accordingly is not tested.
This commit changes this to simulate RLC Control Acknowledgement
messages instead.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=cef20ae67a75b830cf024b5aa6dbc57…
commit cef20ae67a75b830cf024b5aa6dbc57ca9d07dbd
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Aug 24 12:00:33 2015 +0200
tbf/test: Rename send_rlc_block to request_dl_rlc_block
This function basically request the generation of the next downlink
RLC block. Since this will no really send somthing to the PCU, the
current name can be misleading.
This commit just renames the function.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ee31090b2e4204348f7b73d11abe2a0…
commit ee31090b2e4204348f7b73d11abe2a07a723d6d8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Aug 24 11:55:17 2015 +0200
tbf/test: Simplify RLC block number handling
The block number can always be deduced from the frame number. The
current test code handles the block number explicitely, which makes
the code more complex and has also led to block number errors cause
by not wrapping the numbers (valid block numbers range from 0 to 11).
This commit changes send_rlc_block to always compute the block number
based on the frame number. It also turns the block_nr into an
optionaly output-only parameter.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=64921d217badb9f6938453174da6c21…
commit 64921d217badb9f6938453174da6c2172a1e4cc6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Aug 24 11:34:47 2015 +0200
tbf/test: Add send_rlc_block function with a TBF as parameter
The current implementation takes a lot of parameters (bts, trx_no,
...) that can also be taken from a TBF object.
This commit adds an alternative variant with just takes a TBF, the fn
(in/out), and the block number (in/out).
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/bts.cpp | 15 +-
src/bts.h | 6 +
src/cxx_linuxlist.h | 2 +-
src/gprs_ms.cpp | 48 +-
src/gprs_ms.h | 12 +-
src/llc.cpp | 53 ++
src/llc.h | 1 +
src/pcu_vty_functions.cpp | 15 +-
src/tbf.cpp | 50 +-
src/tbf.h | 11 +
src/tbf_dl.cpp | 5 +-
tests/llc/LlcTest.cpp | 51 ++
tests/llc/LlcTest.err | 5 +
tests/llc/LlcTest.ok | 2 +
tests/llist/LListTest.cpp | 4 +
tests/ms/MsTest.cpp | 28 +-
tests/ms/MsTest.err | 2 +-
tests/tbf/TbfTest.cpp | 584 +++++++++++++++---
tests/tbf/TbfTest.err | 1456 +++++++++++++++++++++++++++++++++++++++++++--
tests/tbf/TbfTest.ok | 8 +
20 files changed, 2194 insertions(+), 164 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT