osmocom-commitlog

osmocom-commitlog@lists.osmocom.org

7948 discussions

osmo-iuh.git branch master updated. c23c4fe06c543648a7c7dc429ce50f5cf79abe3a
by gitosis＠osmocom.org 30 Mar '17

30 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via c23c4fe06c543648a7c7dc429ce50f5cf79abe3a (commit) from 2c45e9082afada5249a7347a35bd8812a88b5aa7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=c23c4fe06c543648a7c7dc429ce50f5… commit c23c4fe06c543648a7c7dc429ce50f5cf79abe3a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 29 17:07:02 2017 +0200 doc: fix osmo-hnbgw.cfg example 'bind' was changed to local-ip in 39ee92606213a9fd36b10183bb461fa6e2d3a407 The 'logging all everything' is known to not work, use 'all debug' instead. Fix indenting of the 'log' items. Change-Id: Ie7828073a4b4a5555f418246b20588e903ef4135 ----------------------------------------------------------------------- Summary of changes: doc/examples/osmo-hnbgw.cfg | 43 ++++++++++++++++++------------------------- 1 file changed, 18 insertions(+), 25 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface

1 0

openbsc.git branch vlr_3G updated. 0.15.0-750-g2e8ecf3af
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, vlr_3G has been updated discards ed868ec1e68de7a359ae5c1bd8147e2524f0bb11 (commit) discards 33f428ed51165a2e3da2d6ed95ddd2ae47787a30 (commit) discards ef86d12d62695148154b6099812867464806a66c (commit) discards b42b32736912acf7a178dec6a00efebdbd6feaad (commit) via 2e8ecf3af3c1ffab29357f45e4576b2d3b9268e4 (commit) via 581ffc9d7bee9b6ea238fc2014007aab4cbe5315 (commit) via 0aae05474790bf1d3b4d7ce369611892873443b5 (commit) via a2697738cc08e2e6528c09bb7775f1793cff37b8 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (ed868ec1e68de7a359ae5c1bd8147e2524f0bb11) \ N -- N -- N (2e8ecf3af3c1ffab29357f45e4576b2d3b9268e4) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=2e8ecf3af3c1ffab29357f45e4576b2d… commit 2e8ecf3af3c1ffab29357f45e4576b2d3b9268e4 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:09:47 2016 +0200 temporary dev: set debug log level almost everywhere Change-Id: I0d5a36560e7edde27497de57e579f5b1d00eb525 http://cgit.osmocom.org/openbsc/commit/?id=581ffc9d7bee9b6ea238fc2014007aab… commit 581ffc9d7bee9b6ea238fc2014007aab4cbe5315 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Mar 10 02:15:20 2017 +0100 log protocol discriminators and message types by name Depends: libosmocore change-id I0fca8e95ed5c2148b1a7440eff3fc9c7583898df Change-Id: If1c49faf6e1757cb16b383dd2db87b48bc94eee6 http://cgit.osmocom.org/openbsc/commit/?id=0aae05474790bf1d3b4d7ce369611892… commit 0aae05474790bf1d3b4d7ce369611892873443b5 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Mar 16 16:14:34 2017 +0100 mgcp: hack RAB success from nano3G: patch first RTP payload The ip.access nano3G needs the first RTP payload's first two bytes to read hex 'e400', or it will reject the RAB assignment. Add flag patched_first_rtp_payload to mgcp_rtp_state to detect the first RTP payload on a stream, and overwrite its first bytes with e400. This should probably be configurable, but seems to not harm other femto cells (as long as we patch only the first RTP payload in each stream). Only do this when sending to the BTS side. Change-Id: I31a4475f42d59fd5704d52ee6e473e270db6d779 http://cgit.osmocom.org/openbsc/commit/?id=a2697738cc08e2e6528c09bb7775f179… commit a2697738cc08e2e6528c09bb7775f1793cff37b8 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri May 20 21:59:55 2016 +0200 Implement IuCS (large refactoring and addition) osmo-nitb becomes osmo-msc add DIUCS debug log constant add iucs.[hc] add msc vty, remove nitb vty add libiudummy, to avoid linking Iu deps in tests Use new msc_tx_dtap() instead of gsm0808_submit_dtap() libmgcp: add mgcpgw client API bridge calls via mgcpgw mgcp: hack RAB success from nano3G: patch first RTP payload The ip.access nano3G needs the first RTP payload's first two bytes to read hex 'e400', or it will reject the RAB assignment. Add flag patched_first_rtp_payload to mgcp_rtp_state to detect the first RTP payload on a stream, and overwrite its first bytes with e400. This should probably be configurable, but seems to not harm other femto cells (as long as we patch only the first RTP payload in each stream). Only do this when sending to the BTS side. Change-Id: Ie13ff348117e892d41b8355ab6c24915301eaeaf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/examples/osmo-bsc_mgcp/mgcp.cfg | 8 +- openbsc/doc/examples/osmo-msc/osmo-msc.cfg | 1 + .../osmo-nitb/bs11/openbsc-1bts-2trx-hopping.cfg | 164 --------------- .../examples/osmo-nitb/bs11/openbsc-1bts-2trx.cfg | 84 -------- .../examples/osmo-nitb/bs11/openbsc-2bts-2trx.cfg | 148 -------------- openbsc/doc/examples/osmo-nitb/bs11/openbsc.cfg | 56 ------ .../osmo-nitb/nanobts/openbsc-multitrx.cfg | 99 ---------- openbsc/doc/examples/osmo-nitb/nanobts/openbsc.cfg | 77 -------- .../osmo-nitb/nokia/openbsc_nokia_3trx.cfg | 117 ----------- openbsc/doc/examples/osmo-nitb/rbs2308/openbsc.cfg | 220 --------------------- .../doc/examples/osmo-nitb/sysmobts/openbsc.cfg | 77 -------- 11 files changed, 5 insertions(+), 1046 deletions(-) delete mode 100644 openbsc/doc/examples/osmo-nitb/bs11/openbsc-1bts-2trx-hopping.cfg delete mode 100644 openbsc/doc/examples/osmo-nitb/bs11/openbsc-1bts-2trx.cfg delete mode 100644 openbsc/doc/examples/osmo-nitb/bs11/openbsc-2bts-2trx.cfg delete mode 100644 openbsc/doc/examples/osmo-nitb/bs11/openbsc.cfg delete mode 100644 openbsc/doc/examples/osmo-nitb/nanobts/openbsc-multitrx.cfg delete mode 100644 openbsc/doc/examples/osmo-nitb/nanobts/openbsc.cfg delete mode 100644 openbsc/doc/examples/osmo-nitb/nokia/openbsc_nokia_3trx.cfg delete mode 100644 openbsc/doc/examples/osmo-nitb/rbs2308/openbsc.cfg delete mode 100644 openbsc/doc/examples/osmo-nitb/sysmobts/openbsc.cfg hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch pmaier/aoip updated. 0.9.6-168-g19b593f
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, pmaier/aoip has been updated discards f398e03d096ff2ea2cfaf10344cc90e3f30cad0a (commit) discards 798655636bcaa00f6bc5fc443e987be0bc9934b7 (commit) discards 682106bc2ab321cffbacff8b0778318dd8f19022 (commit) discards c01db44414f5697af468fe62eea6d649e5c27734 (commit) discards 04dd1d71fe5dc41d050b5b9e935faefc5f6b45ba (commit) discards 22281de99bcafbdb67471214db7afaf7c7949bfc (commit) discards 58e8088ddd1c4821c70b5632c859fc2fe7340d3d (commit) via 19b593fb0be6993365a0d15f35f4870a6367eeec (commit) via 1e61e87b967e6ef54f8913b2e91cb7fd8e687ee9 (commit) via 6419635b322cf25f9d7a4b1dffc016942ad41457 (commit) via 5fff76a1298b3ed6418e0e52bf75905f25972745 (commit) via 5e216c86f2967321e8e91ad65ef8660d4acd5e90 (commit) via 4b0733a39401b096b55fbf2ed9c242beb52ed979 (commit) via 00a1eb4deb90081fa33dcb9145ce67b460baa042 (commit) via d78c973cd89fc7c119573357cfbebb891dbc697a (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (f398e03d096ff2ea2cfaf10344cc90e3f30cad0a) \ N -- N -- N (19b593fb0be6993365a0d15f35f4870a6367eeec) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=19b593fb0be6993365a0d15f35f4… commit 19b593fb0be6993365a0d15f35f4870a6367eeec Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Wed Mar 29 15:50:05 2017 +0200 gsm0808: Add create functions for CIPHER MODE COMMAND gsm0808.h/c lacks functionality to generate CIPHER MODE COMMAND messages. These messages are required if the code is used in an MSC implementation. This commit adds a gsm0808_create_cipher() function, that generates an A/AoiP CIPHER MODE COMMAND message. http://cgit.osmocom.org/libosmocore/commit/?id=1e61e87b967e6ef54f8913b2e91c… commit 1e61e87b967e6ef54f8913b2e91cb7fd8e687ee9 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Wed Mar 29 11:35:50 2017 +0200 gsm0808: Add utils for Cell Identifier List The planned support for true A over IP requires the encoding of the a Cell Identifier List element (see also BSS_MAP_MSG_PAGING). This commt adds encoding/decoding functionality and tests for the element mentioned above, however, it is not yet actively used. http://cgit.osmocom.org/libosmocore/commit/?id=6419635b322cf25f9d7a4b1dffc0… commit 6419635b322cf25f9d7a4b1dffc016942ad41457 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Tue Mar 28 18:36:52 2017 +0200 gsm0808: Add utils for Encryption Information The planned support for true A over IP requires the encoding of the an Encryption Information element (see also BSS_MAP_MSG_CIPHER_MODE_CMD). This commt adds encoding/decoding functionality and tests for the element mentioned above, however, it is not yet actively used. http://cgit.osmocom.org/libosmocore/commit/?id=5fff76a1298b3ed6418e0e52bf75… commit 5fff76a1298b3ed6418e0e52bf75905f25972745 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Tue Mar 28 17:05:40 2017 +0200 gsm0808: Add utils for Channel Type The planned support for true A over IP requires the encoding of the a Channel Type element (see also ASSIGNMENT REQUEST). This commt adds encoding/decoding functionality and tests for the element mentioned above, however, it is not yet actively used. http://cgit.osmocom.org/libosmocore/commit/?id=5e216c86f2967321e8e91ad65ef8… commit 5e216c86f2967321e8e91ad65ef8660d4acd5e90 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Mon Mar 27 16:55:32 2017 +0200 gsm0808: Add AoIP specific elements to gsm0808_create_... functions the classic A implementation in libosmocore lacks support for AoIP message elements. This patch adds support for AoIP by adding a set of new gsm0808_create_..., which support the missing AoIP message elements http://cgit.osmocom.org/libosmocore/commit/?id=4b0733a39401b096b55fbf2ed9c2… commit 4b0733a39401b096b55fbf2ed9c242beb52ed979 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Fri Mar 24 18:03:17 2017 +0100 gsm0808: Add utils for Speech Codec List and Speech Codec The planned support for true A over IP requires the encoding and decoding of a so called "Speech Codec Element" element. This commt adds parsing functionality and tests for the element mentioned above, however, it is not yet actively used. http://cgit.osmocom.org/libosmocore/commit/?id=00a1eb4deb90081fa33dcb9145ce… commit 00a1eb4deb90081fa33dcb9145ce67b460baa042 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Fri Mar 24 17:59:26 2017 +0100 gsm0808: Add utils for AoIP Transport Layer Address The planned support for true A over IP requires the encoding and decoding of a so called "AoIP Transport Layer Address" element. This commt adds parsing functionality and tests for the element mentioned above, however, it is not yet actively used. ----------------------------------------------------------------------- Summary of changes: src/gsm/gsm0808.c | 20 ++++++++++++++++++++ src/gsm/lapd_core.c | 10 +++++----- 2 files changed, 25 insertions(+), 5 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

libosmocore.git branch pmaier/aoip updated. 0.9.6-167-gf398e03
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

1 0

libosmocore.git branch master updated. 0.9.6-161-gd78c973
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via d78c973cd89fc7c119573357cfbebb891dbc697a (commit) from 7f9c7e7b8b194d9ebdd9de1fd8c0a5457b1e20e7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=d78c973cd89fc7c119573357cfbe… commit d78c973cd89fc7c119573357cfbebb891dbc697a Author: Jean-Francois Dionne <jf.dionne(a)nutaq.com> Date: Mon Mar 6 14:33:20 2017 -0500 Fix LAPD UA message buffer memory leak. The state check in lapd_dl_reset causes some buffers never to be released. Using talloc report LAPD UA message buffers are never released after each call and cause a memory leak. Change-Id: I2799b70623f2ec4dbc725eb213e332e98da02a3e ----------------------------------------------------------------------- Summary of changes: src/gsm/lapd_core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

libosmo-abis.git branch master updated. 0.3.2-65-g5e87fdf
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via 5e87fdfcabc9cabe0025d7350b7ab31cdc4b6fa3 (commit) from c42bf19cc5ebb7b675fc14b57a8e3946cbeb5e60 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=5e87fdfcabc9cabe0025d7350b7… commit 5e87fdfcabc9cabe0025d7350b7ab31cdc4b6fa3 Author: Jean-Francois Dionne <jf.dionne(a)nutaq.com> Date: Mon Mar 6 13:22:37 2017 -0500 Fix RTP jitter buffer that never stop to increase. Duration passed to osmo_rtp_send_frame_ext function is based on the last frame and the current one. Duration must then be added to the timestamp before being transmitted. Change-Id: I0593d6530c097cca34125a0ae2dd1b019b4dd80d ----------------------------------------------------------------------- Summary of changes: src/trau/osmo_ortp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom A-bis protcol interface library

1 0

libosmo-netif.git branch master updated. 0.0.6-46-g5fe77a4
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom network interface library". The branch, master has been updated via 5fe77a4656f3590c343861ea96bcec18e370e437 (commit) from db9808e883b3048c0383e71985e02fcb377b0d56 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-netif/commit/?id=5fe77a4656f3590c343861ea96… commit 5fe77a4656f3590c343861ea96bcec18e370e437 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Wed Jan 6 16:41:44 2016 +0100 stream.c: Handle SCTP in osmo_stream_srv_recv() Change-Id: If0875cfa3eba9ef36acc0c4bfd0d168a45c380b9 ----------------------------------------------------------------------- Summary of changes: src/stream.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 57 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom network interface library

1 0

libosmo-abis.git branch master updated. 0.3.2-64-gc42bf19
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via c42bf19cc5ebb7b675fc14b57a8e3946cbeb5e60 (commit) from 1e04d4b7a2c845589da20d891cc5e3c471cfe983 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=c42bf19cc5ebb7b675fc14b57a8… commit c42bf19cc5ebb7b675fc14b57a8e3946cbeb5e60 Author: Pau Espin Pedrol <pespin.shar(a)gmail.com> Date: Fri Mar 24 17:26:49 2017 +0100 configure: Fix compilation with new libortp Commit 0c8d9ddaea8c1afdc0e9b8c37a31c9d158e57efd in ortp broke old API: function ortp_set_log_level_mask requires one new parameter 'domain'. This commit fixes compilation in my Archlinux box using ortp 1.0.1. Change-Id: I46e565f1873c7baf3c3b0aafe73951d20ce083b4 ----------------------------------------------------------------------- Summary of changes: configure.ac | 10 ++++++++++ src/trau/osmo_ortp.c | 14 +++++++++++--- 2 files changed, 21 insertions(+), 3 deletions(-) hooks/post-receive -- Osmocom A-bis protcol interface library

1 0

osmo-bts.git branch master updated. 0.4.0-414-ge16b593
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via e16b59357411ffa4903ac110ac4ce46d343e878d (commit) from 957843959d4d9046b4eb5beb42cc41dd7bb56bed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=e16b59357411ffa4903ac110ac4ce46… commit e16b59357411ffa4903ac110ac4ce46d343e878d Author: Max <msuraev(a)sysmocom.de> Date: Thu Mar 23 12:44:33 2017 +0100 vty: reduce code duplication Use libosmocore's osmo_str2lower() instead of local equivalent. Change-Id: I7faced2eaf0f6f87f06081235eea9d4c3ba71a7e ----------------------------------------------------------------------- Summary of changes: src/common/vty.c | 38 ++++++-------------------------------- 1 file changed, 6 insertions(+), 32 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

1 0

osmo-pcu.git branch master updated. 0.2-900-ge6d26ec
by gitosis＠osmocom.org 29 Mar '17

29 Mar '17

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via e6d26ec09c2bcd2126416a58cb23af27318ec67e (commit) via 5382e0fc1f5c30532b5b2b322601c9d4a8d4f982 (commit) via dd1700a397379e9383b9577fca09738b3251fc7c (commit) via 7783964bb92af9ef6a1d1d12a6b804aab48945b0 (commit) from 0a8fae8d141c2cfa4387ffe9b35402d5b8cc85cd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=e6d26ec09c2bcd2126416a58cb23af2… commit e6d26ec09c2bcd2126416a58cb23af27318ec67e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 27 00:13:14 2017 +0200 bitcomp test: use expected rc instead of 'verify' flag The 'verify' flag is useless, we always want to verify everything. Replace 'verify' with 'expect_rc', expecting a specific decoding result per test set. When an error code was returned, cut short the loop and skip printing expected vs. decoded bits. This uncovers the fact that the first test marked as "invalid inputs" does not seem to be invalid after all, or at least does not produce an error to be returned. For now, only uncover this fact, the fix shall be submitted later. Change-Id: Icf815a8f1acb0e275463408450171df046879847 http://cgit.osmocom.org/osmo-pcu/commit/?id=5382e0fc1f5c30532b5b2b322601c9d… commit 5382e0fc1f5c30532b5b2b322601c9d4a8d4f982 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Mar 26 23:39:44 2017 +0200 bitcomp test: fix: also verify bits after decoded data Before this, the expected data had seemingly random bits set after the end of the expected decoding result. Make the test expect these extra bits as zero, matching with the buffer initialization to zero. In result_matches(), compare the full length of bytes instead of masking the bits after the end of the decoded data (which caused us to not catch the wrong expectation until now). This fixes the underlying issues found in http://lists.osmocom.org/pipermail/osmocom-net-gprs/2017-March/000876.html [osmo-pcu 0.2.896-0a8f] testsuite: 4 failed from: Arnaud ZANETTI on: Fri Mar 24 09:53:53 UTC 2017 Change-Id: I2501208e2f8b4f709efbcadbd1057c086472c9e6 http://cgit.osmocom.org/osmo-pcu/commit/?id=dd1700a397379e9383b9577fca09738… commit dd1700a397379e9383b9577fca09738b3251fc7c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Mar 26 23:21:16 2017 +0200 bitcomp test: fix: only one hexdump per log; use printf The test wants to write multiline results, so it should use printf instead of the logging system. Split logs to only one hexdump per printf(). One cannot use osmo_hexdump twice in one printf(); before this, one of the two hexdumps won, both dumps would show as the same. Very bad for a regression test! This uncovers a discrepancy between expected and produced results, proving that the expected stderr output was not capable of uncovering test failures. The test's check_result() function *has* always verified the decoded data, but only up to the last decoded bit. Our expected data contains seemingly random bits after the end of the decoded bits, but check_result() never compares those, hence we don't catch that error. The extra bits should definitely be zero, because the destination buffer is pre-initialized to zero -- fixed in a subsequent patch. This should cosmetically fix the build failure found in: http://lists.osmocom.org/pipermail/osmocom-net-gprs/2017-March/000876.html [osmo-pcu 0.2.896-0a8f] testsuite: 4 failed from: Arnaud ZANETTI on: Fri Mar 24 09:53:53 UTC 2017 The real fix will follow. Change-Id: I24fc32eb55baaf22f9c6fdda917bfb8395d02b1c http://cgit.osmocom.org/osmo-pcu/commit/?id=7783964bb92af9ef6a1d1d12a6b804a… commit 7783964bb92af9ef6a1d1d12a6b804aab48945b0 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Mar 26 23:12:26 2017 +0200 cosmetic: BitcompTest: make readable In order to understand what the bitcomp test is logging, cosmetically rearrange the code: - memset bits_data before assigning to destination bitvec. - use macro CEIL_DIV_8 to clarify what (x+7)/8 does. - rename check_result() to result_matches() and return a bool, also constify result_matches() args and pass a bitvec reference instead of copying the bitvec struct. - rearrange logging lines to make readable what is going on there. - drop unused 'init_flag' There are obviously errors like double hexdumps per log line, multiple newlines in a LOGP statement and so forth: these shall be fixed by subsequent patches. Change-Id: Id0da9d9b67f4713d3a67e3532ed44b8cb1bd1d08 ----------------------------------------------------------------------- Summary of changes: tests/bitcomp/BitcompTest.cpp | 132 ++++++++++++++++++++++-------------------- tests/bitcomp/BitcompTest.err | 33 +++++------ 2 files changed, 85 insertions(+), 80 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog