osmocom-commitlog October 2015

osmocom-commitlog@lists.osmocom.org

1 participants
121 discussions

osmo-trx.git branch master updated. 283b22dbce4d6f7129fd3323a65baa6646619190
by gitosis＠osmocom.org 22 Oct '15

22 Oct '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, master has been updated via 283b22dbce4d6f7129fd3323a65baa6646619190 (commit) from f147b174475171cdf79ccba25a5e66fec282efcd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-trx/commit/?id=283b22dbce4d6f7129fd3323a65baa6… commit 283b22dbce4d6f7129fd3323a65baa6646619190 Author: Tom Tsou <tom.tsou(a)ettus.com> Date: Wed Oct 21 17:10:23 2015 -0700 uhd: Remove references to USRP B205 Certain pre-release versions of the B200mini used the B205 naming, which no longer exists. Update device naming and detection to reflect current UHD product names. Signed-off-by: Tom Tsou <tom.tsou(a)ettus.com> ----------------------------------------------------------------------- Summary of changes: Transceiver52M/UHDDevice.cpp | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) hooks/post-receive -- OpenBTS' transceiver retro-fit

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-46-gfc0b777
by gitosis＠osmocom.org 21 Oct '15

21 Oct '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/gtphub has been updated via fc0b77724cdaf86ec938b20492e88f290cccbf58 (commit) via 4bf5dfb8e87d7f4392deec0ea404fb00c1c2bd72 (commit) via e79008f1e5e0e6ef3c0a14bae54aa7b2d04d29bd (commit) via f70a80bc494fedb21e88c3e6a830fd94fe120649 (commit) via efa0d4b7e9810cebfb000562283054aee127a602 (commit) via 8839922a09ea16812f0c3b1a2deba7172da82d85 (commit) via 434ad03c57d9e825f048b498ef2c74c6c1a7fddc (commit) via 40b6a4e0262607ee345e55ebc42522b03ea329a4 (commit) via dc5d124684e949c6392e01616b1155b9cc175231 (commit) via 7b66cf19c70a4733177ecba36950bf9994a8cecb (commit) via 5fcfe5de74bef8c6bf49bad709d8d9600499931e (commit) via c223e5f521f401b1a431321ac649cffcc415c12b (commit) from 512816e44f0dafa9e99d69b5566a1752315712e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=fc0b77724cdaf86ec938b20492e88f29… commit fc0b77724cdaf86ec938b20492e88f290cccbf58 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 02:43:48 2015 +0200 nr map del_cb http://cgit.osmocom.org/openbsc/commit/?id=4bf5dfb8e87d7f4392deec0ea404fb00… commit 4bf5dfb8e87d7f4392deec0ea404fb00c1c2bd72 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 02:41:50 2015 +0200 nr map _add() api http://cgit.osmocom.org/openbsc/commit/?id=e79008f1e5e0e6ef3c0a14bae54aa7b2… commit e79008f1e5e0e6ef3c0a14bae54aa7b2d04d29bd Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 02:13:03 2015 +0200 tei->nr http://cgit.osmocom.org/openbsc/commit/?id=f70a80bc494fedb21e88c3e6a830fd94… commit f70a80bc494fedb21e88c3e6a830fd94fe120649 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 02:07:52 2015 +0200 seqmap test http://cgit.osmocom.org/openbsc/commit/?id=efa0d4b7e9810cebfb000562283054ae… commit efa0d4b7e9810cebfb000562283054aee127a602 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 02:07:44 2015 +0200 publish seqmap http://cgit.osmocom.org/openbsc/commit/?id=8839922a09ea16812f0c3b1a2deba717… commit 8839922a09ea16812f0c3b1a2deba7172da82d85 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 02:07:18 2015 +0200 nr_t http://cgit.osmocom.org/openbsc/commit/?id=434ad03c57d9e825f048b498ef2c74c6… commit 434ad03c57d9e825f048b498ef2c74c6c1a7fddc Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 01:22:29 2015 +0200 gtphub: shorten / unify seq map naming. Also drop a duplicate OSMO_ASSERT. http://cgit.osmocom.org/openbsc/commit/?id=40b6a4e0262607ee345e55ebc42522b0… commit 40b6a4e0262607ee345e55ebc42522b03ea329a4 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 01:13:32 2015 +0200 gtphub: fix seq map: don't map the same seq twice. http://cgit.osmocom.org/openbsc/commit/?id=dc5d124684e949c6392e01616b1155b9… commit dc5d124684e949c6392e01616b1155b9cc175231 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 01:06:29 2015 +0200 gtphub: split two seq map functions. Separate GTP packet specifics from sequence mapping maintenance. No functional change. http://cgit.osmocom.org/openbsc/commit/?id=7b66cf19c70a4733177ecba36950bf99… commit 7b66cf19c70a4733177ecba36950bf9994a8cecb Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 21 00:12:15 2015 +0200 gtphub: drop peers when empty. Use the gtphub_peer.ref_count to track active sequence mappings from other peers. If a peer has neither sequence mappings to other peers nor other peers with mappings to itself, drop it. http://cgit.osmocom.org/openbsc/commit/?id=5fcfe5de74bef8c6bf49bad709d8d960… commit 5fcfe5de74bef8c6bf49bad709d8d9600499931e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Oct 20 23:40:42 2015 +0200 gtphub: expire seq nr mappings. Implement a gc ("garbage collection") timer and drop expired sequence mappings once per second. Rename seq_mapping.timeout to expiry and change type to time_t. Implement basic functions to get current time value and future expiry value. Reverse stored order of seq_mappings to yield a sorting in ascending order of expiry. This may not scale well for numerous peers, as for every gc cycle, every peer is visited, even if none of them have pending timeouts. (A peer is an SGSN or a GGSN, so there shouldn't be too many, right?) http://cgit.osmocom.org/openbsc/commit/?id=c223e5f521f401b1a431321ac649cffc… commit c223e5f521f401b1a431321ac649cffcc415c12b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Oct 20 23:29:46 2015 +0200 comments ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gtphub.h | 85 +++++++---- openbsc/src/gprs/gtphub.c | 281 ++++++++++++++++++++++++++++--------- openbsc/tests/gtphub/gtphub_test.c | 38 +++-- 3 files changed, 293 insertions(+), 111 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch jerlbeck/wip/stats updated. 0.8.0-68-g6db0815
by gitosis＠osmocom.org 20 Oct '15

20 Oct '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, jerlbeck/wip/stats has been updated via 6db08153f557635368e6869d9c905cb5fbd37f08 (commit) via 306175d38d46fe8125b9de2da2db0e7ee8b462b8 (commit) via 397f69b1bdf177231dbf04672e5c4e1f8986d46a (commit) via 1887cb3bad5c2da452915450a8e9c72062d12e2d (commit) via 034facebe3c2b51c9b2b8c3fd39cc7ab4d94053c (commit) via 21b76b289a38fc73fe338c2b6e9a11fb4489e7a3 (commit) via d15fcd6d2db616b4b2123f062966bbc313261187 (commit) via 02906e0f1cfb1a4fb782c3badd7f598d57fab86c (commit) via c94cc5c013c10f1d1d3c485d7d4e11e5d26507fd (commit) from bb564f424f1b28e342a8bfb61d3280be39c0f332 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=6db08153f557635368e6869d9c90… commit 6db08153f557635368e6869d9c905cb5fbd37f08 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 20 19:05:52 2015 +0200 WIP: statistics (TODO) TODO: - cleanup and sort commits - commit messages - add timer based output - support stat items - add MTU support - remove enable/disable test hack status: - statsd is sent for modified counters when disabling/enabling the reporter Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=306175d38d46fe8125b9de2da2db… commit 306175d38d46fe8125b9de2da2db0e7ee8b462b8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Oct 19 15:14:13 2015 +0200 stats/vty: Add stats_vty.c This file will contain the VTY code related to statistics. This commit adds a minimal file with just as single VTY command: - show stats This command shows all statistical values To enable this and future commands, the main program needs to call stats_vty_add_cmds(). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=397f69b1bdf177231dbf04672e5c… commit 397f69b1bdf177231dbf04672e5c4e1f8986d46a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Oct 19 15:11:50 2015 +0200 stat/vty: Add vty_out_statistics_full to show all statistics This functions shows the state of all osmo_counters, stat_item groups, and counter groups. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=1887cb3bad5c2da452915450a8e9… commit 1887cb3bad5c2da452915450a8e9c72062d12e2d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Oct 19 15:06:01 2015 +0200 stat/vty: Use the iterator algorithms to show ctrg and statg Currently the groups for stat_items and counter are iterated manually. This commit makes use of the new iterator functions to access the single elements via handlers. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=034facebe3c2b51c9b2b8c3fd39c… commit 034facebe3c2b51c9b2b8c3fd39cc7ab4d94053c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Oct 19 15:00:59 2015 +0200 core: Update osmo_counters_for_each doc Fix type and add a note about the semantics of the handler's return code. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=21b76b289a38fc73fe338c2b6e9a… commit 21b76b289a38fc73fe338c2b6e9a11fb4489e7a3 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Oct 19 14:04:38 2015 +0200 WIP add stat_item_for_each functions Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=d15fcd6d2db616b4b2123f062966… commit d15fcd6d2db616b4b2123f062966bbc313261187 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Oct 19 14:03:28 2015 +0200 WIP update rate_ctr discard doc Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=02906e0f1cfb1a4fb782c3badd7f… commit 02906e0f1cfb1a4fb782c3badd7f598d57fab86c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Oct 19 13:45:42 2015 +0200 core: Extend rate_ctr by helper functions For global value reporting, some additional helper functions are needed. The statsd protocol expects differential counter values, which are currently not provided by rate_ctr (except for s/m/h/d intervals). This commit adds several helper functions to rate_ctr: - rate_ctr_difference returns the counter delta since the last call to this function for a given counter - rate_ctr_for_each_counter iterates through each counter of a group - rate_ctr_for_each_group iterates through all globally registered counter groups Note that the rate_ctr_difference function can only be used by a single backend, since it modifies the 'previous' field in the rate_ctr obj. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=c94cc5c013c10f1d1d3c485d7d4e… commit c94cc5c013c10f1d1d3c485d7d4e11e5d26507fd Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Oct 12 18:47:09 2015 +0200 WIP: Use global index (TODO) Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: include/Makefile.am | 2 + include/osmocom/core/rate_ctr.h | 19 ++ include/osmocom/core/stat_item.h | 44 +++-- include/osmocom/core/statistics.h | 4 +- include/osmocom/core/stats.h | 70 ++++++++ include/osmocom/vty/command.h | 1 + include/osmocom/vty/misc.h | 2 + include/osmocom/vty/stats.h | 4 + src/Makefile.am | 2 +- src/rate_ctr.c | 41 +++++ src/stat_item.c | 101 ++++++++--- src/stats.c | 369 ++++++++++++++++++++++++++++++++++++++ src/vty/Makefile.am | 2 +- src/vty/stats_vty.c | 311 ++++++++++++++++++++++++++++++++ src/vty/utils.c | 121 ++++++++++--- tests/stats/stats_test.c | 43 +++-- tests/vty/vty_test.ok | 6 +- 17 files changed, 1067 insertions(+), 75 deletions(-) create mode 100644 include/osmocom/core/stats.h create mode 100644 include/osmocom/vty/stats.h create mode 100644 src/stats.c create mode 100644 src/vty/stats_vty.c hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-34-g512816e
by gitosis＠osmocom.org 19 Oct '15

19 Oct '15

1 0

openggsn.git branch neels/refactor updated. 0.91-81-gdce814f
by gitosis＠osmocom.org 19 Oct '15

19 Oct '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, neels/refactor has been updated discards 966ceecc3f72844e327d0fd85943655610299612 (commit) discards b72c2dc592bdaa2be86ea5b5f00a51599687c32e (commit) discards b84545e30e327b429b7910dc4675b9e3e80df704 (commit) discards ea458f4aa63e1a371a094d804ec4eb6ea6f8dfdd (commit) discards 85c25ac91c5fe6e87e1c417ea3543149a92d4145 (commit) discards 9a5cfa49ad1ce6d2cf6e9295a423e880d72dd1b5 (commit) via dce814f71cf29b6b7e4ddcb64bcc45dfebff445f (commit) via 96848945866fc9a34309a3a1bcc5a8b52f1baf2e (commit) via 9036950deaac54661cdaed54a1589b31ba6069e4 (commit) via 065476d192459e710348ece10895245c9a8bfffc (commit) via af9ba522f5fc1a4155af56cdac2cc2012247b48e (commit) via ea600c9c026f07e2ac96c676726a8b84710d84fb (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (966ceecc3f72844e327d0fd85943655610299612) \ N -- N -- N (dce814f71cf29b6b7e4ddcb64bcc45dfebff445f) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openggsn/commit/?id=dce814f71cf29b6b7e4ddcb64bcc45d… commit dce814f71cf29b6b7e4ddcb64bcc45dfebff445f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 13:07:40 2015 +0200 gtpie_gettlv(): fix return value on specific error. Make gtpie_gettlv() return an error if gtpie_getie() returned an error. Previously, openggsn would fail to complain about certain missing elements. Technically, a missing IE could be detectable from the *length value, but the code in gtp.c relies on the return value to detect missing elements, which did not work prior to this commit. For example: if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l, &pdp->eua.v, sizeof(pdp->eua.v))) { gsn->missing++; GTP_LOGPKG(LOGL_ERROR, peer, pack, len, "Missing mandatory information field\n"); return gtp_create_pdp_resp(gsn, version, pdp, GTPCAUSE_MAN_IE_MISSING); } If an EUA were missing in this code path, openggsn would fail to issue an error message. Since pdp and hence pdp->eua.l is initialized as all-zero, it would probably not do much harm besides failing to issue an error. I haven't checked all callers though. http://cgit.osmocom.org/openggsn/commit/?id=96848945866fc9a34309a3a1bcc5a8b… commit 96848945866fc9a34309a3a1bcc5a8b52f1baf2e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 14:13:51 2015 +0200 gitignore: add 'compile' (from autoconf) http://cgit.osmocom.org/openggsn/commit/?id=9036950deaac54661cdaed54a1589b3… commit 9036950deaac54661cdaed54a1589b31ba6069e4 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 13:26:39 2015 +0200 sgsnemu: improve an error message http://cgit.osmocom.org/openggsn/commit/?id=065476d192459e710348ece10895245… commit 065476d192459e710348ece10895245c9a8bfffc Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 13:24:51 2015 +0200 cosmetic: gtpie_gettv0(): flow readability http://cgit.osmocom.org/openggsn/commit/?id=af9ba522f5fc1a4155af56cdac2cc20… commit af9ba522f5fc1a4155af56cdac2cc2012247b48e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 12 14:26:49 2015 +0200 comments: add/replace. Sponsored-by: On-Waves ehi http://cgit.osmocom.org/openggsn/commit/?id=ea600c9c026f07e2ac96c676726a8b8… commit ea600c9c026f07e2ac96c676726a8b84710d84fb Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Oct 11 23:44:00 2015 +0200 comments: fix spelling/punctuation. Fix spelling/punctuation and one numbering in comments. Remove an opening brace from a comment to not mix up cindent in vim. Sponsored-by: On-Waves ehi ----------------------------------------------------------------------- Summary of changes: sgsnemu/sgsnemu.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) hooks/post-receive -- The OpenGGSN project

1 0

openggsn.git branch neels/refactor updated. 0.91-81-g966ceec
by gitosis＠osmocom.org 19 Oct '15

19 Oct '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, neels/refactor has been updated via 966ceecc3f72844e327d0fd85943655610299612 (commit) from b72c2dc592bdaa2be86ea5b5f00a51599687c32e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openggsn/commit/?id=966ceecc3f72844e327d0fd85943655… commit 966ceecc3f72844e327d0fd85943655610299612 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 14:13:51 2015 +0200 gitignore: add 'compile' (from autoconf) ----------------------------------------------------------------------- Summary of changes: .gitignore | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- The OpenGGSN project

1 0

openggsn.git branch neels/refactor updated. 0.91-80-gb72c2dc
by gitosis＠osmocom.org 19 Oct '15

19 Oct '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, neels/refactor has been updated discards fec3b14781797eb3d356b04566f473a94fec550f (commit) discards d7768c81ae99a0b7324562739aed0579537adc47 (commit) discards 746179370c89589ce9a4e959740a8f551a27d935 (commit) discards 5e0586df38fce1bb6edb734c1e4d1f4d9242a1f6 (commit) discards b8aae6dd3e0a0039953eb9c37f9bc720feca82e1 (commit) discards 7d62a4eaa315d689e3c1268f75c42d552f68ac81 (commit) discards c2058e0c648ff0c224da65bd1863da0b5dae542d (commit) via b72c2dc592bdaa2be86ea5b5f00a51599687c32e (commit) via b84545e30e327b429b7910dc4675b9e3e80df704 (commit) via ea458f4aa63e1a371a094d804ec4eb6ea6f8dfdd (commit) via 85c25ac91c5fe6e87e1c417ea3543149a92d4145 (commit) via 9a5cfa49ad1ce6d2cf6e9295a423e880d72dd1b5 (commit) via 878e188be73e49e96b2fe78604e7daa86cedf6ff (commit) via e845cb950544af8f0d00f5a2bed2072d795a2a7e (commit) via b18e811e24464d9b50f21674246806c3b7c25030 (commit) via 9b09738891770367f9878a1a4d1b83bc23217383 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (fec3b14781797eb3d356b04566f473a94fec550f) \ N -- N -- N (b72c2dc592bdaa2be86ea5b5f00a51599687c32e) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openggsn/commit/?id=b72c2dc592bdaa2be86ea5b5f00a515… commit b72c2dc592bdaa2be86ea5b5f00a51599687c32e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 13:26:39 2015 +0200 sgsnemu: improve an error message http://cgit.osmocom.org/openggsn/commit/?id=b84545e30e327b429b7910dc4675b9e… commit b84545e30e327b429b7910dc4675b9e3e80df704 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 13:24:51 2015 +0200 cosmetic: gtpie_gettv0(): flow readability http://cgit.osmocom.org/openggsn/commit/?id=ea458f4aa63e1a371a094d804ec4eb6… commit ea458f4aa63e1a371a094d804ec4eb6ea6f8dfdd Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 13:07:40 2015 +0200 gtpie_gettlv(): fix return value on specific error. Make gtpie_gettlv() return an error if gtpie_getie() returned an error. Previously, openggsn would fail to complain about certain missing elements. Technically, a missing IE could be detectable from the *length value, but the code in gtp.c relies on the return value to detect missing elements, which did not work prior to this commit. For example: if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l, &pdp->eua.v, sizeof(pdp->eua.v))) { gsn->missing++; GTP_LOGPKG(LOGL_ERROR, peer, pack, len, "Missing mandatory information field\n"); return gtp_create_pdp_resp(gsn, version, pdp, GTPCAUSE_MAN_IE_MISSING); } If an EUA were missing in this code path, openggsn would fail to issue an error message. Since pdp and hence pdp->eua.l is initialized as all-zero, it would probably not do much harm besides failing to issue an error. I haven't checked all callers though. http://cgit.osmocom.org/openggsn/commit/?id=85c25ac91c5fe6e87e1c417ea354314… commit 85c25ac91c5fe6e87e1c417ea3543149a92d4145 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 12 14:26:49 2015 +0200 comments: add/replace. Sponsored-by: On-Waves ehi http://cgit.osmocom.org/openggsn/commit/?id=9a5cfa49ad1ce6d2cf6e9295a423e88… commit 9a5cfa49ad1ce6d2cf6e9295a423e880d72dd1b5 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Oct 11 23:44:00 2015 +0200 comments: fix spelling/punctuation. Fix spelling/punctuation and one numbering in comments. Remove an opening brace from a comment to not mix up cindent in vim. Sponsored-by: On-Waves ehi http://cgit.osmocom.org/openggsn/commit/?id=878e188be73e49e96b2fe78604e7daa… commit 878e188be73e49e96b2fe78604e7daa86cedf6ff Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 13:46:09 2015 +0200 rename gtp_dublicate (static func). Fix spelling dublicate -> duplicate in comments and in (apparently only statically used) gtp_dublicate(). Sponsored-by: On-Waves ehi ----------------------------------------------------------------------- Summary of changes: gtp/gtpie.c | 20 ++++++++++---------- sgsnemu/sgsnemu.c | 7 +++---- 2 files changed, 13 insertions(+), 14 deletions(-) hooks/post-receive -- The OpenGGSN project

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-33-g7198039
by gitosis＠osmocom.org 18 Oct '15

18 Oct '15

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-33-g761151e
by gitosis＠osmocom.org 18 Oct '15

18 Oct '15

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-32-g268ce72
by gitosis＠osmocom.org 18 Oct '15

18 Oct '15

1 0

← Newer
1
2
3
4
5
6
7
...
13
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog October 2015