Attention is currently required from: laforge, lynxis lazus.

dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email )

Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ......................................................................

Patch Set 9: Code-Review+2 Verified+1

(2 comments)

Patchset:

PS9: To be sure it really works and that it does not break anything I have done a test with simtrace2-cardem-pcsc.c (you still have to fix this caller since it still calls the old API. For the test I have quickly hacked-in a static variable to capture the prev_ac).

Without your patch I can clearly see that the trace hangs for a second when the GET DATA happens. Then a strange status word appears and the transaction fails.

With your patch the GET DATA goes through as expected. The trace also does not hang anymore.

So I think we can now merge this patch.

File host/lib/apdu_dispatch.c:

https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/618ac047_3e4d5315?usp... : PS3, Line 120: ac->hdr.cla & 0x80 && /* check for GP */

for the record: I removed the dependency on GP and on the GET DATA APDU to have it more generic. […]

I think this makes sense. This should work fine.