Attention is currently required from: laforge, lynxis lazus.

Patch set 9:Verified +1Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #9:

    To be sure it really works and that it does not break anything I have done a test with simtrace2-cardem-pcsc.c (you still have to fix this caller since it still calls the old API. For the test I have quickly hacked-in a static variable to capture the prev_ac).

    Without your patch I can clearly see that the trace hangs for a second when the GET DATA happens. Then a strange status word appears and the transaction fails.

    With your patch the GET DATA goes through as expected. The trace also does not hang anymore.

    So I think we can now merge this patch.

• File host/lib/apdu_dispatch.c:

  • Patch Set #3, Line 120: ac->hdr.cla & 0x80 && /* check for GP */

    for the record: I removed the dependency on GP and on the GET DATA APDU to have it more generic. […]

    I think this makes sense. This should work fine.

To view, visit change 43185. To unsubscribe, or for help writing mail filters, visit settings.