Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email )

Change subject: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies() ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/xua_msg.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389/comment/c1040eae_5fb4be... : PS2, Line 549: return 0; Yes, this would be for a different commit. Just pointed out that this might be a problem with returning 0 "success" for unknown class.

BTW, if we return here anyway the code flow will reject the message a few lines afterwards at the caller when it checks the msg_class/msg_type and finds an unknown one.

True, I didn't realize that both callers of this function check it right afterwards. So it is fine here.