Attention is currently required from: pespin.

Patch set 2:Code-Review +1

View Change

1 comment:

• File src/xua_msg.c:

  • Patch Set #2, Line 549: return 0;

    Yes, this would be for a different commit. Just pointed out that this might be a problem with returning 0 "success" for unknown class.

     BTW, if we return here anyway the code flow will reject the message a few lines afterwards at the caller when it checks the msg_class/msg_type and finds an unknown one.

    True, I didn't realize that both callers of this function check it right afterwards. So it is fine here.

To view, visit change 43389. To unsubscribe, or for help writing mail filters, visit settings.