Attention is currently required from: dexter, laforge.
pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-msc/+/43229?usp=email )
Change subject: sgs_iface: guard against over-long MME name IEs. ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File src/libmsc/sgs_iface.c:
https://gerrit.osmocom.org/c/osmo-msc/+/43229/comment/ef26d6eb_bcdfeac6?usp=... : PS2, Line 165: const uint8_t *mme_name_enc = TLVP_VAL_MINLEN(tp, SGSAP_IE_MME_NAME, SGS_MME_NAME_LEN);
Done
Can you have a look at the newest version/release of the spec? What's the sense in it being exactly 55 bytes? AFAIU FQDNs are variable-size right?
https://gerrit.osmocom.org/c/osmo-msc/+/43229/comment/4c23bbc7_ef85dc5d?usp=... : PS2, Line 173: if (TLVP_LEN(tp, SGSAP_IE_MME_NAME) > mme_name_len - 1)
I like the "- 1" notation more since it tells me that the comparison is related to the handling of t […]
I'd be fine if there was not the extra problem I mentioned, so this should definitely be changed.