Attention is currently required from: dexter, laforge.

Patch set 2:Code-Review -1

View Change

2 comments:

• File src/libmsc/sgs_iface.c:

  • Patch Set #2, Line 165: const uint8_t *mme_name_enc = TLVP_VAL_MINLEN(tp, SGSAP_IE_MME_NAME, SGS_MME_NAME_LEN);

    Done

    Can you have a look at the newest version/release of the spec? What's the sense in it being exactly 55 bytes? AFAIU FQDNs are variable-size right?

  • Patch Set #2, Line 173: if (TLVP_LEN(tp, SGSAP_IE_MME_NAME) > mme_name_len - 1)

    I like the "- 1" notation more since it tells me that the comparison is related to the handling of t […]

    I'd be fine if there was not the extra problem I mentioned, so this should definitely be changed.

To view, visit change 43229. To unsubscribe, or for help writing mail filters, visit settings.