Attention is currently required from: daniel, laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email )
Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS3: why is VTY tests failing here? please explain.
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/dd8e4618_b685ab... : PS3, Line 19: Defaults to reject-utds. udts (everywhere you wrote it)
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/cc9c8bbe_85f43b... : PS3, Line 257: static struct osmo_ss7_asp *select_asp_tcap_enabled_rr(struct osmo_ss7_as *as, bool fallback) Having this param here only to tick a rate_ctr look weird tbh, I'd rather move this to the caller, and leave this helper without that kind of logic.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/18dccdfc_73954f... : PS3, Line 555: if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) else if (as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS)
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/99f17b12_1227ad... : PS3, Line 556: asp = select_asp_tcap_enabled_rr(as, true); shouldn't we be adding a track_entry here (move the call above here) so that when an Abort/End for the same session arrives it is actually delivered to the same place?