Attention is currently required from: daniel, laforge, lynxis lazus.

View Change

5 comments:

• Patchset:

  • Patch Set #3:

    why is VTY tests failing here? please explain.

• Commit Message:

  • Patch Set #3, Line 19: Defaults to reject-utds.

    udts (everywhere you wrote it)

• File src/tcap_as_loadshare.c:

  • Patch Set #3, Line 257: static struct osmo_ss7_asp *select_asp_tcap_enabled_rr(struct osmo_ss7_as *as, bool fallback)

    Having this param here only to tick a rate_ctr look weird tbh, I'd rather move this to the caller, and leave this helper without that kind of logic.

  • Patch Set #3, Line 555: if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS)

    else if (as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS)

  • Patch Set #3, Line 556: asp = select_asp_tcap_enabled_rr(as, true);

    shouldn't we be adding a track_entry here (move the call above here) so that when an Abort/End for the same session arrives it is actually delivered to the same place?

To view, visit change 42760. To unsubscribe, or for help writing mail filters, visit settings.