Attention is currently required from: dexter, jolly, jwaigel.
laforge has posted comments on this change by jwaigel. ( https://gerrit.osmocom.org/c/pysim/+/43205?usp=email )
Change subject: osmo-smdpp: derive the Profile Metadata from the Profile ......................................................................
Patch Set 2:
(1 comment)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/43205/comment/f03ad87a_29fb6b15?usp=ema... : PS2, Line 638: # look up profile based on matchingID. We simply check if a given file exists for now.. I don't like that the 'if matchingId' (or alternatively an 'else' clause) has been removed here. So if someone ever implementst he above TODO for EID based downoad, they have to re-introduce it. That change in this patch seems completely unrelated to the actual purpose. Please consider undoing that part; otherwise I think this patch is fine and a welcome contribution.