Attention is currently required from: dexter, jolly, jwaigel.

View Change

1 comment:

• File osmo-smdpp.py:

  • Patch Set #2, Line 638: # look up profile based on matchingID. We simply check if a given file exists for now..

    I don't like that the 'if matchingId' (or alternatively an 'else' clause) has been removed here. So if someone ever implementst he above TODO for EID based downoad, they have to re-introduce it. That change in this patch seems completely unrelated to the actual purpose. Please consider undoing that part; otherwise I think this patch is fine and a welcome contribution.

To view, visit change 43205. To unsubscribe, or for help writing mail filters, visit settings.