Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email )
Change subject: libosmo-trx/client: add TRXC client (command queue) API ......................................................................
Patch Set 3:
(3 comments)
File libosmo-trx/include/osmocom/trx/trxc_client.h:
https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/5b2e27b3_339276b2?usp=... : PS1, Line 32: struct osmo_trxc_client_ops {
I'd rather add APIs to set each callbacks and private pointers, as done in osmo_stream, to allow for […]
Acknowledged
File libosmo-trx/src/trxc_client.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/2f361e90_f7e479c1?usp=... : PS1, Line 190: void osmo_trxc_client_set_retrans(struct osmo_trxc_client *client, unsigned int sec)
set_restrans_timeout?Is 0 allowed? document it and if not allowed return an error.
Done
https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/0918f3a6_ebfa27aa?usp=... : PS1, Line 481: client->setformat_ver_req = ver_max;
I'd rather store the user cb + cb_data in a struct, pass it to osmo_trxc_client_send_cmd() below ins […]
Good idea, done.