Attention is currently required from: pespin.

View Change

3 comments:

• File libosmo-trx/include/osmocom/trx/trxc_client.h:

  • Patch Set #1, Line 32: struct osmo_trxc_client_ops {

    I'd rather add APIs to set each callbacks and private pointers, as done in osmo_stream, to allow for […]

    Acknowledged

• File libosmo-trx/src/trxc_client.c:

  • Patch Set #1, Line 190: void osmo_trxc_client_set_retrans(struct osmo_trxc_client *client, unsigned int sec)

    set_restrans_timeout?Is 0 allowed? document it and if not allowed return an error.

    Done

  • Patch Set #1, Line 481: client->setformat_ver_req = ver_max;

    I'd rather store the user cb + cb_data in a struct, pass it to osmo_trxc_client_send_cmd() below ins […]

    Good idea, done.

To view, visit change 43108. To unsubscribe, or for help writing mail filters, visit settings.