- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: doc/examples: avoid using deprecated configuration commands
by pespin 01 Apr '22

01 Apr '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27628 ) Change subject: doc/examples: avoid using deprecated configuration commands ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id29fae10ec17eb3d0ac8534d8aebd7251a17577d Gerrit-Change-Number: 27628 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Apr 2022 10:10:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: doc/examples: add a multi-trx config config example
by fixeria 01 Apr '22

01 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27629 ) Change subject: doc/examples: add a multi-trx config config example ...................................................................... doc/examples: add a multi-trx config config example So far we had no multi-trx config examples at all. Let's add one. Use unique 'RSL TEI' for each TRX, as this simplifies analyzing the Abis protocol traces. Also use the new 'TCH/F_TCH/H_SDCCH8_PDCH'. Change-Id: I20f86fa74dc4bd71538627ec59c5d2cd3678a089 Fixes: OS#4748 --- A doc/examples/osmo-bsc/osmo-bsc-4trx.cfg 1 file changed, 161 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/27629/1 diff --git a/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg b/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg new file mode 100644 index 0000000..68d6a38 --- /dev/null +++ b/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg @@ -0,0 +1,161 @@ +! osmo-bsc configuration example with 4 TRX +e1_input + e1_line 0 driver ipa +network + network country code 1 + mobile network code 1 + encryption a5 0 + neci 1 + paging any use tch 0 + bts 0 + type osmo-bts + band DCS1800 + cell_identity 6969 + location_area_code 1 + base_station_id_code 63 + ms max power 15 + cell reselection hysteresis 4 + rxlev access min 0 + radio-link-timeout 32 + channel allocator ascending + rach tx integer 9 + rach max transmission 7 + channel-description attach 1 + channel-description bs-pa-mfrms 5 + channel-description bs-ag-blks-res 1 + early-classmark-sending forbidden + ipa unit-id 6969 0 + oml ipa stream-id 255 line 0 + codec-support fr hr amr + gprs mode none + trx 0 + rf_locked 0 + arfcn 871 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 0 + timeslot 0 + phys_chan_config CCCH + hopping enabled 0 + timeslot 1 + phys_chan_config SDCCH8+CBCH + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + trx 1 + rf_locked 0 + arfcn 873 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 1 + timeslot 0 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 1 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + trx 2 + rf_locked 0 + arfcn 875 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 2 + timeslot 0 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 1 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + trx 3 + rf_locked 0 + arfcn 877 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 3 + timeslot 0 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 1 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F_TCH/H_SDCCH8_PDCH + hopping enabled 0 +msc 0 + allow-emergency allow + mgw remote-ip 127.0.0.1 + mgw remote-port 2427 + mgw local-port 2727 +bsc + mid-call-timeout 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I20f86fa74dc4bd71538627ec59c5d2cd3678a089 Gerrit-Change-Number: 27629 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: doc/examples: add a confmerge file with example hopping parameters
by fixeria 01 Apr '22

01 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27630 ) Change subject: doc/examples: add a confmerge file with example hopping parameters ...................................................................... doc/examples: add a confmerge file with example hopping parameters This file was taken from docker-playground.git, and this is basically what we use when running the ttcn3-bts-test with hopping enabled. Change-Id: I205eb53901e06ee52dc64e050cfe2374cb9c771e --- M doc/examples/Makefile.am A doc/examples/osmo-bsc/osmo-bsc-4trx-fh.confmerge 2 files changed, 217 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/30/27630/1 diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am index 9d8cd75..c25ebc5 100644 --- a/doc/examples/Makefile.am +++ b/doc/examples/Makefile.am @@ -6,7 +6,7 @@ EXTRA_DIST = $(OSMOCONF_FILES) -CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,' +CFG_FILES = find $(srcdir) -name '*.cfg*' -o -name '*.confmerge*' | sed -e 's,^$(srcdir),,' dist-hook: for f in $$($(CFG_FILES)); do \ diff --git a/doc/examples/osmo-bsc/osmo-bsc-4trx-fh.confmerge b/doc/examples/osmo-bsc/osmo-bsc-4trx-fh.confmerge new file mode 100644 index 0000000..0a14631 --- /dev/null +++ b/doc/examples/osmo-bsc/osmo-bsc-4trx-fh.confmerge @@ -0,0 +1,216 @@ +! This is a confmerge file with example frequency hopping parameters. +! Use the osmo-config-merge tool to apply it to osmo-bsc-4trx.cfg. +network + bts 0 + trx 0 + timeslot 0 + ! Shall not be hopping + timeslot 1 + ! Intentionally non-hopping + timeslot 2 + ! (c) HSN=2, MAIO=0,1 + hopping enabled 1 + hopping sequence-number 2 + hopping maio 0 + hopping arfcn add 871 + hopping arfcn add 873 + timeslot 3 + ! (e) HSN=3, MAIO=3,2,1,0 + hopping enabled 1 + hopping sequence-number 3 + hopping maio 3 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 4 + ! Intentionally non-hopping + timeslot 5 + ! (f) HSN=5, MAIO=0,1,2,3 + hopping enabled 1 + hopping sequence-number 5 + hopping maio 0 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 6 + ! (g) HSN=6, MAIO=1,0 + hopping enabled 1 + hopping sequence-number 6 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 877 + timeslot 7 + ! (i) HSN=0, MAIO=1,3 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 875 + trx 1 + timeslot 0 + ! (a) HSN=0, MAIO=0,1,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 0 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 1 + ! Intentionally non-hopping + timeslot 2 + ! (c) HSN=2, MAIO=0,1 + hopping enabled 1 + hopping sequence-number 2 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 873 + timeslot 3 + ! (e) HSN=3, MAIO=3,2,1,0 + hopping enabled 1 + hopping sequence-number 3 + hopping maio 2 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 4 + ! Intentionally non-hopping + timeslot 5 + ! (f) HSN=5, MAIO=0,1,2,3 + hopping enabled 1 + hopping sequence-number 5 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 6 + ! (h) HSN=6, MAIO=1,0 + hopping enabled 1 + hopping sequence-number 6 + hopping maio 1 + hopping arfcn add 873 + hopping arfcn add 875 + timeslot 7 + ! (j) HSN=0, MAIO=0,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 0 + hopping arfcn add 873 + hopping arfcn add 877 + trx 2 + timeslot 0 + ! (a) HSN=0, MAIO=0,1,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 1 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 1 + ! (b) HSN=1, MAIO=3,5 + hopping enabled 1 + hopping sequence-number 1 + hopping maio 3 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 2 + ! (d) HSN=2, MAIO=2,3 + hopping enabled 1 + hopping sequence-number 2 + hopping maio 2 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 3 + ! (e) HSN=3, MAIO=3,2,1,0 + hopping enabled 1 + hopping sequence-number 3 + hopping maio 1 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 4 + ! Intentionally non-hopping + timeslot 5 + ! (f) HSN=5, MAIO=0,1,2,3 + hopping enabled 1 + hopping sequence-number 5 + hopping maio 2 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 6 + ! (h) HSN=6, MAIO=1,0 + hopping enabled 1 + hopping sequence-number 6 + hopping maio 0 + hopping arfcn add 873 + hopping arfcn add 875 + timeslot 7 + ! (i) HSN=0, MAIO=1,3 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 3 + hopping arfcn add 871 + hopping arfcn add 875 + trx 3 + timeslot 0 + ! (a) HSN=0, MAIO=0,1,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 2 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 1 + ! (b) HSN=1, MAIO=3,5 + hopping enabled 1 + hopping sequence-number 1 + hopping maio 5 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 2 + ! (d) HSN=2, MAIO=2,3 + hopping enabled 1 + hopping sequence-number 2 + hopping maio 3 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 3 + ! (e) HSN=3, MAIO=3,2,1,0 + hopping enabled 1 + hopping sequence-number 3 + hopping maio 0 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 4 + ! Intentionally non-hopping + timeslot 5 + ! (f) HSN=5, MAIO=0,1,2,3 + hopping enabled 1 + hopping sequence-number 5 + hopping maio 3 + hopping arfcn add 871 + hopping arfcn add 873 + hopping arfcn add 875 + hopping arfcn add 877 + timeslot 6 + ! (g) HSN=6, MAIO=1,0 + hopping enabled 1 + hopping sequence-number 6 + hopping maio 0 + hopping arfcn add 871 + hopping arfcn add 877 + timeslot 7 + ! (j) HSN=0, MAIO=0,2 + hopping enabled 1 + hopping sequence-number 0 + hopping maio 2 + hopping arfcn add 873 + hopping arfcn add 877 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I205eb53901e06ee52dc64e050cfe2374cb9c771e Gerrit-Change-Number: 27630 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: doc/examples: avoid using deprecated configuration commands
by fixeria 01 Apr '22

01 Apr '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27628 ) Change subject: doc/examples: avoid using deprecated configuration commands ...................................................................... doc/examples: avoid using deprecated configuration commands Change-Id: Id29fae10ec17eb3d0ac8534d8aebd7251a17577d --- M doc/examples/osmo-bsc/osmo-bsc.cfg M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/27628/1 diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg b/doc/examples/osmo-bsc/osmo-bsc.cfg index 807bd19..c86a491 100644 --- a/doc/examples/osmo-bsc/osmo-bsc.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc.cfg @@ -17,7 +17,8 @@ handover1 power budget interval 6 handover1 power budget hysteresis 3 handover1 maximum distance 9999 - periodic location update 30 + ! T3212 is in units of 6min, so below we set 5 * 6 = 30min + timer net T3212 5 bts 0 type osmo-bts band DCS1800 @@ -71,7 +72,6 @@ phys_chan_config TCH/F hopping enabled 0 msc 0 - type normal allow-emergency allow amr-config 12_2k forbidden amr-config 10_2k forbidden @@ -84,6 +84,5 @@ mgw remote-ip 127.0.0.1 mgw remote-port 2427 mgw local-port 2727 - mgw endpoint-range 1 31 bsc mid-call-timeout 0 diff --git a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg index 335e23d..e60f39a 100644 --- a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg @@ -16,7 +16,8 @@ handover1 power budget interval 6 handover1 power budget hysteresis 3 handover1 maximum distance 9999 - periodic location update 30 + ! T3212 is in units of 6min, so below we set 5 * 6 = 30min + timer net T3212 5 bts 0 type osmo-bts band DCS1800 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id29fae10ec17eb3d0ac8534d8aebd7251a17577d Gerrit-Change-Number: 27628 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): get rid of chan_state->meas_avg_facch
by fixeria 01 Apr '22

01 Apr '22

Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27552 ) Change subject: osmo-bts-trx: rx_tchh_fn(): get rid of chan_state->meas_avg_facch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, definitely. We can wait until he's back, not urgent. @dexter, friendly ping. Would be good to know your opinion on this approach. Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7902b4709bc3f418174e8373f52e87bb31cdc826 Gerrit-Change-Number: 27552 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Apr 2022 02:22:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchf,tchh}_fn(): ensure complete set of bursts
by fixeria 01 Apr '22

01 Apr '22

Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27555 ) Change subject: osmo-bts-trx: rx_{tchf,tchh}_fn(): ensure complete set of bursts ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm wondering if there aren't speech modes where codec blocks with missing bursts still contain sufficient data (after decode) to produce something useful? Correct, there are. But I think it's not that critical if we loose *just one* speech frame after the channel activation. What we benefit from this approach is the ability to quickly lookup TDMA frame number from the measurement history (see Id9a2b7b0f1a1ad7cfbbab862faf521e135c90605), and also eliminate one or two measurement samples in the beginning with BER10k>0 for TCH/F and TCH/H, respectively. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I56bebe1374eb803e3c1e9f08dda4da50a074ab0b Gerrit-Change-Number: 27555 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Apr 2022 02:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: WIP: llc: schedule frames to MS based on SAPI priority
by fixeria 01 Apr '22

01 Apr '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27627 ) Change subject: WIP: llc: schedule frames to MS based on SAPI priority ...................................................................... Patch Set 1: (3 comments) File src/llc.h: https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/6d6517e7_94c95273 PS1, Line 37: union This line as well as the address field can be moved out of the conditional block to avoid duplication. File src/llc.c: https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/82fc5a97_ecf7b419 PS1, Line 99: int i For the sake of consistency with llc_queue_clear(), it should be unsigned. https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/4f82228a_f118a575 PS1, Line 112: Unusual formatting. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie8bd91eeac4fa7487d4f11b808dea95737041c7e Gerrit-Change-Number: 27627 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Mar 2022 18:54:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: llc: Move static functions below related object
by fixeria 01 Apr '22

01 Apr '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27626 ) Change subject: llc: Move static functions below related object ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If781e66c6e8a119cc22948c82167ceb90270ea6d Gerrit-Change-Number: 27626 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Mar 2022 18:44:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: llc: Convert to C
by fixeria 01 Apr '22

01 Apr '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27623 ) Change subject: llc: Convert to C ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I250680ba581167d7398b2f734769c756cbb61c48 Gerrit-Change-Number: 27623 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Mar 2022 18:43:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: llc: Convert to C: s/m_//g
by fixeria 01 Apr '22

01 Apr '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27622 ) Change subject: llc: Convert to C: s/m_//g ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia5272841392110b87725e87a7e6824c17a70d6d1 Gerrit-Change-Number: 27622 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Mar 2022 18:43:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log