- gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: soft_uart: implement the transmitter
by laforge 19 Nov '23

19 Nov '23

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email ) Change subject: soft_uart: implement the transmitter ...................................................................... Patch Set 4: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35044/comment/991cb7b7_fb24c1dd PS4, Line 206: msgb_pull_u8 what if the msgb doesn't have anything to pull anymore? Ah, I guess that's why you check msg->len above. It would be more elegant to avoid dereferencing msgb internals and instead use msgb_length(msg) here. The Linux kernel has the even more elegant skb_may_pull(skb, num_of_bytes) function, which sadly seems we didn't add to our msgb code. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Gerrit-Change-Number: 35044 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:28:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: soft_uart: rework osmo_uart_rx_bit() to use flow state
by fixeria 19 Nov '23

19 Nov '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35022?usp=email ) Change subject: soft_uart: rework osmo_uart_rx_bit() to use flow state ...................................................................... Patch Set 3: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35022/comment/f24f2443_d553717e PS2, Line 128: suart->rx.shift_reg |= 0x80 > Misaligned, as I stated in previous patch. This goal of this patch is to reorganize/refactor the code. I fixed the alignment problem separately in https://gerrit.osmocom.org/c/libosmocore/+/35066, since this is a bug in original Harald's code. Marking as resolved. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I40ab5d12b6f7087daa51405468f5c4ea639561ea Gerrit-Change-Number: 35022 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:27:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: core: Add software UART implementation
by fixeria 19 Nov '23

19 Nov '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 3: (2 comments) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/dfbafd32_d1fffb20 PS3, Line 28: uart_parity_mode > For completeness you should add OSMO_SUART_PARITY_MARK and OSMO_SUART_PARITY_SPACE. […] Done, please see https://gerrit.osmocom.org/c/libosmocore/+/35067. File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/fe02a36a_8ad3570e PS3, Line 127: suart->rx.shift_reg |= 0x80 > The last RX bit is always MSB of shift_reg. […] Indeed, thanks. I also uncovered this when improving the unit tests. This is now fixed, please see: https://gerrit.osmocom.org/c/libosmocore/+/35066. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:23:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: soft_uart: rework osmo_uart_rx_bit() to use flow state
by laforge 19 Nov '23

19 Nov '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35022?usp=email ) Change subject: soft_uart: rework osmo_uart_rx_bit() to use flow state ...................................................................... Patch Set 3: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I40ab5d12b6f7087daa51405468f5c4ea639561ea Gerrit-Change-Number: 35022 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:23:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: soft_uart: make osmo_soft_uart_alloc() accept *cfg
by laforge 19 Nov '23

19 Nov '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email ) Change subject: soft_uart: make osmo_soft_uart_alloc() accept *cfg ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS2: > * mixes two different topics in one patch […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e78d60c747a8805064d5e4bacfd47a30bc65cba Gerrit-Change-Number: 35021 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:22:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES
by fixeria 19 Nov '23

19 Nov '23

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email ) Change subject: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3249a06c84f3ddb2723d0787db51873c4707d81 Gerrit-Change-Number: 35045 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 0

[S] Change in libosmocore[master]: tests/testsuite.at: remove copy-pasted 'touch experr'
by laforge 19 Nov '23

19 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35017?usp=email ) Change subject: tests/testsuite.at: remove copy-pasted 'touch experr' ...................................................................... tests/testsuite.at: remove copy-pasted 'touch experr' Doing this after creating a file yields nothing. Change-Id: Ib3bdaf6db25e4a2995abdff5c859d4be023d45a9 --- M tests/testsuite.at 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/testsuite.at b/tests/testsuite.at index 3366995..73c3cdc 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -355,7 +355,6 @@ AT_KEYWORDS([socket]) cat $abs_srcdir/socket/socket_test.ok > expout cat $abs_srcdir/socket/socket_test.err > experr -touch experr AT_CHECK([$abs_top_builddir/tests/socket/socket_test], [0], [expout], [experr]) AT_CLEANUP @@ -364,7 +363,6 @@ AT_SKIP_IF([! test -e $abs_top_builddir/tests/socket/socket_sctp_test]) cat $abs_srcdir/socket/socket_sctp_test.ok > expout cat $abs_srcdir/socket/socket_sctp_test.err > experr -touch experr AT_CHECK([$abs_top_builddir/tests/socket/socket_sctp_test], [0], [expout], [experr]) AT_CLEANUP @@ -513,6 +511,5 @@ AT_KEYWORDS([osmo_io]) cat $abs_srcdir/osmo_io/osmo_io_test.ok > expout cat $abs_srcdir/osmo_io/osmo_io_test.err > experr -touch experr AT_CHECK([$abs_top_builddir/tests/osmo_io/osmo_io_test], [0], [expout], [experr]) AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3bdaf6db25e4a2995abdff5c859d4be023d45a9 Gerrit-Change-Number: 35017 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: tests/testsuite.at: remove copy-pasted 'touch experr'
by laforge 19 Nov '23

19 Nov '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35017?usp=email ) Change subject: tests/testsuite.at: remove copy-pasted 'touch experr' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3bdaf6db25e4a2995abdff5c859d4be023d45a9 Gerrit-Change-Number: 35017 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:21:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: soft_uart: implement the transmitter
by fixeria 19 Nov '23

19 Nov '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email ) Change subject: soft_uart: implement the transmitter ...................................................................... Patch Set 4: (1 comment) This change is ready for review. File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35044/comment/41b74674_f6885c5c PS2, Line 209: size_t osmo_soft_uart_tx(struct osmo_soft_uart *suart, > I agree with having a call-back function for the transmitter to get data from the application. […] I have implemented the suggested concept. Thanks for your input! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Gerrit-Change-Number: 35044 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter
by fixeria 19 Nov '23

19 Nov '23

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: soft_uart: add unit tests for the receiver and transmitter ...................................................................... soft_uart: add unit tests for the receiver and transmitter Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Related: OS#4396 --- M tests/Makefile.am A tests/soft_uart/soft_uart_test.c A tests/soft_uart/soft_uart_test.ok M tests/testsuite.at 4 files changed, 448 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/35046/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Gerrit-Change-Number: 35046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log