Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 3: (2 comments) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/dfbafd32_d1fffb20 PS3, Line 28: uart_parity_mode

For completeness you should add OSMO_SUART_PARITY_MARK and OSMO_SUART_PARITY_SPACE. […] Done, please see https://gerrit.osmocom.org/c/libosmocore/+/35067.

File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/fe02a36a_8ad3570e PS3, Line 127: suart->rx.shift_reg |= 0x80

The last RX bit is always MSB of shift_reg. […] Indeed, thanks. I also uncovered this when improving the unit tests. This is now fixed, please see: https://gerrit.osmocom.org/c/libosmocore/+/35066.

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:23:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas@eversberg.eu> Gerrit-MessageType: comment